[kudu-CR](branch-0.9.x) rpcz: break out trace metrics into separate PB fields
Jean-Daniel Cryans has posted comments on this change. Change subject: rpcz: break out trace metrics into separate PB fields .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8bd1a249b2f09f8eb63bc64de55147b3d7738a9c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR](branch-0.9.x) rpcz: break out trace metrics into separate PB fields
Jean-Daniel Cryans has submitted this change and it was merged. Change subject: rpcz: break out trace metrics into separate PB fields .. rpcz: break out trace metrics into separate PB fields This removes the trace metrics from the textual trace dump and instead adds some structured metrics information to the /rpcz page. This should be easier to read in the /rpcz output, and also easier to parse from any future analysis tools we might build. I updated the test and also manually verified the new output on a CreateTableRequestPB on a local instance. Here's the metrics from that call: "metrics": [ { "child_path": "txn", "key": "apply.queue_time_us", "value": 168 }, { "child_path": "txn", "key": "apply.run_wall_time_us", "value": 584 }, { "child_path": "txn", "key": "apply.run_cpu_time_us", "value": 584 }, { "child_path": "txn", "key": "prepare.run_cpu_time_us", "value": 684 }, { "child_path": "txn", "key": "prepare.queue_time_us", "value": 168 }, { "child_path": "txn", "key": "prepare.run_wall_time_us", "value": 683 }, { "child_path": "txn", "key": "threads_started", "value": 2 }, { "child_path": "txn", "key": "thread_start_us", "value": 201 }, { "child_path": "txn", "key": "num_ops", "value": 2 }, { "child_path": "txn", "key": "replication_time_us", "value": 579 } Change-Id: I8bd1a249b2f09f8eb63bc64de55147b3d7738a9c Reviewed-on: http://gerrit.cloudera.org:8080/3092 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans Reviewed-by: Adar Dembo (cherry picked from commit 08b66007c7eee301ba7e77ed11a7c48e3eefd72c) Reviewed-on: http://gerrit.cloudera.org:8080/3195 --- M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_introspection.proto M src/kudu/rpc/rpc_stub-test.cc M src/kudu/rpc/rpcz_store.cc M src/kudu/util/trace.cc M src/kudu/util/trace.h 6 files changed, 77 insertions(+), 3 deletions(-) Approvals: Jean-Daniel Cryans: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8bd1a249b2f09f8eb63bc64de55147b3d7738a9c Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins
[kudu-CR](branch-0.9.x) rpcz: break out trace metrics into separate PB fields
Todd Lipcon has uploaded a new change for review. http://gerrit.cloudera.org:8080/3195 Change subject: rpcz: break out trace metrics into separate PB fields .. rpcz: break out trace metrics into separate PB fields This removes the trace metrics from the textual trace dump and instead adds some structured metrics information to the /rpcz page. This should be easier to read in the /rpcz output, and also easier to parse from any future analysis tools we might build. I updated the test and also manually verified the new output on a CreateTableRequestPB on a local instance. Here's the metrics from that call: "metrics": [ { "child_path": "txn", "key": "apply.queue_time_us", "value": 168 }, { "child_path": "txn", "key": "apply.run_wall_time_us", "value": 584 }, { "child_path": "txn", "key": "apply.run_cpu_time_us", "value": 584 }, { "child_path": "txn", "key": "prepare.run_cpu_time_us", "value": 684 }, { "child_path": "txn", "key": "prepare.queue_time_us", "value": 168 }, { "child_path": "txn", "key": "prepare.run_wall_time_us", "value": 683 }, { "child_path": "txn", "key": "threads_started", "value": 2 }, { "child_path": "txn", "key": "thread_start_us", "value": 201 }, { "child_path": "txn", "key": "num_ops", "value": 2 }, { "child_path": "txn", "key": "replication_time_us", "value": 579 } Change-Id: I8bd1a249b2f09f8eb63bc64de55147b3d7738a9c Reviewed-on: http://gerrit.cloudera.org:8080/3092 Tested-by: Kudu Jenkins Reviewed-by: Jean-Daniel Cryans Reviewed-by: Adar Dembo (cherry picked from commit 08b66007c7eee301ba7e77ed11a7c48e3eefd72c) --- M src/kudu/rpc/rpc-test-base.h M src/kudu/rpc/rpc_introspection.proto M src/kudu/rpc/rpc_stub-test.cc M src/kudu/rpc/rpcz_store.cc M src/kudu/util/trace.cc M src/kudu/util/trace.h 6 files changed, 77 insertions(+), 3 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/95/3195/1 -- To view, visit http://gerrit.cloudera.org:8080/3195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I8bd1a249b2f09f8eb63bc64de55147b3d7738a9c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: branch-0.9.x Gerrit-Owner: Todd Lipcon