[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has abandoned this change.

Change subject: Fix .gitignore
..


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/3480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon 


[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change.

Change subject: Fix .gitignore
..


Patch Set 1:

Although I guess I should add that the reason it does this is that jekyll will 
see all your untracked files, think they are actually part of the site, and try 
to publish them... which is probably not what you want. I guess we could add 
another step which uses 'git archive' to create a clean second checkout and run 
jekyll from there, but requiring a clean workdir seems easier

-- 
To view, visit http://gerrit.cloudera.org:8080/3480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change.

Change subject: Fix .gitignore
..


Patch Set 1:

It's just trying to prevent you from tryig to 'publish' when in fact you forgot 
to 'git add' something. Could add a --ignore-untracked if you want?

-- 
To view, visit http://gerrit.cloudera.org:8080/3480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change.

Change subject: Fix .gitignore
..


Patch Set 1:

> this seems kind of fragile.. why not just use a different checkout
 > for this branch?

I'd argue that site_tool is fragile.

-- 
To view, visit http://gerrit.cloudera.org:8080/3480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change.

Change subject: Fix .gitignore
..


Patch Set 1:

this seems kind of fragile.. why not just use a different checkout for this 
branch?

-- 
To view, visit http://gerrit.cloudera.org:8080/3480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No


[kudu-CR](gh-pages) Fix .gitignore

2016-06-24 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3480

Change subject: Fix .gitignore
..

Fix .gitignore

Not having untracked files now matters more with 'site_tool publish'. In my
case I switch between 'gh-pages' and 'master' at lot so I have untracked files.

Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67
---
M .gitignore
1 file changed, 7 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/3480/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3480
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I266cde97d338783485a8e5c426f8168f639fcb67
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Jean-Daniel Cryans