[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[Todd Lipcon (Code Review)]

Todd Lipcon has submitted this change and it was merged.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Add information about Exactly Once RPC semantics to rpc.md

This patch adds some info about exactly one rpc semantics to
rpc.md, mostly from a usage perspective.

Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Reviewed-on: http://gerrit.cloudera.org:8080/3503
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M docs/design-docs/rpc.md
1 file changed, 28 insertions(+), 0 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 7:

Build Started http://104.196.14.100/job/kudu-gerrit/2361/

-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 6: Verified+1

unrelated failure.

-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 6:

Build Started http://104.196.14.100/job/kudu-gerrit/2343/

-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 5: Verified+1

unrelated java failure

-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2258/

-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[David Ribeiro Alves (Code Review)]

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3503

to look at the new patch set (#4).

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..

Add information about Exactly Once RPC semantics to rpc.md

This patch adds some info about exactly one rpc semantics to
rpc.md, mostly from a usage perspective.

Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
---
M docs/design-docs/rpc.md
1 file changed, 28 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/03/3503/4
-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[David Ribeiro Alves (Code Review)]

David Ribeiro Alves has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 3:

(3 comments)

I'm rejiggering the patches but I don't think we need to merge them all, so at 
least for now, keeping this one separate.

http://gerrit.cloudera.org:8080/#/c/3503/1/docs/design-docs/rpc.md
File docs/design-docs/rpc.md:

PS1, Line 171: RPCs that require exactly once semantics can benefit from them 
by enabling
 : the 'track_rpc_result' option when declaring a service interface 
method.
> Nit: how about: "RPCs that require exactly once semantics can enable them b
Done


PS1, Line 191: no automatic
 : care
> Nit: "automatic care" is a strange phrase. Can you reword?
Done


http://gerrit.cloudera.org:8080/#/c/3503/3/docs/design-docs/rpc.md
File docs/design-docs/rpc.md:

Line 192: care is taken to persist results (make responses live through 
restarts),
> see comments on earlier rev about some of the wording
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3503/3/docs/design-docs/rpc.md
File docs/design-docs/rpc.md:

Line 192: care is taken to persist results (make responses live through 
restarts),
see comments on earlier rev about some of the wording


-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[Todd Lipcon (Code Review)]

Todd Lipcon has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 3:

also, perhaps this should be merged into the 'integrate into the rpc subsystem' 
patch?

-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 3:

Build Started http://104.196.14.100/job/kudu-gerrit/2163/

-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Add information about Exactly Once RPC semantics to rpc.md

[Kudu Jenkins (Code Review)]

Kudu Jenkins has posted comments on this change.

Change subject: Add information about Exactly Once RPC semantics to rpc.md
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2008/

-- 
To view, visit http://gerrit.cloudera.org:8080/3503
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8acf4e830eb673b6a696b12188bb9aafb65b261e
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No