[kudu-CR] Add request id and sequence number to the rpc request header
David Ribeiro Alves has submitted this change and it was merged. Change subject: Add request id and sequence number to the rpc request header .. Add request id and sequence number to the rpc request header This adds a new (optional) field to RpcHeader: RequestIdPB. This new field contains the information necessary to implement the "replay cache" component, including the unique id of the client and the rpc's sequence number. RequestIdPB also includes two additional "helper" fields, one to keep track of number of attempts of a particular rpc, so that we can skip the replay cache altogether in certain cases and one to let the server know that it can garbage collect completion records. Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Reviewed-on: http://gerrit.cloudera.org:8080/3079 Tested-by: Kudu Jenkins Reviewed-by: David Ribeiro Alves --- M src/kudu/rpc/rpc_header.proto 1 file changed, 22 insertions(+), 0 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add request id and sequence number to the rpc request header
David Ribeiro Alves has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 6: submitting this. I can take care of any further comments todd has post-commit -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add request id and sequence number to the rpc request header
David Ribeiro Alves has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 6: Keeping the +2 since this was just a rebase. -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add request id and sequence number to the rpc request header
David Ribeiro Alves has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 6: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] Add request id and sequence number to the rpc request header
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3079 to look at the new patch set (#6). Change subject: Add request id and sequence number to the rpc request header .. Add request id and sequence number to the rpc request header This adds a new (optional) field to RpcHeader: RequestIdPB. This new field contains the information necessary to implement the "replay cache" component, including the unique id of the client and the rpc's sequence number. RequestIdPB also includes two additional "helper" fields, one to keep track of number of attempts of a particular rpc, so that we can skip the replay cache altogether in certain cases and one to let the server know that it can garbage collect completion records. Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 --- M src/kudu/rpc/rpc_header.proto 1 file changed, 22 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/3079/6 -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Gerrit-PatchSet: 6 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] Add request id and sequence number to the rpc request header
Adar Dembo has posted comments on this change. Change subject: Add request id and sequence number to the rpc request header .. Patch Set 5: Code-Review+2 Looks good to me, leaving open for Todd. -- To view, visit http://gerrit.cloudera.org:8080/3079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I30b07f070f8e80aaad982ccfe71ffb7e22a6a703 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No