[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 6: Code-Review+2 Verified+1 -- To view, visit http://gerrit.cloudera.org:8080/3409 To unsub

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has submitted this change and it was merged. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Clarify the difference between 'call_id' and 'request_id' This adds a bit more information on

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-22 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 6: Build Started http://104.196.14.100/job/kudu-gerrit/1934/ -- To view, visit http://ger

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-22 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 5: not sure, not a big fan of those either. plus refactoring the whole sequence to

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-22 Thread Todd Lipcon (Code Review)
Todd Lipcon has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 5: I still kind of wish that we would introduce a new term here throughout the code, not ju

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 5: Verified+1 unrelated flake MasterTest.TestMasterMetadataConsistentDespiteFailures

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 5: Code-Review+2 keeping adar's plus 2 but leaving open in case Todd wants to take a

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 5: Build Started http://104.196.14.100/job/kudu-gerrit/1912/ -- To view, visit http://ger

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 4: -Verified Build Started http://104.196.14.100/job/kudu-gerrit/1906/ -- To view, visit

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Adar Dembo, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3409 to look at the new patch set (#4). Change subject: Clarify the difference between 'call_id' and 'request_id' ...

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3409 To unsubscribe, visi

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 3: Build Started http://104.196.14.100/job/kudu-gerrit/1895/ -- To view, visit http://ger

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
Hello Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3409 to look at the new patch set (#3). Change subject: Clarify the difference between 'call_id' and 'request_id' .. Cla

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3409/2/src/kudu/rpc/rpc_header.p

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3409/2/src/kudu/rpc/rpc_header.proto File

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change. Change subject: Clarify the difference between 'call_id' and 'request_id' .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/1877/ -- To view, visit http://ger

[kudu-CR] Clarify the difference between 'call id' and 'request id'

2016-06-20 Thread David Ribeiro Alves (Code Review)
David Ribeiro Alves has uploaded a new patch set (#2). Change subject: Clarify the difference between 'call_id' and 'request_id' .. Clarify the difference between 'call_id' and 'request_id' This adds a bit more information on th