[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

2016-05-31 Thread Dan Burkert (Code Review)
Dan Burkert has posted comments on this change.

Change subject: KUDU-1470 Exceptions on getting a column value should return 
the column name not the column number
..


Patch Set 3: Code-Review+2

Looks good, I'm retrying the jenkins run.

-- 
To view, visit http://gerrit.cloudera.org:8080/3231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ted Malaska 
Gerrit-HasComments: No


[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

2016-05-28 Thread Ted Malaska (Code Review)
Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/3231

to look at the new patch set (#3).

Change subject: KUDU-1470 Exceptions on getting a column value should return 
the column name not the column number
..

KUDU-1470 Exceptions on getting a column value should return the column name 
not the column number

Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
---
M java/kudu-client/src/main/java/org/kududb/client/RowResult.java
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3231/3
-- 
To view, visit http://gerrit.cloudera.org:8080/3231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ted Malaska 


[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

2016-05-27 Thread Ted Malaska (Code Review)
Ted Malaska has posted comments on this change.

Change subject: KUDU-1470 Exceptions on getting a column value should return 
the column name not the column number
..


Patch Set 2:

Thanks Dan.  I will have a patch by end of day to fix these issues

-- 
To view, visit http://gerrit.cloudera.org:8080/3231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ted Malaska 
Gerrit-HasComments: No


[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

2016-05-26 Thread Ted Malaska (Code Review)
Ted Malaska has posted comments on this change.

Change subject: KUDU-1470 Exceptions on getting a column value should return 
the column name not the column number
..


Patch Set 2:

I made a second patch because I noticed my indention was off.

-- 
To view, visit http://gerrit.cloudera.org:8080/3231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Ted Malaska 
Gerrit-HasComments: No


[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

2016-05-26 Thread Ted Malaska (Code Review)
Ted Malaska has uploaded a new patch set (#2).

Change subject: KUDU-1470 Exceptions on getting a column value should return 
the column name not the column number
..

KUDU-1470 Exceptions on getting a column value should return the column name 
not the column number

Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
---
M java/kudu-client/src/main/java/org/kududb/client/RowResult.java
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3231/2
-- 
To view, visit http://gerrit.cloudera.org:8080/3231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska 
Gerrit-Reviewer: Kudu Jenkins


[kudu-CR] KUDU-1470 Exceptions on getting a column value should return the column name not the column number

2016-05-26 Thread Ted Malaska (Code Review)
Ted Malaska has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/3231

Change subject: KUDU-1470 Exceptions on getting a column value should return 
the column name not the column number
..

KUDU-1470 Exceptions on getting a column value should return the column name 
not the column number

Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
---
M java/kudu-client/src/main/java/org/kududb/client/RowResult.java
1 file changed, 5 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3231/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3231
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8bb3db1ed7b4e2027814815776f6252b0f749c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Ted Malaska