[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Mike Percy has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 4: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Mike Percy has submitted this change and it was merged. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. KUDU-1492: Show column encodings/compression on table page in master This displays column attributes for the table schema in picture. If the table schema doesn't specify these attributes, AUTO_ENCODING or DEFAULT_COMPRESSION are displayed which means whatever is the current default value attributes in the given release. E.g., release 0.9.1 has values PLAIN_ENCODING for encoding and NO_COMPRESSION for compression. Sample results are posted in JIRA KUDU-1492. Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Reviewed-on: http://gerrit.cloudera.org:8080/3667 Tested-by: Kudu Jenkins Reviewed-by: Mike Percy--- M src/kudu/server/webui_util.cc 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Mike Percy: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh Bhat Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3667/3/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 53: const ColumnStorageAttributes& attrs = col.attributes(); > nit: it seems the indent for these new lines is off one shiftwidth. Consid Too many formatting errors for too little change :):), thanks Alexey. I am still in the process of figuring out a fancy GUI for this project, hence was relying on basic vim editor for this change. I corrected this one too. -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 4: Build Started http://104.196.14.100/job/kudu-gerrit/2587/ -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3667 to look at the new patch set (#4). Change subject: KUDU-1492: Show column encodings/compression on table page in master .. KUDU-1492: Show column encodings/compression on table page in master This displays column attributes for the table schema in picture. If the table schema doesn't specify these attributes, AUTO_ENCODING or DEFAULT_COMPRESSION are displayed which means whatever is the current default value attributes in the given release. E.g., release 0.9.1 has values PLAIN_ENCODING for encoding and NO_COMPRESSION for compression. Sample results are posted in JIRA KUDU-1492. Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 --- M src/kudu/server/webui_util.cc 1 file changed, 8 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/3667/4 -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Alexey Serbin has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/3667/2//COMMIT_MSG Commit Message: Line 9: This displays column atributes for the table schema in picture. typo: atributes --> attributes PS2, Line 9: nit: an extra space Line 13: release. For eg, current release has PLAIN_ENCODING for encoding nit: For eg --> E.g. ? http://gerrit.cloudera.org:8080/#/c/3667/2/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: PS2, Line 40: nit: Is this still a tab? If yes, consider expanding it with spaces to comply with code style. Line 54: string encoding = EncodingType_Name(attrs.encoding); nit: consider replacing with const reference: const string& encoding = ... Line 55: string compression = CompressionType_Name(attrs.compression); Ditto -- consider replacing with const reference. -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Dinesh Bhat has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/3667/1//COMMIT_MSG Commit Message: Line 7: KUDU-1492: Show column encodings/compression on table page in master > This is a good summary of best practices for this: http://chris.beams.io/po yep, that helps. thanks. Line 8: > Usually our commit messages are a little more informative (see other commit thanks, addressed them both. http://gerrit.cloudera.org:8080/#/c/3667/1/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 35:std::stringstream* output) { > This is not part of this change, but just an additional comment. Does it m That's a good point, I will note this for future changes. I would prefer to keep this as-is otherwise this means changing the signatures of callers too at few other places. Line 39: << "EncodingCompression" > How about we use two different columns for each of encoding and compression yep, either way is fine with me. I had clubbed them thinking they both are column attrs. Updated the patch with new output format. PS1, Line 40: > spaces instead of tabs. check out google style guide. Thanks david for catching, yes my editor settings were at default. Line 56: *output << Substitute("$0$1$2$3" > I, as a reader, would appreciate some text example of the output in the com Hmmm, I thought about it, but the output wasn't fitting within 80 columns and spilling over wasn't looking pretty either so chucked that idea. -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Dinesh Bhat Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Hello Mike Percy, Alexey Serbin, Kudu Jenkins, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/3667 to look at the new patch set (#2). Change subject: KUDU-1492: Show column encodings/compression on table page in master .. KUDU-1492: Show column encodings/compression on table page in master This displays column atributes for the table schema in picture. If the table schema doesn't specify these attributes, AUTO_ENCODING or DEFAULT_COMPRESSION are displayed which means whatever is the current default value attributes in the given release. For eg, current release has PLAIN_ENCODING for encoding and NO_COMPRESSION for compression. Sample results are posted in JIRA KUDU-1492. Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 --- M src/kudu/server/webui_util.cc 1 file changed, 14 insertions(+), 7 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/3667/2 -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master .. Patch Set 2: Build Started http://104.196.14.100/job/kudu-gerrit/2543/ -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492
Alexey Serbin has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 .. Patch Set 1: Code-Review+1 (2 comments) LGTM, just a couple questions. http://gerrit.cloudera.org:8080/#/c/3667/1/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 35:std::stringstream* output) { This is not part of this change, but just an additional comment. Does it make sense to change type of output into more narrower type ostringstream since the method is supposed only to output some data in there? Line 56: *output << Substitute("$0$1$2$3" I, as a reader, would appreciate some text example of the output in the comment. Would it make sense? -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Alexey Serbin Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492
Mike Percy has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 .. Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/3667/1//COMMIT_MSG Commit Message: Line 7: KUDU-1492: Show column encodings/compression on table page in master > leave a blank line between the commit title and the description. This is a good summary of best practices for this: http://chris.beams.io/posts/git-commit/#seven-rules http://gerrit.cloudera.org:8080/#/c/3667/1/src/kudu/server/webui_util.cc File src/kudu/server/webui_util.cc: Line 39: << "Encoding/Compression" How about we use two different columns for each of encoding and compression? -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: Yes
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492
Kudu Jenkins has posted comments on this change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2520/ -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy Gerrit-HasComments: No
[kudu-CR] KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492
Hello Jean-Daniel Cryans, Mike Percy, Adar Dembo, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3667 to review the following change. Change subject: KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 .. KUDU-1492: Show column encodings/compression on table page in master Test results are in JIRA: https://issues.apache.org/jira/browse/KUDU-1492 Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 --- M src/kudu/server/webui_util.cc 1 file changed, 8 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/3667/1 -- To view, visit http://gerrit.cloudera.org:8080/3667 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I990a8d790ab71a05be04f0b7468b5da0894478e8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dinesh BhatGerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Mike Percy