[kudu-CR] WIP [java client] Integrate with the replay cache
Jean-Daniel Cryans has posted comments on this change. Change subject: WIP [java client] Integrate with the replay cache .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java: PS1, Line 28: SortedSet > can be a priority queue (min heap) I'll use the PriorityBlockingQueue. -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
[kudu-CR] WIP [java client] Integrate with the replay cache
Jean-Daniel Cryans has posted comments on this change.
Change subject: WIP [java client] Integrate with the replay cache
..
Patch Set 1:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java:
PS1, Line 800: setCallSeqId
> unrelated?
Not at all, we now have 2 things called sequence ids: for RPCs and for
Scanners. This is a place where I had to really specify which sequence id I was
using.
Related to that, I was thinking that we should not have two sequence ids in the
code base. We could call one rpcSequenceId and the other scanSequenceId.
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java
File java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java:
PS1, Line 107: UNSET_SEQUENCE_ID
> would be good to mimick the c++ client (NO_SEQ_NO iirc)
Oh I didn't even look at the c++ client :P I'll change it.
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java
File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java:
PS1, Line 40: firstIncompleteRpc
> mimick the c++ API (same method names)
Done
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java:
Line 253: requestIdBuilder.setAttemptNo(rpc.attempt);
> these are guaranteed to be unique, right?
Per RPC you mean? Yes, else there's a bug.
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java
File java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java:
Line 22: public class TestRequestTracker {
> would be easier to mimick the c++ test exactly, that way we know the impls
Makes sense.
--
To view, visit http://gerrit.cloudera.org:8080/3631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Jean-Daniel Cryans
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] WIP [java client] Integrate with the replay cache
Jean-Daniel Cryans has uploaded a new change for review. http://gerrit.cloudera.org:8080/3631 Change subject: WIP [java client] Integrate with the replay cache .. WIP [java client] Integrate with the replay cache Putting this up for review for David. Still missing cleanup and hardening. Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 --- M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduClient.java M java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java M java/kudu-client/src/main/java/org/kududb/client/Batch.java M java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java M java/kudu-client/src/main/java/org/kududb/client/Operation.java A java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java M java/kudu-client/src/main/java/org/kududb/client/TabletClient.java M java/kudu-client/src/test/java/org/kududb/client/ITClient.java M java/kudu-client/src/test/java/org/kududb/client/MiniKuduCluster.java A java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java 10 files changed, 163 insertions(+), 2 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/3631/1 -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans
[kudu-CR] WIP [java client] Integrate with the replay cache
David Ribeiro Alves has posted comments on this change.
Change subject: WIP [java client] Integrate with the replay cache
..
Patch Set 1:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java
File java/kudu-client/src/main/java/org/kududb/client/AsyncKuduScanner.java:
PS1, Line 800: setCallSeqId
unrelated?
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java
File java/kudu-client/src/main/java/org/kududb/client/KuduRpc.java:
PS1, Line 107: UNSET_SEQUENCE_ID
would be good to mimick the c++ client (NO_SEQ_NO iirc)
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java
File java/kudu-client/src/main/java/org/kududb/client/RequestTracker.java:
PS1, Line 28: SortedSet
can be a priority queue (min heap)
PS1, Line 40: firstIncompleteRpc
mimick the c++ API (same method names)
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/main/java/org/kududb/client/TabletClient.java
File java/kudu-client/src/main/java/org/kududb/client/TabletClient.java:
Line 253: requestIdBuilder.setAttemptNo(rpc.attempt);
these are guaranteed to be unique, right?
http://gerrit.cloudera.org:8080/#/c/3631/1/java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java
File java/kudu-client/src/test/java/org/kududb/client/TestRequestTracker.java:
Line 22: public class TestRequestTracker {
would be easier to mimick the c++ test exactly, that way we know the impls will
stay compatible, if we add stuff to either side
--
To view, visit http://gerrit.cloudera.org:8080/3631
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans
Gerrit-Reviewer: David Ribeiro Alves
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes
[kudu-CR] WIP [java client] Integrate with the replay cache
Kudu Jenkins has posted comments on this change. Change subject: WIP [java client] Integrate with the replay cache .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2385/ -- To view, visit http://gerrit.cloudera.org:8080/3631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I108cd30acbc308bfb4577d072c2a8f26d1553c68 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Jean-Daniel Cryans Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
