[kudu-CR] build: squelch symbol visibility warnings seen with cmake 3.5
Adar Dembo has submitted this change and it was merged. Change subject: build: squelch symbol visibility warnings seen with cmake 3.5 .. build: squelch symbol visibility warnings seen with cmake 3.5 When building with cmake 3.5, these ugly warnings are emitted: CMake Deprecation Warning at /usr/share/cmake-3.5/Modules/GenerateExportHeader.cmake:383 (message): The add_compiler_export_flags function is obsolete. Use the CXX_VISIBILITY_PRESET and VISIBILITY_INLINES_HIDDEN target properties instead. Call Stack (most recent call first): CMakeLists.txt:528 (add_compiler_export_flags) src/kudu/client/CMakeLists.txt:78 (ADD_EXPORTABLE_LIBRARY) This patch replaces add_compiler_export_flags() with modifications to those new target variables. Unfortunately, it doesn't work in cmake 3.2, so we need to keep both approaches for the time being. Change-Id: I10711b0a314d74fc24748801947ae7ebcc6748b4 Reviewed-on: http://gerrit.cloudera.org:8080/3405 Reviewed-by: Dan Burkert Tested-by: Kudu Jenkins --- M CMakeLists.txt 1 file changed, 18 insertions(+), 0 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I10711b0a314d74fc24748801947ae7ebcc6748b4 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] build: squelch symbol visibility warnings seen with cmake 3.5
Dan Burkert has posted comments on this change. Change subject: build: squelch symbol visibility warnings seen with cmake 3.5 .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10711b0a314d74fc24748801947ae7ebcc6748b4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
[kudu-CR] build: squelch symbol visibility warnings seen with cmake 3.5
Hello Dan Burkert, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3405 to review the following change. Change subject: build: squelch symbol visibility warnings seen with cmake 3.5 .. build: squelch symbol visibility warnings seen with cmake 3.5 When building with cmake 3.5, these ugly warnings are emitted: CMake Deprecation Warning at /usr/share/cmake-3.5/Modules/GenerateExportHeader.cmake:383 (message): The add_compiler_export_flags function is obsolete. Use the CXX_VISIBILITY_PRESET and VISIBILITY_INLINES_HIDDEN target properties instead. Call Stack (most recent call first): CMakeLists.txt:528 (add_compiler_export_flags) src/kudu/client/CMakeLists.txt:78 (ADD_EXPORTABLE_LIBRARY) This patch replaces add_compiler_export_flags() with modifications to those new target variables. Unfortunately, it doesn't work in cmake 3.2, so we need to keep both approaches for the time being. Change-Id: I10711b0a314d74fc24748801947ae7ebcc6748b4 --- M CMakeLists.txt 1 file changed, 18 insertions(+), 0 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/3405/1 -- To view, visit http://gerrit.cloudera.org:8080/3405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I10711b0a314d74fc24748801947ae7ebcc6748b4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert
[kudu-CR] build: squelch symbol visibility warnings seen with cmake 3.5
Kudu Jenkins has posted comments on this change. Change subject: build: squelch symbol visibility warnings seen with cmake 3.5 .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/1866/ -- To view, visit http://gerrit.cloudera.org:8080/3405 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I10711b0a314d74fc24748801947ae7ebcc6748b4 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: No
