[kudu-CR] catalog manager: fix a locking brain fart

2016-06-21 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change.

Change subject: catalog_manager: fix a locking brain fart
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3425/1//COMMIT_MSG
Commit Message:

Line 7: catalog_manager: fix a locking brain fart
> s/brain fart/error
Really? :)

Fine.


-- 
To view, visit http://gerrit.cloudera.org:8080/3425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes


[kudu-CR] catalog manager: fix a locking brain fart

2016-06-21 Thread Adar Dembo (Code Review)
Hello David Ribeiro Alves, Mike Percy,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3425

to review the following change.

Change subject: catalog_manager: fix a locking brain fart
..

catalog_manager: fix a locking brain fart

This lock acquisition took the wrong lock, which meant it didn't add any
protection against table/tablet visition races at all.

See commit 1681d9a for context.

Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
---
M src/kudu/master/catalog_manager.cc
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/25/3425/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3425
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8db7a78309bb9182ae1fdb92485e8467b90a84b2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Mike Percy