[kudu-CR] ksck: improve output for long-running ksck checksums

2016-07-20 Thread Jean-Daniel Cryans (Code Review)
Jean-Daniel Cryans has posted comments on this change.

Change subject: ksck: improve output for long-running ksck checksums
..


Patch Set 1: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3715/1//COMMIT_MSG
Commit Message:

PS1, Line 11:  
nit


-- 
To view, visit http://gerrit.cloudera.org:8080/3715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes


[kudu-CR] ksck: improve output for long-running ksck checksums

2016-07-20 Thread Kudu Jenkins (Code Review)
Kudu Jenkins has posted comments on this change.

Change subject: ksck: improve output for long-running ksck checksums
..


Patch Set 1:

Build Started http://104.196.14.100/job/kudu-gerrit/2589/

-- 
To view, visit http://gerrit.cloudera.org:8080/3715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No


[kudu-CR] ksck: improve output for long-running ksck checksums

2016-07-20 Thread Todd Lipcon (Code Review)
Hello Jean-Daniel Cryans, Mike Percy,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3715

to review the following change.

Change subject: ksck: improve output for long-running ksck checksums
..

ksck: improve output for long-running ksck checksums

Checksumming a large (multi-TB) table can take many minutes. Previously, the
ksck output would be very quiet during that time, giving no indication as to
whether it was making progress or how much work might be remaining.  This
addresses that by:

- passing back how many bytes and number of rows have been summed so
  far on a regular basis
- reporting progress every 5 seconds, including the above numbers

Along the way, I decided that our default timeout of 5 minutes was way too low
for typical table sizes, so bumped it to an hour. I also added more mock-based
test coverage of the checksum-scan code path.

Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825
---
M src/kudu/tools/ksck-test.cc
M src/kudu/tools/ksck.cc
M src/kudu/tools/ksck.h
M src/kudu/tools/ksck_remote-test.cc
M src/kudu/tools/ksck_remote.cc
M src/kudu/tools/ksck_remote.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tablet_service.cc
M src/kudu/tserver/tserver_service.proto
9 files changed, 179 insertions(+), 61 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/15/3715/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3715
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a9962329570e8383087747d36cee9ad4fa60825
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Mike Percy