[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-28 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..


Patch Set 5: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Adar Dembo (Code Review) 
Adar Dembo has posted comments on this change.

Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..


Patch Set 5: Verified+1

Overriding Jenkins, flaky ksck timeout test.

-- 
To view, visit http://gerrit.cloudera.org:8080/3499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..


Patch Set 5:

Build Started http://104.196.14.100/job/kudu-gerrit/2069/

-- 
To view, visit http://gerrit.cloudera.org:8080/3499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
Gerrit-PatchSet: 5
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Kudu Jenkins (Code Review) 
Kudu Jenkins has posted comments on this change.

Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..


Patch Set 4:

Build Started http://104.196.14.100/job/kudu-gerrit/2064/

-- 
To view, visit http://gerrit.cloudera.org:8080/3499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-27 Thread Dan Burkert (Code Review) 
Dan Burkert has posted comments on this change.

Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/3499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] locks: switch from boost::shared mutex to new read-write mutex

2016-06-25 Thread Adar Dembo (Code Review) 
Hello Dan Burkert, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/3499

to review the following change.

Change subject: locks: switch from boost::shared_mutex to new read-write mutex
..

locks: switch from boost::shared_mutex to new read-write mutex

Here are the changed mutexes:
1. log allocation state lock. Only taken before and after segment
   preallocation, which doesn't seem like a hot path.
2. webserver lock: Protects the handler map and footer. Almost always
   uncontended, and the web UI is not a hot path anyway.
3. tablet status listener lock: Protects the last status seen. Almost always
   uncontended; it's acquired often by the remote bootstrap client, but the
   only other acquirer would be the web UI or ListTablets() RPC.
4. scanner manager stripe lock: Protects a particular stripe's scanner map.
   This one is a hot path with contention, I think.

Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
---
M src/kudu/consensus/log.cc
M src/kudu/consensus/log.h
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_bootstrap.h
M src/kudu/tserver/scanners.cc
M src/kudu/tserver/scanners.h
8 files changed, 24 insertions(+), 27 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/99/3499/1
-- 
To view, visit http://gerrit.cloudera.org:8080/3499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1b4b1df267468dc8c88c3de8e0345c61900576de
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Todd Lipcon