[kudu-CR] master-test: rewrite to use std::thread instead of kudu::Thread
Adar Dembo has submitted this change and it was merged. Change subject: master-test: rewrite to use std::thread instead of kudu::Thread .. master-test: rewrite to use std::thread instead of kudu::Thread It's more terse than kudu::Thread and is easier to use with lambdas. There are no functional changes here. Change-Id: Ibd1880b4a47cb741742ec00ecfd10ab2e5c223e3 Reviewed-on: http://gerrit.cloudera.org:8080/3602 Tested-by: Kudu Jenkins Reviewed-by: Dan Burkert --- M src/kudu/master/master-test.cc 1 file changed, 86 insertions(+), 108 deletions(-) Approvals: Dan Burkert: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/3602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd1880b4a47cb741742ec00ecfd10ab2e5c223e3 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon
[kudu-CR] master-test: rewrite to use std::thread instead of kudu::Thread
Dan Burkert has posted comments on this change. Change subject: master-test: rewrite to use std::thread instead of kudu::Thread .. Patch Set 1: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/3602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1880b4a47cb741742ec00ecfd10ab2e5c223e3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master-test: rewrite to use std::thread instead of kudu::Thread
Kudu Jenkins has posted comments on this change. Change subject: master-test: rewrite to use std::thread instead of kudu::Thread .. Patch Set 1: Build Started http://104.196.14.100/job/kudu-gerrit/2263/ -- To view, visit http://gerrit.cloudera.org:8080/3602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibd1880b4a47cb741742ec00ecfd10ab2e5c223e3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon Gerrit-HasComments: No
[kudu-CR] master-test: rewrite to use std::thread instead of kudu::Thread
Hello Dan Burkert, David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/3602 to review the following change. Change subject: master-test: rewrite to use std::thread instead of kudu::Thread .. master-test: rewrite to use std::thread instead of kudu::Thread It's more terse than kudu::Thread and is easier to use with lambdas. There are no functional changes here. Change-Id: Ibd1880b4a47cb741742ec00ecfd10ab2e5c223e3 --- M src/kudu/master/master-test.cc 1 file changed, 86 insertions(+), 108 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/02/3602/1 -- To view, visit http://gerrit.cloudera.org:8080/3602 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ibd1880b4a47cb741742ec00ecfd10ab2e5c223e3 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo Gerrit-Reviewer: Dan Burkert Gerrit-Reviewer: David Ribeiro Alves Gerrit-Reviewer: Todd Lipcon