[GitHub] [incubator-livy] yantzu commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-04 Thread GitBox
yantzu commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer URL: https://github.com/apache/incubator-livy/pull/195#discussion_r320583932 ## File path: thriftserver/server/pom.xml ## @@

[GitHub] [incubator-livy] jerryshao commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
jerryshao commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527762054 CC @yiheng @runzhiwang please help to review.

[GitHub] [incubator-livy] runzhiwang edited a comment on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
runzhiwang edited a comment on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527766053 It's easy to find the NullPointerException was caused by canceling job whether catch or

[GitHub] [incubator-livy] runzhiwang commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
runzhiwang commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527766053 It's easy to find the exception was caused by canceling job whether catch or not ?

[GitHub] [incubator-livy] yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527774511 Without catch cancel exception, the original exception("scala.refrect.internal.FactalError: object

[GitHub] [incubator-livy] jerryshao commented on issue #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished

2019-09-04 Thread GitBox
jerryshao commented on issue #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished URL: https://github.com/apache/incubator-livy/pull/222#issuecomment-527786726 Run the test again.

[GitHub] [incubator-livy] runzhiwang opened a new pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished

2019-09-04 Thread GitBox
runzhiwang opened a new pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished URL: https://github.com/apache/incubator-livy/pull/222 ## What changes were proposed in this pull request? Fix travis failed on "batch session

[GitHub] [incubator-livy] jerryshao closed pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished

2019-09-04 Thread GitBox
jerryshao closed pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished URL: https://github.com/apache/incubator-livy/pull/222 This is an automated message from the

[GitHub] [incubator-livy] runzhiwang edited a comment on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
runzhiwang edited a comment on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527766053 Is it easy to find the NullPointerException was caused by canceling job whether catch or

[GitHub] [incubator-livy] runzhiwang edited a comment on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
runzhiwang edited a comment on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-52282 @yantzu Is the original exception helpful to find the reason is fail to startup ?

[GitHub] [incubator-livy] runzhiwang commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
runzhiwang commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-52282 @yantzu Is the original exception helpful to find the reason is fail to startup.

[GitHub] [incubator-livy] fdeantoni commented on issue #188: LIVY-615: Set context path using property SERVER_BASE_PATH.

2019-09-04 Thread GitBox
fdeantoni commented on issue #188: LIVY-615: Set context path using property SERVER_BASE_PATH. URL: https://github.com/apache/incubator-livy/pull/188#issuecomment-527779827 Hi all, any chance this will be merged into master? We are currently using the forked branch but would prefer to use

[GitHub] [incubator-livy] jerryshao closed pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished

2019-09-04 Thread GitBox
jerryshao closed pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished URL: https://github.com/apache/incubator-livy/pull/222 This is an automated message from the

[GitHub] [incubator-livy] runzhiwang opened a new pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished

2019-09-04 Thread GitBox
runzhiwang opened a new pull request #222: [LIVY-647]Fix travis failed on batch session should not be gc-ed until application is finished URL: https://github.com/apache/incubator-livy/pull/222 ## What changes were proposed in this pull request? Fix travis failed on "batch session

[GitHub] [incubator-livy] yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527770727 Sorry @runzhiwang , I cannot catch your point, could you please explain more?

[GitHub] [incubator-livy] yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-04 Thread GitBox
yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 ## What changes were proposed in this pull request? Currently, Livy records the last activity time of the session before

[GitHub] [incubator-livy] runzhiwang commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
runzhiwang commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527771884 @yantzu If do not catch the exception, it's also easy to find cancel job will cause exception.

[GitHub] [incubator-livy] yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527783259 original exception is the cause of application failure. @runzhiwang

[GitHub] [incubator-livy] yantzu commented on a change in pull request #207: [LIVY-645]Add Session Name, Owner, Proxy User information to Web UI

2019-09-04 Thread GitBox
yantzu commented on a change in pull request #207: [LIVY-645]Add Session Name, Owner, Proxy User information to Web UI URL: https://github.com/apache/incubator-livy/pull/207#discussion_r320620874 ## File path:

[GitHub] [incubator-livy] jerryshao commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-04 Thread GitBox
jerryshao commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r320614092 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: If there's no

[GitHub] [incubator-livy] captainzmc commented on issue #209: [LIVY-640] Add tests for ThriftServer

2019-09-04 Thread GitBox
captainzmc commented on issue #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#issuecomment-527895051 fix This is an automated message from the Apache Git Service. To respond

[GitHub] [incubator-livy] shanyu commented on issue #212: [LIVY-11] Enable HA support

2019-09-04 Thread GitBox
shanyu commented on issue #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#issuecomment-528010862 > > Another question is if the current leader crash and a new leader is elected, should the session state in the old leader be restored in the new

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer

2019-09-04 Thread GitBox
captainzmc commented on a change in pull request #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#discussion_r320725961 ## File path: pom.xml ## @@ -1009,6 +1007,20 @@ + Review comment: Now we really

[GitHub] [incubator-livy] runzhiwang opened a new pull request #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names

2019-09-04 Thread GitBox
runzhiwang opened a new pull request #225: [LIVY-657]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225 ## What changes were proposed in this pull request? Fix travis failed on "should not create

[GitHub] [incubator-livy] shanyu commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-04 Thread GitBox
shanyu commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r320942152 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,123 @@ +/* + *

[GitHub] [incubator-livy] shanyu commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-04 Thread GitBox
shanyu commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r320942675 ## File path: server/src/main/scala/org/apache/livy/server/recovery/ZooKeeperStateStore.scala ## @@ -46,7 +46,7 @@

[GitHub] [incubator-livy] jerryshao commented on issue #209: [LIVY-640] Add tests for ThriftServer

2019-09-04 Thread GitBox
jerryshao commented on issue #209: [LIVY-640] Add tests for ThriftServer URL: https://github.com/apache/incubator-livy/pull/209#issuecomment-528187011 +1, LGTM. @mgaido91 would you please help to take another review. This is

[GitHub] [incubator-livy] tsurushun commented on issue #119: [LIVY-527] added autocompletion api and implementation for ipython

2019-09-04 Thread GitBox
tsurushun commented on issue #119: [LIVY-527] added autocompletion api and implementation for ipython URL: https://github.com/apache/incubator-livy/pull/119#issuecomment-528188936 Hi @wangqiaoshi, you would be doing a great favor for a lot of people if you could merge this. Thanks!

[GitHub] [incubator-livy] runzhiwang opened a new pull request #226: [LIVY-659]Fix travis failed on can kill spark-submit while it's running

2019-09-04 Thread GitBox
runzhiwang opened a new pull request #226: [LIVY-659]Fix travis failed on can kill spark-submit while it's running URL: https://github.com/apache/incubator-livy/pull/226 ## What changes were proposed in this pull request? Fix travis failed on "can kill spark-submit while it's

[GitHub] [incubator-livy] yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-04 Thread GitBox
yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 ## What changes were proposed in this pull request? Currently, Livy records the last activity time of the session before

[GitHub] [incubator-livy] yiheng closed pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-04 Thread GitBox
yiheng closed pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-livy] yiheng commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown

2019-09-04 Thread GitBox
yiheng commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-528184404 can we fix the annoying `NullPointerException`?

[GitHub] [incubator-livy] yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-04 Thread GitBox
yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 ## What changes were proposed in this pull request? Currently, Livy records the last activity time of the session before

[GitHub] [incubator-livy] yiheng closed pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-04 Thread GitBox
yiheng closed pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-livy] mnoji commented on issue #119: [LIVY-527] added autocompletion api and implementation for ipython

2019-09-04 Thread GitBox
mnoji commented on issue #119: [LIVY-527] added autocompletion api and implementation for ipython URL: https://github.com/apache/incubator-livy/pull/119#issuecomment-528190269 Hello @wangqiaoshi , Please merge your great job!!