[GitHub] [incubator-livy] jerryshao commented on issue #208: [LIVY-643][Server] Support for a Livy Server running on Windows Operating System

2019-09-17 Thread GitBox
jerryshao commented on issue #208: [LIVY-643][Server] Support for a Livy Server running on Windows Operating System URL: https://github.com/apache/incubator-livy/pull/208#issuecomment-532098684 @davidOSUL sorry for late response, can you please tell what are the left issues for Livy

[GitHub] [incubator-livy] codecov-io commented on issue #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json

2019-09-17 Thread GitBox
codecov-io commented on issue #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json URL: https://github.com/apache/incubator-livy/pull/234#issuecomment-532103511 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/234?src=pr=h1) Report >

[GitHub] [incubator-livy] captainzmc commented on issue #231: Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
captainzmc commented on issue #231: Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#issuecomment-532103646 Hi @jerryshao This PR is based on the previous #20 , could you please help to review it.

[GitHub] [incubator-livy] yiheng commented on a change in pull request #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json

2019-09-17 Thread GitBox
yiheng commented on a change in pull request #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json URL: https://github.com/apache/incubator-livy/pull/234#discussion_r325049178 ## File path:

[GitHub] [incubator-livy] captainzmc closed pull request #231: Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
captainzmc closed pull request #231: Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [incubator-livy] captainzmc opened a new pull request #231: Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
captainzmc opened a new pull request #231: Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231 ## What changes were proposed in this pull request? Currently, livy-server doesn't support LDAP Authentication from client to server(livy). We need

[GitHub] [incubator-livy] jerryshao closed pull request #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names

2019-09-17 Thread GitBox
jerryshao closed pull request #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225 This is an automated message from the Apache

[GitHub] [incubator-livy] runzhiwang opened a new pull request #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names

2019-09-17 Thread GitBox
runzhiwang opened a new pull request #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225 ## What changes were proposed in this pull request? Fix travis failed on "should not create

[GitHub] [incubator-livy] yiheng opened a new pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project li

2019-09-17 Thread GitBox
yiheng opened a new pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229 ## What changes were proposed in this

[GitHub] [incubator-livy] jerryshao closed pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-

2019-09-17 Thread GitBox
jerryshao closed pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229

[GitHub] [incubator-livy] codecov-io edited a comment on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on projec

2019-09-17 Thread GitBox
codecov-io edited a comment on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229#issuecomment-530197154 #

[GitHub] [incubator-livy] codecov-io edited a comment on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on projec

2019-09-17 Thread GitBox
codecov-io edited a comment on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229#issuecomment-530197154 #

[GitHub] [incubator-livy] Jassy1994 opened a new pull request #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json

2019-09-17 Thread GitBox
Jassy1994 opened a new pull request #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json URL: https://github.com/apache/incubator-livy/pull/234 ## What changes were proposed in this pull request? The issue link:

[GitHub] [incubator-livy] jerryshao commented on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-c

2019-09-17 Thread GitBox
jerryshao commented on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229#issuecomment-532092339 Try to run several

[GitHub] [incubator-livy] yiheng opened a new pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project li

2019-09-17 Thread GitBox
yiheng opened a new pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229 ## What changes were proposed in this

[GitHub] [incubator-livy] jerryshao closed pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-

2019-09-17 Thread GitBox
jerryshao closed pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229

[GitHub] [incubator-livy] codecov-io edited a comment on issue #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names

2019-09-17 Thread GitBox
codecov-io edited a comment on issue #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225#issuecomment-528246905 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/225?src=pr=h1) Report

[GitHub] [incubator-livy] codecov-io edited a comment on issue #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names

2019-09-17 Thread GitBox
codecov-io edited a comment on issue #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225#issuecomment-528246905 # [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/225?src=pr=h1) Report

[GitHub] [incubator-livy] yiheng commented on a change in pull request #230: [WIP][LIVY-664][Server] Spark application still running when Livy session creating was rejected

2019-09-17 Thread GitBox
yiheng commented on a change in pull request #230: [WIP][LIVY-664][Server] Spark application still running when Livy session creating was rejected URL: https://github.com/apache/incubator-livy/pull/230#discussion_r325087100 ## File path:

[GitHub] [incubator-livy] yiheng commented on a change in pull request #230: [WIP][LIVY-664][Server] Spark application still running when Livy session creating was rejected

2019-09-17 Thread GitBox
yiheng commented on a change in pull request #230: [WIP][LIVY-664][Server] Spark application still running when Livy session creating was rejected URL: https://github.com/apache/incubator-livy/pull/230#discussion_r325087158 ## File path:

[GitHub] [incubator-livy] jerryshao closed pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries

2019-09-17 Thread GitBox
jerryshao closed pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 This is an automated message from the Apache Git Service. To

[GitHub] [incubator-livy] Jassy1994 commented on a change in pull request #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json

2019-09-17 Thread GitBox
Jassy1994 commented on a change in pull request #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json URL: https://github.com/apache/incubator-livy/pull/234#discussion_r325074450 ## File path:

[GitHub] [incubator-livy] jerryshao commented on issue #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json

2019-09-17 Thread GitBox
jerryshao commented on issue #234: [LIVY-683] Livy SQLInterpreter get empty array when extract date format rows to json URL: https://github.com/apache/incubator-livy/pull/234#issuecomment-532146892 This should have been fixed in #186 , what is difference here?

[GitHub] [incubator-livy] mgaido91 commented on issue #231: Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
mgaido91 commented on issue #231: Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#issuecomment-532193892 @captainzmc please add the JIRA to the PR title This is an automated

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
captainzmc commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325143141 ## File path: server/src/main/scala/org/apache/livy/server/LivyServer.scala ## @@

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325149564 ## File path: server/src/main/scala/org/apache/livy/server/LivyServer.scala ## @@

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
captainzmc commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325149382 ## File path: conf/livy.conf.template ## @@ -160,6 +160,13 @@ #

[GitHub] [incubator-livy] captainzmc commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
captainzmc commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325146353 ## File path: pom.xml ## @@ -121,6 +121,10 @@ false + Review

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
mgaido91 commented on a change in pull request #231: [LIVY-356][SERVER]Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325150420 ## File path: conf/livy.conf.template ## @@ -160,6 +160,13 @@ #

[GitHub] [incubator-livy] mgaido91 commented on issue #183: [LIVY-609] LDAP auth for Livy thriftserver

2019-09-17 Thread GitBox
mgaido91 commented on issue #183: [LIVY-609] LDAP auth for Livy thriftserver URL: https://github.com/apache/incubator-livy/pull/183#issuecomment-532193530 @captainzmc thanks, I'd just enforce that the tasks are complementary and adding a feature doesn't require rework. Apart from that I am

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
mgaido91 commented on a change in pull request #231: Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325132718 ## File path: pom.xml ## @@ -121,6 +121,10 @@ false + Review comment: not only

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
mgaido91 commented on a change in pull request #231: Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325132488 ## File path: conf/livy.conf.template ## @@ -160,6 +160,13 @@ # livy.server.auth.kerberos.keytab =

[GitHub] [incubator-livy] mgaido91 commented on a change in pull request #231: Add LDAP authentication for livy-server.

2019-09-17 Thread GitBox
mgaido91 commented on a change in pull request #231: Add LDAP authentication for livy-server. URL: https://github.com/apache/incubator-livy/pull/231#discussion_r325133826 ## File path: server/src/main/scala/org/apache/livy/server/LivyServer.scala ## @@ -260,6 +261,26 @@

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325412516 ## File path: conf/livy.conf.template ## @@ -100,6 +100,16 @@ # on user request and then livy server classpath

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415651 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,122 @@ +/*

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415549 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,122 @@ +/*

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415827 ## File path: server/src/main/scala/org/apache/livy/server/LivyServer.scala ## @@ -394,16 +395,29 @@ class

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415571 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,122 @@ +/*

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415620 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,122 @@ +/*

[GitHub] [incubator-livy] jerryshao closed pull request #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names

2019-09-17 Thread GitBox
jerryshao closed pull request #225: [LIVY-657][TEST]Fix travis failed on should not create sessions with duplicate names URL: https://github.com/apache/incubator-livy/pull/225 This is an automated message from the Apache

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415370 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,122 @@ +/*

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415504 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,122 @@ +/*

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415457 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,122 @@ +/*

[GitHub] [incubator-livy] ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support

2019-09-17 Thread GitBox
ajbozarth commented on a change in pull request #212: [LIVY-11] Enable HA support URL: https://github.com/apache/incubator-livy/pull/212#discussion_r325415712 ## File path: server/src/main/scala/org/apache/livy/server/CuratorElectorService.scala ## @@ -0,0 +1,122 @@ +/*

[GitHub] [incubator-livy] codecov-io edited a comment on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on projec

2019-09-17 Thread GitBox
codecov-io edited a comment on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229#issuecomment-530197154 #

[GitHub] [incubator-livy] codecov-io edited a comment on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on projec

2019-09-17 Thread GitBox
codecov-io edited a comment on issue #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229#issuecomment-530197154 #

[GitHub] [incubator-livy] jerryshao closed pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-

2019-09-17 Thread GitBox
jerryshao closed pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229

[GitHub] [incubator-livy] yiheng opened a new pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project li

2019-09-17 Thread GitBox
yiheng opened a new pull request #229: [LIVY-644][TEST] Flaky test: Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.2:report-aggregate (jacoco-report) on project livy-coverage-report URL: https://github.com/apache/incubator-livy/pull/229 ## What changes were proposed in this

[GitHub] [incubator-livy] jerryshao commented on issue #228: [LIVY-663][API] exposing job id and session id in livy client

2019-09-17 Thread GitBox
jerryshao commented on issue #228: [LIVY-663][API] exposing job id and session id in livy client URL: https://github.com/apache/incubator-livy/pull/228#issuecomment-532498159 I think such APIs should also be added in Scala and Python Client. Also would you please add some unit tests,