[GitHub] [incubator-livy] captainzmc commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-10 Thread GitBox
captainzmc commented on a change in pull request #195: [LIVY-634] To support 
reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#discussion_r322681137
 
 

 ##
 File path: thriftserver/server/pom.xml
 ##
 @@ -56,6 +56,25 @@
 
   
 
+
+  org.apache.hive
+  hive-common
 
 Review comment:
   @yantzu I'm sorry if I didn't describe it clearly, it's not a separate 
package. Here it is: 
https://github.com/apache/hive/tree/master/service/src/java/org/apache/hive/service/auth/ldap


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-livy] captainzmc commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-10 Thread GitBox
captainzmc commented on a change in pull request #195: [LIVY-634] To support 
reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#discussion_r322577926
 
 

 ##
 File path: thriftserver/server/pom.xml
 ##
 @@ -56,6 +56,25 @@
 
   
 
+
+  org.apache.hive
+  hive-common
 
 Review comment:
   Hi @mgaido91 @yantzu , I see  there is a separate ldap package under the 
auth in hive. If we support LDAP,  do we need to manually implement all the 
implementations under this package? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-livy] captainzmc commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-10 Thread GitBox
captainzmc commented on a change in pull request #195: [LIVY-634] To support 
reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#discussion_r322577926
 
 

 ##
 File path: thriftserver/server/pom.xml
 ##
 @@ -56,6 +56,25 @@
 
   
 
+
+  org.apache.hive
+  hive-common
 
 Review comment:
   Hi @mgaido91 , I see  there is a separate ldap package under the auth in 
hive. If we support LDAP,  do we need to manually implement all the 
implementations under this package? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-livy] captainzmc commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-10 Thread GitBox
captainzmc commented on a change in pull request #195: [LIVY-634] To support 
reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#discussion_r322577926
 
 

 ##
 File path: thriftserver/server/pom.xml
 ##
 @@ -56,6 +56,25 @@
 
   
 
+
+  org.apache.hive
+  hive-common
 
 Review comment:
   I see  there is a separate ldap package under the auth in hive. If we 
support LDAP,  do we need to manually implement all the implementations under 
this package? 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] [incubator-livy] captainzmc commented on a change in pull request #195: [LIVY-634] To support reuse hive PasswdAuthenticationProvider implementation in ThriftServer

2019-09-03 Thread GitBox
captainzmc commented on a change in pull request #195: [LIVY-634] To support 
reuse hive PasswdAuthenticationProvider implementation in ThriftServer
URL: https://github.com/apache/incubator-livy/pull/195#discussion_r320266942
 
 

 ##
 File path: thriftserver/server/pom.xml
 ##
 @@ -56,6 +56,21 @@
 
   
 
+
+  org.apache.hive
+  hive-common
+  ${hive.version}
+  
 
 Review comment:
   This will lead to the following jars in thriftserver, which will cause 
livy's logs to fail to display. We need to exclusion them.
   log4j-1.2-api-2.10.0.jar
   log4j-api-2.10.0.jar
   log4j-core-2.10.0.jar
   log4j-slf4j-impl-2.10.0.jar
   log4j-web-2.10.0.jar


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services