[GitHub] [incubator-livy] yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown
yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-528250103 The unit test I add demonstrate how NullPointerException happens: a request send to RSCDriver while it is initializing, after initialization failed, RSCDriver try to cancel job. In real case, it is beeline send a "use default" SQL to thrift server then RSCDriver. I think it is possible to avoid NPE in this case, but not sure if it is what we should do, because: 1, there may be other reason cause cancel job failure, to fix all those would be diffcult 2, catch and log exception when cancel job give RSCDriver a chance to cancel other job and shutdown context correctly 3, RSCDriver already catch shutdownContext() and shutdownServer() call This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown
yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527783259 original exception is the cause of application failure. @runzhiwang This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown
yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if
cancel job failed during shutdown
URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527774511
Without catch cancel exception, the original
exception("scala.refrect.internal.FactalError: object Predef does not have a
member classOf" in the screen-shoot) is concealed by NullPointerException, it
is not easy to find application error root cause(which is FactalError in this
case). @runzhiwang
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-livy] yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown
yantzu commented on issue #223: [LIVY-658]RSCDriver should catch exception if cancel job failed during shutdown URL: https://github.com/apache/incubator-livy/pull/223#issuecomment-527770727 Sorry @runzhiwang , I cannot catch your point, could you please explain more? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
