[GitHub] [incubator-livy] yiheng commented on issue #238: [LIVY-689] Deliver stage process message to the end user using thriftserver

2019-10-09 Thread GitBox 
yiheng commented on issue #238: [LIVY-689] Deliver stage process message to the 
end user using thriftserver
URL: https://github.com/apache/incubator-livy/pull/238#issuecomment-540382774
 
 
   > @yiheng Could you please review the new commit again? All checks have 
passed now.
   
   I only have one comment. Others look good to me.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [incubator-livy] yiheng commented on issue #238: [LIVY-689] Deliver stage process message to the end user using thriftserver

2019-09-26 Thread GitBox 
yiheng commented on issue #238: [LIVY-689] Deliver stage process message to the 
end user using thriftserver
URL: https://github.com/apache/incubator-livy/pull/238#issuecomment-535807077
 
 
   > @yiheng Thanks for your review, Could you also help me check why the test 
failed? I did not create another spark context in the patch.
   > I'm gonna fix these problems in the next commit.
   
   I'm not sure why. I guess the create another spark context is not the root 
cause. It should be caused by another reason. Can you reproduce the error in 
your local?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services