[GitHub] [incubator-livy] yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries
yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 ## What changes were proposed in this pull request? Currently, Livy records the last activity time of the session before statement execution. If a statement runs too long, exceeding then the session timeout, the session will be garbage collected after the statement execution. This should not be the expected behavior. The statement execution time should not be count into idle. We should update the last activity time after the statement execution. We cannot be updated when session changes state from busy to idle in the Session class. So in this patch, we add a replLastActivity field into the rscClient, which will be updated when the repl state changes. So when session changes its state from busy to idle, this field will catch the time and finally reflect on the session last activity. ## How was this patch tested? Manual test. Also, add a new unit test. Existing unit tests and integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries
yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 ## What changes were proposed in this pull request? Currently, Livy records the last activity time of the session before statement execution. If a statement runs too long, exceeding then the session timeout, the session will be garbage collected after the statement execution. This should not be the expected behavior. The statement execution time should not be count into idle. We should update the last activity time after the statement execution. We cannot be updated when session changes state from busy to idle in the Session class. So in this patch, we add a replLastActivity field into the rscClient, which will be updated when the repl state changes. So when session changes its state from busy to idle, this field will catch the time and finally reflect on the session last activity. ## How was this patch tested? Manual test. Also, add a new unit test. Existing unit tests and integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries
yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 ## What changes were proposed in this pull request? Currently, Livy records the last activity time of the session before statement execution. If a statement runs too long, exceeding then the session timeout, the session will be garbage collected after the statement execution. This should not be the expected behavior. The statement execution time should not be count into idle. We should update the last activity time after the statement execution. We cannot be updated when session changes state from busy to idle in the Session class. So in this patch, we add a replLastActivity field into the rscClient, which will be updated when the repl state changes. So when session changes its state from busy to idle, this field will catch the time and finally reflect on the session last activity. ## How was this patch tested? Manual test. Also, add a new unit test. Existing unit tests and integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [incubator-livy] yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries
yiheng opened a new pull request #224: [LIVY-633][Server] session should not be gc-ed for long running queries URL: https://github.com/apache/incubator-livy/pull/224 ## What changes were proposed in this pull request? Currently, Livy records the last activity time of the session before statement execution. If a statement runs too long, exceeding then the session timeout, the session will be garbage collected after the statement execution. This should not be the expected behavior. The statement execution time should not be count into idle. We should update the last activity time after the statement execution. In this patch, we add a replLastActivity field into the rscClient, which will be updated when the repl state changes. So when session changes its state from busy to idle, this field will catch the time and finally reflect on the session last activity. ## How was this patch tested? Manual test. Also, add a new unit test. Existing unit tests and integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
