Re: Review Request 33109: Allow setting environment variables in mesos-execute

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109/ --- (Updated April 25, 2015, 9:11 a.m.) Review request for mesos and Adam B. Bugs

Re: Review Request 33109: Allow setting environment variables in mesos-execute

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33109/#review81588 --- Patch looks great! Reviews applied: [33109] All tests passed. - M

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 10:17 a.m.) Review request for mesos and Jie Yu. Bug

Re: Review Request 29748: Added tests for dynamic reservation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29748/#review81591 --- src/tests/reservation_tests.cpp

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 1:23 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 1:25 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 6:05 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/ --- (Updated April 25, 2015, 6:07 p.m.) Review request for mesos and Jie Yu. Bugs

Re: Review Request 33339: Add a Java example framework to test persistent volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/9/#review81595 --- Patch looks great! Reviews applied: [9] All tests passed. - M

Review Request 33554: Avoid Python declineOffer raise exception when filters is assigned to None explicitly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33554/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-2567 https://issues.

Re: Review Request 33554: Avoid Python declineOffer raise exception when filters is assigned to None explicitly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33554/#review81599 --- Patch looks great! Reviews applied: [33554] All tests passed. - M

Re: Review Request 33465: Removed 'uuid' field from UPDATE call.

> On April 23, 2015, 7:10 p.m., Ben Mahler wrote: > > src/scheduler/scheduler.cpp, lines 646-652 > > > > > > I realize this hack is necessary to accomplish this in 1 version, but > > should we have a TODO here for the

Re: Review Request 33465: Removed 'uuid' field from UPDATE call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33465/ --- (Updated April 25, 2015, 9:32 p.m.) Review request for mesos and Ben Mahler.

Review Request 33558: Add C++11 lambdas to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558/ --- Review request for mesos, Ben Mahler, Joris Van Remoortere, Michael Park, and Vi

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558/#review81605 --- Patch looks great! Reviews applied: [33558] All tests passed. - M

Re: Review Request 32536: Updated variable naming style.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32536/#review81606 --- Ship it! docs/mesos-c++-style-guide.md

Re: Review Request 32536: Updated variable naming style.

> On April 26, 2015, 2:07 a.m., Benjamin Hindman wrote: > > I went ahead and updated the review for you and committed it, thanks Alex! - Benjamin --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558/#review81608 --- docs/mesos-c++-style-guide.md

Re: Review Request 33109: Allow setting environment variables in mesos-execute

> On April 23, 2015, 12:25 a.m., Adam B wrote: > > src/cli/execute.cpp, line 249 > > > > > > Was this namespacing change necessary? > > haosdent huang wrote: > Because when we add "common/parse.hpp" in the headers