Re: Review Request 33527: Updated documentation for ClangFormat.

2015-04-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33527/#review81647 --- Patch looks great! Reviews applied: [33527] All tests passed. -

Re: Review Request 32001: Required a period in trailing comments in the style guide.

2015-04-26 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32001/#review81650 --- Ship it! Ship It! - Till Toenshoff On April 24, 2015, 1:53

Re: Review Request 33263: Extended SlaveTest.ShutdownUnregisteredExecutor test with a reason check.

2015-04-26 Thread Till Toenshoff
On April 23, 2015, 4:28 p.m., Till Toenshoff wrote: Ship It! When testing your patch, I noticed that it fails for me. ``` ../../src/tests/slave_tests.cpp:184: Failure Value of: status.get().reason() Actual: 8 Expected: TaskStatus::REASON_COMMAND_EXECUTOR_FAILED Which is: 0 ``` - Till

Re: Review Request 33558: Add C++11 lambdas to the C++ style guide.

2015-04-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33558/#review81643 --- docs/mesos-c++-style-guide.md

Re: Review Request 33527: Updated documentation for ClangFormat.

2015-04-26 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33527/ --- (Updated April 26, 2015, 9:59 p.m.) Review request for mesos, Benjamin