---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32150/#review81945
---
Ship it!
src/master/master.cpp
On April 22, 2015, 12:38 p.m., Alexander Rukletsov wrote:
src/master/master.cpp, lines 2458-2459
https://reviews.apache.org/r/32150/diff/5/?file=920953#file920953line2458
These two fields are optional, `principal` doesn't have a default. Do
we need to check it? Can a framework
On April 8, 2015, 9:19 p.m., Jie Yu wrote:
src/common/resources.cpp, line 663
https://reviews.apache.org/r/32149/diff/4/?file=920084#file920084line663
Do you need to call validate(operation.reserve().resources()) first
(like we did in CREATE/DESTROY)? Do you also want to check if
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/
---
(Updated April 29, 2015, 9:34 p.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33271/#review82025
---
Ship it!
docs/mesos-c++-style-guide.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33558/#review82027
---
docs/mesos-c++-style-guide.md
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32150/#review82045
---
Ship it!
src/master/master.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30774/#review82017
---
src/slave/containerizer/fetcher.hpp
On April 20, 2015, 5:18 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 258
https://reviews.apache.org/r/32198/diff/3/?file=903041#file903041line258
How about also checking for a larger array?
Alexander Rojas wrote:
What can be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30609/#review82060
---
3rdparty/libprocess/3rdparty/stout/include/stout/os/stat.hpp
On April 20, 2015, 3:18 p.m., Niklas Nielsen wrote:
3rdparty/libprocess/3rdparty/stout/tests/json_tests.cpp, line 258
https://reviews.apache.org/r/32198/diff/3/?file=903041#file903041line258
How about also checking for a larger array?
Alexander Rojas wrote:
What can be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33448/#review82083
---
See the thread here for previous discussion:
On April 29, 2015, 7:44 p.m., Joris Van Remoortere wrote:
.gitignore-template, lines 29-33
https://reviews.apache.org/r/33448/diff/1/?file=939883#file939883line29
Are all of these Eclipse specific?
I'm not familiar with eclipse, but the `.autotools` and `out/` seem
On April 29, 2015, 10:15 p.m., Jie Yu wrote:
src/master/master.cpp, lines 2487-2492
https://reviews.apache.org/r/32150/diff/8/?file=944522#file944522line2487
Why use a tmp variable here? Could you combine with validation below:
```
OptionError error =
On April 29, 2015, 8:24 p.m., Joris Van Remoortere wrote:
src/master/framework.cpp, line 187
https://reviews.apache.org/r/33376/diff/3/?file=939881#file939881line187
1) Let's sync with BenH if we want to factor out logging like this.
There are arguments on both sides, so let's
On April 29, 2015, 8:24 p.m., Joris Van Remoortere wrote:
I was surprised to see new functionality in this patch since the summary was
code movement :)
Just a quick note on DRY below.
On April 29, 2015, 8:24 p.m., Joris Van Remoortere wrote:
src/master/framework.cpp, line 187
16 matches
Mail list logo
