Re: Review Request 32140: Enabled 'Resources' to handle 'Resource::ReservationInfo'.

2015-05-08 Thread Michael Park
On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote: src/common/resources.cpp, lines 69-74 https://reviews.apache.org/r/32140/diff/1/?file=897349#file897349line69 Not yours, but resently, Vinod did a cleanup in equivalence operators for our proto messages in

Re: Review Request 32982: Added reservation user guide.

2015-05-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review83054 --- docs/reservation.md

Re: Review Request 32982: Added reservation user guide.

2015-05-08 Thread Michael Park
On April 24, 2015, 8:17 a.m., Alexander Rukletsov wrote: LGTM (not a native speaker). Shouldn't we commit this RR after introducing master endpoints : )? Shouldn't we commit this RR after introducing master endpoints : )? Updated the description to make this clear. On April 24, 2015,

Re: Review Request 33918: Added resources estimator abstraction for oversubscription.

2015-05-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33918/ --- (Updated May 8, 2015, 8:24 p.m.) Review request for mesos, Ben Mahler, Joris

Re: Review Request 33514: Wired up --allocator flag in master.

2015-05-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514/ --- (Updated May 8, 2015, 8:44 p.m.) Review request for mesos, Kapil Arya, Niklas

Re: Review Request 33514: Wired up --allocator flag in master.

2015-05-08 Thread Joerg Schad
On May 8, 2015, 8:58 p.m., Joerg Schad wrote: Please add to documentation After that Ship it! - Joerg --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514/#review83085

Re: Review Request 33514: Wired up --allocator flag in master.

2015-05-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33514/#review83095 --- Patch looks great! Reviews applied: [33513, 33514] All tests

Re: Review Request 33490: MESOS-2633 Avoid adding duplicate tasks

2015-05-08 Thread Marco Massenzio
On May 7, 2015, 8:37 a.m., Adam B wrote: Thanks for attacking one of my TODOs. I've got a couple of questions, but it looks pretty straightforward to me. I'm confused about when `==` would be too strict. What fields would you expect to differ? Maybe if you got a TASK_LOST followed

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-08 Thread Till Toenshoff
On May 7, 2015, 9:06 p.m., Niklas Nielsen wrote: docs/modules.md, line 149 https://reviews.apache.org/r/33718/diff/2/?file=952571#file952571line149 s/config/configuration file/? It does not have to be a file, hence I would suggest configuration. - Till

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-08 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33718/#review83074 --- docs/modules.md https://reviews.apache.org/r/33718/#comment133941

Re: Review Request 33718: Extended documentation on Mesos hooks.

2015-05-08 Thread Alexander Rukletsov
On May 7, 2015, 9:06 p.m., Niklas Nielsen wrote: Have you rendered this in a markdown viewer? As far as I know, the code block won't render if you don't have a preceeding newline I have and it was OK, but you're right and it's not consistent with the rest of the doc, I'll change that.

Re: Review Request 33823: Protocol file with the HTTP API messages between executor and slave

2015-05-08 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33823/#review83128 --- include/mesos/executor/executor.hpp

Re: Review Request 33513: Added a modules-aware factory for allocators.

2015-05-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33513/ --- (Updated May 8, 2015, 11:47 p.m.) Review request for mesos, Kapil Arya, Niklas

Re: Review Request 33513: Added a modules-aware factory for allocators.

2015-05-08 Thread Vinod Kone
On May 6, 2015, 10:39 p.m., Vinod Kone wrote: include/mesos/master/allocator.hpp, lines 54-55 https://reviews.apache.org/r/33513/diff/4/?file=951247#file951247line54 Instead of empty string, make the argument Optionstring? Alexander Rukletsov wrote: I think a common pattern