On March 18, 2015, 12:27 a.m., Alexander Rukletsov wrote:
src/common/resources.cpp, lines 69-74
https://reviews.apache.org/r/32140/diff/1/?file=897349#file897349line69
Not yours, but resently, Vinod did a cleanup in equivalence operators
for our proto messages in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/#review83054
---
docs/reservation.md
On April 24, 2015, 8:17 a.m., Alexander Rukletsov wrote:
LGTM (not a native speaker). Shouldn't we commit this RR after introducing
master endpoints : )?
Shouldn't we commit this RR after introducing master endpoints : )?
Updated the description to make this clear.
On April 24, 2015,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33918/
---
(Updated May 8, 2015, 8:24 p.m.)
Review request for mesos, Ben Mahler, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/
---
(Updated May 8, 2015, 8:44 p.m.)
Review request for mesos, Kapil Arya, Niklas
On May 8, 2015, 8:58 p.m., Joerg Schad wrote:
Please add to documentation
After that Ship it!
- Joerg
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/#review83085
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33514/#review83095
---
Patch looks great!
Reviews applied: [33513, 33514]
All tests
On May 7, 2015, 8:37 a.m., Adam B wrote:
Thanks for attacking one of my TODOs. I've got a couple of questions, but
it looks pretty straightforward to me.
I'm confused about when `==` would be too strict. What fields would you
expect to differ? Maybe if you got a TASK_LOST followed
On May 7, 2015, 9:06 p.m., Niklas Nielsen wrote:
docs/modules.md, line 149
https://reviews.apache.org/r/33718/diff/2/?file=952571#file952571line149
s/config/configuration file/?
It does not have to be a file, hence I would suggest configuration.
- Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33718/#review83074
---
docs/modules.md
https://reviews.apache.org/r/33718/#comment133941
On May 7, 2015, 9:06 p.m., Niklas Nielsen wrote:
Have you rendered this in a markdown viewer? As far as I know, the code
block won't render if you don't have a preceeding newline
I have and it was OK, but you're right and it's not consistent with the rest of
the doc, I'll change that.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33823/#review83128
---
include/mesos/executor/executor.hpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33513/
---
(Updated May 8, 2015, 11:47 p.m.)
Review request for mesos, Kapil Arya, Niklas
On May 6, 2015, 10:39 p.m., Vinod Kone wrote:
include/mesos/master/allocator.hpp, lines 54-55
https://reviews.apache.org/r/33513/diff/4/?file=951247#file951247line54
Instead of empty string, make the argument Optionstring?
Alexander Rukletsov wrote:
I think a common pattern
14 matches
Mail list logo