Re: Review Request 33792: Extend hashmap to support custom equality and hash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 2:56 p.m.) Review request for mesos and Ben Mahler. Sum

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 9, 2015, 2:56 p.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 33792: Extend hashmap to support custom equality and hash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:04 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 9, 2015, 3:04 p.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 33792: Extend hashmap to support custom equality and hash

> On May 4, 2015, 6:46 p.m., Alexander Rojas wrote: > > I am not really sure this is the way to go in order to create a case > > insensite hashmap. The class `hashmap` simply adds functionality to the > > `boost::unordered_map`. If one checks the API for the latter, the way > > needed to creat

Re: Review Request 33792: Extend hashmap to support custom equality and hash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:13 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 9, 2015, 3:13 p.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 33792: Extend hashmap to support custom equality and hash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:23 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 9, 2015, 3:23 p.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 33792: Extend hashmap to support custom equality and hash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:24 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33792: Extend hashmap to support custom equality and hash

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33792/ --- (Updated May 9, 2015, 3:36 p.m.) Review request for mesos, Alexander Rojas and

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/ --- (Updated May 9, 2015, 3:37 p.m.) Review request for mesos and Ben Mahler. Bug

Re: Review Request 33793: HTTP headers should be considered case-insensitive.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33793/#review83151 --- Patch looks great! Reviews applied: [33792, 33793] All tests passe

Review Request 34016: Change the type of signaledWrapper to unique_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/ --- Review request for mesos and Ben Mahler. Repository: mesos Description --

Re: Review Request 34016: Change the type of signaledWrapper to unique_ptr

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34016/#review83156 --- Patch looks great! Reviews applied: [34016] All tests passed. - M

Review Request 34017: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- Review request for mesos. Repository: mesos Description --- According Jo

Review Request 34018: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/ --- Review request for mesos. Repository: mesos Description --- According Jo

Re: Review Request 34017: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- (Updated May 9, 2015, 7:42 p.m.) Review request for mesos. Repository: mesos

Re: Review Request 34017: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- (Updated May 9, 2015, 7:45 p.m.) Review request for mesos. Repository: mesos

Re: Review Request 34017: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- (Updated May 9, 2015, 7:50 p.m.) Review request for mesos, Benjamin Hindman and

Re: Review Request 34018: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/ --- (Updated May 9, 2015, 7:50 p.m.) Review request for mesos, Benjamin Hindman and

Re: Review Request 34017: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34017/ --- (Updated May 9, 2015, 7:52 p.m.) Review request for mesos, Benjamin Hindman and

Re: Review Request 34018: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/ --- (Updated May 9, 2015, 7:52 p.m.) Review request for mesos, Benjamin Hindman and

Re: Review Request 34018: Update existing lambdas to meet style guide

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34018/#review83163 --- Patch looks great! Reviews applied: [34017, 34018] All tests passe

Re: Review Request 29748: Added tests for dynamic reservation.

> On April 23, 2015, 1:48 p.m., Michael Park wrote: > > As of now, the tests seem to take a long time to complete. We should > > investigate what the issue is before committing this patch. > > Jie Yu wrote: > I suspect this is due to the default allocation interval (1 secs by > default). >

Re: Review Request 31667: Piped hashmap from allocator through to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/ --- (Updated May 10, 2015, 12:21 a.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 32398: Persisted the reservation state on the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/ --- (Updated May 10, 2015, 12:33 a.m.) Review request for mesos and Alexander Rukle

Re: Review Request 31667: Piped hashmap from allocator through to sorter.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31667/#review83171 --- Patch looks great! Reviews applied: [31183, 31664, 31665, 31666, 31

Re: Review Request 32398: Persisted the reservation state on the slave.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32398/#review83172 --- Bad patch! Reviews applied: [32139, 32140, 32149, 32150, 29748, 323

Re: Review Request 33514: Wired up --allocator flag in master.

> On May 8, 2015, 8:58 p.m., Joerg Schad wrote: > > src/master/flags.cpp, line 351 > > > > > > Could you add this flag to the documentation > > http://mesos.apache.org/documentation/latest/configuration/ I have a

Re: Review Request 33513: Added a modules-aware factory for allocators.

> On May 6, 2015, 10:39 p.m., Vinod Kone wrote: > > include/mesos/master/allocator.hpp, lines 54-55 > > > > > > Instead of empty string, make the argument Option? > > Alexander Rukletsov wrote: > I think a common p