Re: Review Request 34298: Explictly validated that all resources specified in reserve or unreserve operations are dynamically reserved.

2015-05-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34298/#review84001 --- Ship it! src/master/validation.cpp

Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.

2015-05-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/ --- Review request for mesos, Jie Yu and Niklas Nielsen. Bugs: MESOS-2654

Review Request 34304: Updated documentation of FrameworkInfo.

2015-05-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34304/ --- Review request for mesos, Ben Mahler and Jie Yu. Repository: mesos

Review Request 34309: Support manipulating scheduler policy on Linux.

2015-05-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34309/ --- Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.

Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/ --- Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84003 --- Looks good. My main comments are around naming.

Review Request 34298: Explictly validated that all resources specified in reserve or unreserve operations are dynamically reserved.

2015-05-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34298/ --- Review request for mesos, Jie Yu and switched to 'mcypark'. Repository: mesos

Review Request 34299: Changed to use a push model for resource estimator.

2015-05-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/ --- Review request for mesos, Joris Van Remoortere, Niklas Nielsen, and Vinod Kone.

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/#review84002 --- Ship it! src/master/validation.cpp

Review Request 34308: Filter revocable resources.

2015-05-15 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-15 Thread Vinod Kone
On May 15, 2015, 6:09 p.m., Niklas Nielsen wrote: src/master/validation.cpp, line 90 https://reviews.apache.org/r/33865/diff/2/?file=960728#file960728line90 Do you want to stringify the resource for the error message here too? wanted to be consistent with the rest of the error

Re: Review Request 33865: Added RevocableInfo message to Resource protobuf.

2015-05-15 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33865/ --- (Updated May 15, 2015, 11:28 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 34295: Added maintainers documentation.

2015-05-15 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34295/#review84004 --- Ship it! Thanks Ben! LGTM. - Jie Yu On May 15, 2015, 10:25

Re: Review Request 34299: Changed to use a push model for resource estimator.

2015-05-15 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34299/#review84011 --- src/slave/slave.cpp

Re: Review Request 34306: Added 'revocable_offers' field to FrameworkInfo.

2015-05-15 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34306/#review84016 --- Patch looks great! Reviews applied: [34304, 34306] All tests

Re: Review Request 34310: Use IDLE scheduling for revocable CPU in cgroups isolator.

2015-05-15 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34310/#review84024 --- src/slave/containerizer/isolators/cgroups/cpushare.cpp

Re: Review Request 30774: Fetcher Cache

2015-05-15 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review83944 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 30774: Fetcher Cache

2015-05-15 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review83946 --- - Bernd Mathiske On May 13, 2015, 3:07 p.m., Bernd Mathiske

Re: Review Request 30774: Fetcher Cache

2015-05-15 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review83945 --- src/tests/fetcher_cache_tests.cpp

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-05-15 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33850/ --- (Updated May 15, 2015, 4:24 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30774: Fetcher Cache

2015-05-15 Thread Bernd Mathiske
On May 1, 2015, 12:17 p.m., Benjamin Hindman wrote: src/tests/fetcher_cache_tests.cpp, line 1179 https://reviews.apache.org/r/30774/diff/45/?file=947044#file947044line1179 Path { Trybool executable() const; }; Path(runDirectory,