Re: Review Request 34361: converted hard-coded strings to consts

2015-05-25 Thread Colin Williams
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/ --- (Updated May 25, 2015, 6:59 a.m.) Review request for mesos. Bugs: MESOS-2637

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-25 Thread Colin Williams
On May 20, 2015, 11:47 a.m., Alexander Rojas wrote: src/examples/test_hook_module.cpp, lines 36-38 https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36 This constants are used nowhere but in one method. Is there any reason why they are not defined in the method

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-25 Thread Colin Williams
On May 18, 2015, 5:48 p.m., Marco Massenzio wrote: src/examples/test_hook_module.cpp, lines 36-38 https://reviews.apache.org/r/34361/diff/1/?file=962951#file962951line36 Thanks for doing this! I'm wondering whether, as these are constants, shouldn't they be in

Re: Review Request 34317: Updated callers of os::getenv() in /src and removed calls to os::hasenv()

2015-05-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/ --- (Updated May 25, 2015, 4:44 p.m.) Review request for mesos. Summary

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-25 Thread Greg Mann
On May 20, 2015, 5:50 p.m., Timothy Chen wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 157 https://reviews.apache.org/r/34319/diff/3/?file=962168#file962168line157 Btw after looking at your other patches, I realize we don't really need hasenv anymore right?

Re: Review Request 34319: Refactored os::getenv() to return an option and updated its callers in stout.

2015-05-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 25, 2015, 4:38 p.m.) Review request for mesos. Changes ---

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/ --- (Updated May 25, 2015, 4:42 p.m.) Review request for mesos. Bugs: MESOS-994

Re: Review Request 34319: Refactored os::getenv() to return an option and removed os::hasenv()

2015-05-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated May 25, 2015, 4:43 p.m.) Review request for mesos. Summary

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34318/ --- (Updated May 25, 2015, 4:36 p.m.) Review request for mesos. Changes ---

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-25 Thread Greg Mann
On May 20, 2015, 5:49 p.m., Timothy Chen wrote: src/examples/balloon_framework.cpp, line 207 https://reviews.apache.org/r/34317/diff/1/?file=962096#file962096line207 Why not Optionstring value = os::getenv(MESOS_BUILD_DIR)? Greg Mann wrote: I think that in the case of a

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-25 Thread Greg Mann
On May 20, 2015, 5:49 p.m., Timothy Chen wrote: src/examples/low_level_scheduler_libprocess.cpp, line 353 https://reviews.apache.org/r/34317/diff/1/?file=962100#file962100line353 ditto Moved declaration and assignment onto same line. - Greg

Re: Review Request 34317: Updated callers of os::getenv() in /src.

2015-05-25 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34317/ --- (Updated May 25, 2015, 4:41 p.m.) Review request for mesos. Changes ---

Review Request 34655: Use relative url in /help generated links point

2015-05-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34655/ --- Review request for mesos and Adam B. Bugs: MESOS-2748

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-05-25 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34645/#review85137 --- This is an interesting case. We have a proxy to another function,

Review Request 34662: Modularized ResourceEstimator and added test for that module

2015-05-25 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod

Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

2015-05-25 Thread Bartek Plotka
On May 26, 2015, 4:16 a.m., Szymon Konefal wrote: src/tests/oversubscription_tests.cpp, line 80 https://reviews.apache.org/r/34662/diff/1/?file=971532#file971532line80 Why CHECK_SOME rather than ASSERT_SOME? CHECK_SOME prints only a log, and ASSERT_SOME could return

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

2015-05-25 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 26, 2015, 5:29 a.m.) Review request for mesos, Jie Yu, Niklas

Re: Review Request 34631: Added QoS Controller.

2015-05-25 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review85150 --- include/mesos/slave/qos_controller.hpp

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-25 Thread Marco Massenzio
On May 24, 2015, 6:35 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 151 https://reviews.apache.org/r/34193/diff/4/?file=965887#file965887line151 I think it would be great if we could consistently use the trailing underscore

Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

2015-05-25 Thread Szymon Konefal
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85146 --- src/tests/oversubscription_tests.cpp

Re: Review Request 34662: Modularized ResourceEstimator and added test for that module

2015-05-25 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/ --- (Updated May 26, 2015, 4:36 a.m.) Review request for mesos, Jie Yu, Niklas