Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-05-26 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/ --- Review request for mesos, haosdent huang and Niklas Nielsen. Bugs: MESOS-2340

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

2015-05-26 Thread Bartek Plotka
On May 26, 2015, 8:13 p.m., Niklas Nielsen wrote: src/tests/resource_estimator.hpp, line 40 https://reviews.apache.org/r/34662/diff/2/?file=971547#file971547line40 Put { on a newline Why have create take flags? We tried to make it only take a string. Yeah, but it was needed

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

2015-05-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85304 --- Small nits - we are close :) src/Makefile.am

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review85296 --- Patch looks great! Reviews applied: [34392, 30032] All tests

Re: Review Request 34669: Add a virtualenv bootstrapper for post-reviews.

2015-05-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34669/#review85327 --- Patch looks great! Reviews applied: [34669] All tests passed. -

Re: Review Request 33296: Added a flag which controls libprocess firewall initialzation.

2015-05-26 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33296/#review85158 --- Ship it! src/Makefile.am

Re: Review Request 34545: Updated the allocator related docs.

2015-05-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/ --- (Updated May 26, 2015, 9:57 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 34545: Updated the allocator related docs.

2015-05-26 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/ --- (Updated May 26, 2015, 10:37 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 34276: Use special constructor for OptionT from SomeT.

2015-05-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34276/#review85165 --- Ship it! Ship It! - Bernd Mathiske On May 21, 2015, 4:45 p.m.,

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-05-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/#review85210 --- docs/mesos-c++-style-guide.md

Re: Review Request 34140: AppC image store

2015-05-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/#review83840 --- src/slave/containerizer/provisioners/appc/store.hpp

Re: Review Request 34644: Update existing lambdas to meet style guide

2015-05-26 Thread haosdent huang
On May 25, 2015, 10:51 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/src/tests/process_tests.cpp, line 1411 https://reviews.apache.org/r/34644/diff/1/?file=971207#file971207line1411 I don't think this will compile. This forces a copy of `receiver`, which the

Re: Review Request 34645: Update existing lambdas to meet style guide

2015-05-26 Thread haosdent huang
On May 25, 2015, 11:05 p.m., Joris Van Remoortere wrote: This is an interesting case. We have a proxy to another function, rather than the implementation of that function as a lambda. I'm curious what the community's view is on using the proxy lambda approach as per your patch, versus

Re: Review Request 34140: AppC image store

2015-05-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/ --- (Updated May 26, 2015, 11:25 a.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 34654: Send docker inspect output with TaskStatus data.

2015-05-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34654/ --- (Updated May 26, 2015, 6:14 p.m.) Review request for mesos and Benjamin

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/#review85183 --- 3rdparty/libprocess/include/process/http.hpp

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Bartek Plotka
On May 26, 2015, 7:26 p.m., Vinod Kone wrote: include/mesos/slave/oversubscription.proto, line 35 https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line35 s/future/the future/ Agree. On May 26, 2015, 7:26 p.m., Vinod Kone wrote:

Re: Review Request 34662: Modularized ResourceEstimator and added test for RE module

2015-05-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34662/#review85225 --- src/Makefile.am https://reviews.apache.org/r/34662/#comment136757

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-05-26 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review84194 --- src/slave/containerizer/isolators/filesystem/linux.cpp

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

2015-05-26 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/ --- (Updated May 26, 2015, 8:41 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85227 --- include/mesos/slave/oversubscription.proto

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 26, 2015, 8:50 p.m.) Review request for mesos, Jie Yu, Niklas

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Bartek Plotka
On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: include/mesos/slave/oversubscription.proto, line 34 https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line34 please consider calling this `QosCorrectiveAction` (we require CamelCase for our types, in any event;

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/#review85252 --- include/mesos/slave/oversubscription.proto

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 26, 2015, 9:07 p.m.) Review request for mesos, Jie Yu, Niklas

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-05-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34318/#review85263 --- Patch looks great! Reviews applied: [34319, 34317, 34318] All

Re: Review Request 34193: Refactored common functionality into FlagsBase

2015-05-26 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/ --- (Updated May 26, 2015, 8:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34195: Refactoring to use BaseFlags common functionality

2015-05-26 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34195/ --- (Updated May 26, 2015, 8:58 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34669: Add a virtualenv bootstrapper for post-reviews.

2015-05-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34669/#review85261 --- support/virtualenv.sh

Re: Review Request 34631: Added QoS Controller.

2015-05-26 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/#review85267 --- Ship it! Ship It! - Bartek Plotka On May 26, 2015, 3:30 p.m.,

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

2015-05-26 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31505/#review85268 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30032/ --- (Updated May 26, 2015, 4:41 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30032: Added support for cache control in libprocess when dealing with static files.

2015-05-26 Thread Alexander Rojas
On May 22, 2015, 5:03 p.m., Bernd Mathiske wrote: 3rdparty/libprocess/src/process.cpp, line 2708 https://reviews.apache.org/r/30032/diff/7/?file=963339#file963339line2708 Why Result and not Try? Why not propagate the error from mtime? Why snake_case and not camelCase?

Re: Review Request 34431: Add htb queueing discipline

2015-05-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/#review85273 --- src/linux/routing/queueing/htb.hpp

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Vinod Kone
On May 26, 2015, 7:26 p.m., Vinod Kone wrote: include/mesos/slave/oversubscription.proto, line 47 https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line47 why optional? Bartek Plotka wrote: IMO, because we can (only optionally) specify the descriptive reason

Re: Review Request 34361: converted hard-coded strings to consts

2015-05-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34361/#review85285 --- Patch looks great! Reviews applied: [34361] All tests passed. -

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

2015-05-26 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 26, 2015, 9:59 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

2015-05-26 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review85272 --- src/linux/routing/queueing/ingress.cpp

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Niklas Nielsen
On May 26, 2015, 12:26 p.m., Vinod Kone wrote: include/mesos/slave/oversubscription.proto, line 48 https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line48 why a timestamp? Bartek Plotka wrote: It could be necessary for some advanced long term corrective

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34581/ --- (Updated May 26, 2015, 10:24 p.m.) Review request for mesos, Jie Yu, Joris Van

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Niklas Nielsen
On May 26, 2015, 12:26 p.m., Vinod Kone wrote: include/mesos/slave/oversubscription.proto, line 47 https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line47 why optional? Bartek Plotka wrote: IMO, because we can (only optionally) specify the descriptive reason

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-05-26 Thread Ian Downes
On Feb. 4, 2015, 5:44 p.m., Timothy Chen wrote: src/launcher/executor.cpp, line 137 https://reviews.apache.org/r/30643/diff/1/?file=849116#file849116line137 I think it's worth commenting somewhere high level that the command executor is expecting executorInfo's data to be an

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-05-26 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/ --- (Updated May 26, 2015, 3:49 p.m.) Review request for mesos, Timothy Chen and

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Vinod Kone
On May 26, 2015, 7:26 p.m., Vinod Kone wrote: include/mesos/slave/oversubscription.proto, line 47 https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line47 why optional? Bartek Plotka wrote: IMO, because we can (only optionally) specify the descriptive reason

Re: Review Request 34676: Add printing of extended attributes to Resource objects.

2015-05-26 Thread Brian Wickman
On May 26, 2015, 8:57 p.m., Vinod Kone wrote: src/common/resources.cpp, line 1160 https://reviews.apache.org/r/34676/diff/1/?file=972037#file972037line1160 Lets use something other than *, since we already abuse it to represent the default role and unreserved resources.

Re: Review Request 34428: Extend queueing discipline wrappers to expose network isolator statistics

2015-05-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34428/#review85266 --- src/Makefile.am https://reviews.apache.org/r/34428/#comment136800

Re: Review Request 34676: Add printing of extended attributes to Resource objects.

2015-05-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34676/ --- (Updated May 26, 2015, 11:19 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-05-26 Thread Ian Downes
On April 13, 2015, 3:49 p.m., Jie Yu wrote: src/tests/launch_tests.cpp, lines 109-110 https://reviews.apache.org/r/31444/diff/4/?file=920907#file920907line109 Why slave mount? Shouldn't this be a SHARED mount? No, we want this as a slave mount, i.e., no back propagation. - Ian

Re: Review Request 31505: Add flow classifiers for fq_codel on egress

2015-05-26 Thread Cong Wang
On May 26, 2015, 9:54 p.m., Chi Zhang wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1843-1850 https://reviews.apache.org/r/31505/diff/8/?file=972152#file972152line1843 this could also happen if we are recovering a container not using this feature right?

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Bartek Plotka
On May 26, 2015, 7:26 p.m., Vinod Kone wrote: include/mesos/slave/oversubscription.proto, line 47 https://reviews.apache.org/r/34581/diff/6/?file=970357#file970357line47 why optional? Bartek Plotka wrote: IMO, because we can (only optionally) specify the descriptive reason

Re: Review Request 34581: Added oversubscription.proto for QoS Controller and slave communication

2015-05-26 Thread Marco Massenzio
On May 22, 2015, 8:50 p.m., Marco Massenzio wrote: include/mesos/slave/oversubscription.proto, line 34 https://reviews.apache.org/r/34581/diff/2/?file=969904#file969904line34 please consider calling this `QosCorrectiveAction` (we require CamelCase for our types, in any event;

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-26 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review85295 --- Ship it! Modulo Vinod's comment - Chi Zhang On May 22, 2015,

Re: Review Request 34431: Add htb queueing discipline

2015-05-26 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34431/#review85291 --- after seeing a few more patches, I agree that parent / handle

Re: Review Request 34193: Refactored common functionality into BaseFlags

2015-05-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34193/#review85203 --- One thing I missed in my last review, let's make sure we

Re: Review Request 34654: Send docker inspect output with TaskStatus data.

2015-05-26 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34654/ --- (Updated May 26, 2015, 5:37 p.m.) Review request for mesos and Benjamin

Re: Review Request 34631: Added QoS Controller.

2015-05-26 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated May 26, 2015, 8:30 a.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 34545: Updated the allocator related docs.

2015-05-26 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34545/#review85190 --- Ship it! Ship It! - Bernd Mathiske On May 26, 2015, 3:37 a.m.,

Re: Review Request 34278: Refactor Stout ResultT leveraging TryOptionT to remove the dynamic allocation.

2015-05-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34278/#review85199 --- Ship it! Ship It! - Benjamin Hindman On May 21, 2015, 11:45

Re: Review Request 34277: Refactor Stout TryT leveraging OptionT to remove dynamic allocation.

2015-05-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34277/#review85198 --- Ship it! Ship It! - Benjamin Hindman On May 21, 2015, 11:45

Re: Review Request 34276: Use special constructor for OptionT from SomeT.

2015-05-26 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34276/#review85197 --- Ship it! Ship It! - Benjamin Hindman On May 21, 2015, 11:45

Review Request 34669: Add a virtualenv bootstrapper for post-reviews.

2015-05-26 Thread Brian Wickman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34669/ --- Review request for mesos and Vinod Kone. Repository: mesos Description