Re: Review Request 34631: Added QoS Controller.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated June 4, 2015, 2:23 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/ --- (Updated June 4, 2015, 11:47 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

2015-06-04 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34970/ --- (Updated June 5, 2015, 5:52 a.m.) Review request for mesos, Jie Yu and Vinod

Review Request 35108: Passed allocated resources to the resource estimator.

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35108/ --- Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone. Bugs:

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review86731 --- Patch looks great! Reviews applied: [35079, 34631, 34632, 34633,

Re: Review Request 35079: Added wrapper header for mesos/slave/oversubscription.pb.h

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35079/ --- (Updated June 4, 2015, 2:28 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/#review86736 --- Bad patch! Reviews applied: [35088, 35089, 35090, 35091, 35092,

Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

2015-06-04 Thread Marco Massenzio
On June 4, 2015, 5:52 p.m., Adam B wrote: docs/getting-started.md, lines 24-26 https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line24 It was suggested that we should keep this document shortsweet and only reference the latest Ubuntu LTS release, and then we can

Review Request 35088: Add dependent include to synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35088/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/#review86741 --- Bad patch! Reviews applied: [35088, 35089, 35090, 35091, 35092,

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86722 --- Ship it! src/slave/resource_estimator.cpp

Re: Review Request 35082: Adjusted the NoopResourceEstimator to the new slave semantics.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35082/#review86720 --- Ship it! Ship It! - Niklas Nielsen On June 4, 2015, 10:55 a.m.,

Review Request 35096: Update mesos scheduler to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35096/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35100: Update hook manager to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35100/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35098: Update module manager to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35098/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35090: Update libprocess process to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35090/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35094: Update libprocess gate to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35094/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35092: Rebase master_contender_detector_tests with gmock synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35092/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35101: Update zookeeper tests to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35101/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35095: Update linux fs to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35095/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35091: Update libprocess gmock to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35091/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35093: Update libprocess once to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35093/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Review Request 35089: Replace lock_guard with synchronized in fetcher_cache_test.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35089/ --- Review request for mesos, Benjamin Hindman and Bernd Mathiske. Bugs:

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 4, 2015, 2:25 p.m.) Review request for mesos, Bartek Plotka, Jie

Re: Review Request 35097: Update mesos executor to use synchronized.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35097/ --- (Updated June 4, 2015, 11:07 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-06-04 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33752/#review86738 --- LGTM - Cody Maloney On June 4, 2015, 7:31 p.m., James Peach

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/ --- (Updated June 4, 2015, 11:07 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 34632: Added QoS Controller in slave

2015-06-04 Thread Niklas Nielsen
On June 3, 2015, 4:26 p.m., Jie Yu wrote: src/slave/slave.cpp, lines 344-345 https://reviews.apache.org/r/34632/diff/2/?file=977215#file977215line344 Can you explain why you want to start receiving/acting on corrections even before the slave is recovered? How do you kill a

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Jie Yu
On June 4, 2015, 5:58 p.m., Vinod Kone wrote: src/slave/slave.cpp, lines 4400-4413 https://reviews.apache.org/r/34720/diff/3/?file=979257#file979257line4400 This is getting a little hairy. As the TODO says we really ought bubble this up via the Termination protobuf. Have you

Re: Review Request 35064: Added help for slave

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35064/#review86685 --- Did you mean to create a new review request? Remember to add the

Review Request 35082: Adjusted the NoopResourceEstimator to the new slave semantics.

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35082/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Repository: mesos

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/#review86669 --- src/slave/slave.cpp

Re: Review Request 11914: Get EC2 scripts into workable state

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11914/#review86673 --- Stale review: Charles, still want this in? - Niklas Nielsen On

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-04 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review86675 --- src/slave/containerizer/mesos/launch.cpp

Re: Review Request 30612: Added /master/frameworks/{framework}/tasks/{task} endpoint.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30612/#review86687 --- From our last conversation, it sounds like you want to change the

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Jie Yu
On June 4, 2015, 5:58 p.m., Vinod Kone wrote: src/slave/slave.cpp, lines 4400-4413 https://reviews.apache.org/r/34720/diff/3/?file=979257#file979257line4400 This is getting a little hairy. As the TODO says we really ought bubble this up via the Termination protobuf. Have you

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Vinod Kone
On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: src/tests/oversubscription_tests.cpp, line 66 https://reviews.apache.org/r/35028/diff/1/?file=977722#file977722line66 We have const char* in for example https://github.com/apache/mesos/blob/master/src/tests/hook_tests.cpp#L78

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/ --- (Updated June 4, 2015, 5:56 p.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 35080: Fix comments in routing_tests.cpp

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35080/#review86670 --- Ship it! Thanks! - Jie Yu On June 4, 2015, 5:51 p.m., Cong Wang

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Jie Yu
On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: src/slave/resource_estimator.cpp, lines 46-48 https://reviews.apache.org/r/35028/diff/1/?file=977720#file977720line46 How about wrapping like: ``` return Error( Could not create resource

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Jie Yu
On June 3, 2015, 11:16 p.m., Niklas Nielsen wrote: src/tests/oversubscription_tests.cpp, line 66 https://reviews.apache.org/r/35028/diff/1/?file=977722#file977722line66 We have const char* in for example https://github.com/apache/mesos/blob/master/src/tests/hook_tests.cpp#L78

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 4, 2015, 10:43 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34631: Added QoS Controller.

2015-06-04 Thread Niklas Nielsen
On June 3, 2015, 4:02 p.m., Jie Yu wrote: include/mesos/slave/qos_controller.hpp, lines 25-26 https://reviews.apache.org/r/34631/diff/3/?file=977207#file977207line25 Can you add a wrapper header mesos/slave/oversubscription.hpp similar to what we do for things

Review Request 35079: Added wrapper header for mesos/slave/oversubscription.pb.h

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35079/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 34633: Added QoS Controller test.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34632: Added QoS Controller in slave

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/ --- (Updated June 4, 2015, 10:43 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34719: Added QOS_KILLED as status reason

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34719/ --- (Updated June 4, 2015, 10:43 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34631: Added QoS Controller.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34631/ --- (Updated June 4, 2015, 10:42 a.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

2015-06-04 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34976/#review86667 --- docs/getting-started.md

Re: Review Request 11605: Add --enable-debug configure flag.

2015-06-04 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11605/#review86672 --- Stale review: Brenden, still want this in? - Niklas Nielsen On

Re: Review Request 34633: Added QoS Controller test.

2015-06-04 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34633/#review86679 --- src/tests/oversubscription_tests.cpp

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Niklas Nielsen
On June 4, 2015, 10:58 a.m., Vinod Kone wrote: src/slave/slave.cpp, lines 4400-4413 https://reviews.apache.org/r/34720/diff/3/?file=979257#file979257line4400 This is getting a little hairy. As the TODO says we really ought bubble this up via the Termination protobuf. Have you

Review Request 35080: Fix comments in routing_tests.cpp

2015-06-04 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35080/ --- Review request for mesos, Jie Yu and Paul Brett. Repository: mesos

Re: Review Request 34632: Added QoS Controller in slave

2015-06-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34632/#review86677 --- Ship it! Ship It! - Jie Yu On June 4, 2015, 5:42 p.m., Niklas

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread James Peach
On June 4, 2015, 3:22 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/configure.ac, line 692 https://reviews.apache.org/r/33850/diff/2/?file=950418#file950418line692 I think you meant != here. ;-) How did this pass for you!? That for fixing that. I think what happened was that

Re: Review Request 34426: Report per-container metrics for network bandwidth throttling

2015-06-04 Thread Jie Yu
On June 3, 2015, 10:35 p.m., Jie Yu wrote: src/linux/routing/queueing/internal.hpp, line 320 https://reviews.apache.org/r/34426/diff/11/?file=977689#file977689line320 Why =? Paul Brett wrote: The definition for RTNL_TC_STATS_MAX comes from libnl and looks like this:

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-06-04 Thread James Peach
On May 1, 2015, 7:30 p.m., Cody Maloney wrote: configure.ac, line 1407 https://reviews.apache.org/r/33752/diff/1/?file=947254#file947254line1407 I worry this changes the behavior some when --disable-bundled is set (Previously it seems like it would see if it could find the

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33754/#review86597 --- Ship it! Ship It! - Benjamin Hindman On May 1, 2015, 4:02 p.m.,

Re: Review Request 33754: Update pthread autoconf macros for libprocess.

2015-06-04 Thread Benjamin Hindman
On May 18, 2015, 6:24 p.m., haosdent huang wrote: 3rdparty/libprocess/configure.ac, line 745 https://reviews.apache.org/r/33754/diff/1/?file=947259#file947259line745 Maybe we could search the whole project and replace acx_pthread.m4 - ax_pthread.m4 I fixed this for you before

Re: Review Request 33331: Added file headers section to the C++ style guide.

2015-06-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/ --- (Updated June 4, 2015, 2:37 p.m.) Review request for mesos. Changes ---

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
On June 4, 2015, 2:44 p.m., Benjamin Hindman wrote: Ship It! Like another patch you submitted you went from +2 to +4 indentation here, please be on the look out for that in the future. Thanks! - Benjamin --- This is an

Re: Review Request 33849: mesos: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
On May 5, 2015, 4:29 p.m., Cody Maloney wrote: configure.ac, line 575 https://reviews.apache.org/r/33849/diff/1/?file=950367#file950367line575 Can you check ax_cxx_compiler_version = Clang/LLVM 3.5 here? Or does that not work on both OS X and Linux? James Peach wrote:

Re: Review Request 35075: Fixed style issues in the File Header section in the C++ style-guide.

2015-06-04 Thread Till Toenshoff
On June 4, 2015, 3:10 p.m., Till Toenshoff wrote: Ship It! Thanks Joerg! - Till --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35075/#review86626

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33850/#review86628 --- 3rdparty/libprocess/configure.ac

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-06-04 Thread Benjamin Hindman
On May 18, 2015, 6:20 p.m., haosdent huang wrote: configure.ac, line 650 https://reviews.apache.org/r/33753/diff/1/?file=947255#file947255line650 Should we change acx_pthread.m4 to ax_pthread.m4 here? James Peach wrote: Updated the patch to alter the comments too. I think

Re: Review Request 33755: Remove the unused acx_pthread autoconf macro from stout.

2015-06-04 Thread Benjamin Hindman
On June 4, 2015, 1:47 p.m., Benjamin Hindman wrote: Ship It! Note that I also had to update stout/Makefile.am to remove the usage of the 'm4' directory. I'm not sure how this didn't break running 'bootstrap' for you? - Benjamin ---

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-04 Thread Till Toenshoff
On May 19, 2015, 8:13 p.m., Vinod Kone wrote: src/cli/mesos.cpp, line 31 https://reviews.apache.org/r/34260/diff/6/?file=962331#file962331line31 So basename can never return an error? When did ::basename() return NULL? Alexander Rojas wrote: I checked in the `::basename`

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/configure.ac, line 694 https://reviews.apache.org/r/33850/diff/2/?file=950418#file950418line694 s/Mesos/libprocess/ I took care of this fix for you James before committing. Thanks! - Benjamin

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote: Just a heads up, you went from the +2 indentation in this file to +4 when you moved stuff around. I fixed it for you, but please keep the style consistent in the future, thanks! - Benjamin

Re: Review Request 35075: Fixed style issues in the File Header section in the C++ style-guide.

2015-06-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35075/#review86626 --- Ship it! Ship It! - Till Toenshoff On June 4, 2015, 3:08 p.m.,

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33753/#review86598 --- Ship it! Ship It! - Benjamin Hindman On May 1, 2015, 4:02 p.m.,

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33850/#review86602 --- Ship it! 3rdparty/libprocess/configure.ac

Re: Review Request 33331: Added file headers section to the C++ style guide.

2015-06-04 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/1/#review86615 --- docs/mesos-c++-style-guide.md

Re: Review Request 34319: Refactored os::getenv() to return an option and removed os::hasenv()

2015-06-04 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34319/ --- (Updated June 4, 2015, 6:13 a.m.) Review request for mesos. Changes ---

Re: Review Request 34318: Update callers of os::getenv() in libprocess.

2015-06-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34318/#review86563 --- Patch looks great! Reviews applied: [34319, 34317, 34318] All

Re: Review Request 35012: Move synchronized.hpp into stout.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35012/#review86573 --- Ship it!

Re: Review Request 30339: Call hookmanager only if some hooks are installed.

2015-06-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30339/#review86574 --- src/hook/manager.cpp

Re: Review Request 32364: Refactor http to use synchronized.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32364/#review86570 --- Ship it! Ship It! - Benjamin Hindman On June 3, 2015, 5:19

Re: Review Request 32358: Refactor Future to use synchronized.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32358/#review86565 --- Ship it! Ship It! - Benjamin Hindman On June 3, 2015, 5:16

Re: Review Request 32361: Refactor Queue to use synchronized.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32361/#review86567 --- Ship it! Ship It! - Benjamin Hindman On June 3, 2015, 5:16

Re: Review Request 32356: Refactor synchronized to use mutex, recursive_mutex, atomic_flag.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32356/#review86564 --- Ship it! Ship It! - Benjamin Hindman On June 3, 2015, 5:11

Re: Review Request 32365: Remove libprocess internal.hpp.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32365/#review86571 --- Ship it! Ship It! - Benjamin Hindman On June 3, 2015, 5:19

Re: Review Request 32362: Refactor Metrics::Timer to use synchronized.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32362/#review86568 --- Ship it! Ship It! - Benjamin Hindman On June 3, 2015, 5:17

Re: Review Request 32360: Refactor Mutex to use synchronized.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32360/#review86566 --- Ship it! Ship It! - Benjamin Hindman On June 3, 2015, 5:16

Re: Review Request 35013: Move synchronized.hpp out of libprocess.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35013/#review86572 --- Ship it! Ship It! - Benjamin Hindman On June 3, 2015, 5:14

Re: Review Request 34984: Added help for files

2015-06-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34984/#review86583 --- Patch looks great! Reviews applied: [34984] All tests passed. -

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Jie Yu
On June 4, 2015, 5:58 p.m., Vinod Kone wrote: src/slave/slave.cpp, lines 4400-4413 https://reviews.apache.org/r/34720/diff/3/?file=979257#file979257line4400 This is getting a little hairy. As the TODO says we really ought bubble this up via the Termination protobuf. Have you

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Niklas Nielsen
On June 4, 2015, 10:58 a.m., Vinod Kone wrote: src/slave/slave.cpp, lines 4400-4413 https://reviews.apache.org/r/34720/diff/3/?file=979257#file979257line4400 This is getting a little hairy. As the TODO says we really ought bubble this up via the Termination protobuf. Have you

Re: Review Request 35028: Added a fixed resource estimator.

2015-06-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35028/#review86703 --- Patch looks great! Reviews applied: [35028] All tests passed. -

Review Request 35084: Provided consistent behavior for bundled packages.

2015-06-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35084/ --- Review request for mesos. Repository: mesos Description --- Add the

Review Request 35060: Added help for slave

2015-06-04 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35060/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-2277

Re: Review Request 35000: Doxygen'ized Subprocess.

2015-06-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/#review86577 --- 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 34984: Added help for files

2015-06-04 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34984/ --- (Updated June 4, 2015, 9:40 a.m.) Review request for mesos, Niklas Nielsen and

Review Request 35065: Fix uninitialized warning introduced by synchronized patches.

2015-06-04 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35065/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Review Request 35064: Added help for slave

2015-06-04 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35064/ --- Review request for mesos, Niklas Nielsen and Vinod Kone. Bugs: MESOS-2277

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-04 Thread Niklas Nielsen
On June 4, 2015, 10:58 a.m., Vinod Kone wrote: src/slave/slave.cpp, lines 4400-4413 https://reviews.apache.org/r/34720/diff/3/?file=979257#file979257line4400 This is getting a little hairy. As the TODO says we really ought bubble this up via the Termination protobuf. Have you

Re: Review Request 33752: MESOS-2537: Fix AC_ARG_ENABLED option processing

2015-06-04 Thread James Peach
On May 1, 2015, 7:30 p.m., Cody Maloney wrote: configure.ac, line 1407 https://reviews.apache.org/r/33752/diff/1/?file=947254#file947254line1407 I worry this changes the behavior some when --disable-bundled is set (Previously it seems like it would see if it could find the

Re: Review Request 35065: Fix uninitialized warning introduced by synchronized patches.

2015-06-04 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35065/#review86590 --- Ship it! Ship It! - Benjamin Hindman On June 4, 2015, 12:16

  1   2   >