Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-06-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33271/#review86765 --- Thanks guys! docs/mesos-c++-style-guide.md

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review86783 --- Patch looks great! Reviews applied: [32961, 33159] All tests

Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34970/#review86767 --- Bad patch! Reviews applied: [34968, 34969, 34970] Failed command:

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-06-05 Thread Joris Van Remoortere
Hey BenM, BenH added spaces before the commit, but thanks for also catching it! I'll follow up with a small patch to change the POD to something like SlaveID. Can you shepherd that one? :-) Joris On Fri, Jun 5, 2015 at 8:03 AM, Ben Mahler benjamin.mah...@gmail.com wrote: This is an

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review86781 --- Ship it! src/master/allocator/mesos/hierarchical.hpp

Re: Review Request 35090: Update libprocess process to use synchronized.

2015-06-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35090/ --- (Updated June 5, 2015, 7:42 a.m.) Review request for mesos, Benjamin Hindman

Review Request 35120: Use non-POD type for alias example in c++ style guide.

2015-06-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35120/ --- Review request for mesos, Benjamin Hindman and Ben Mahler. Repository: mesos

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/ --- (Updated June 5, 2015, 8:53 a.m.) Review request for mesos and Benjamin

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/ --- (Updated June 5, 2015, 7:42 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35102: Remove common/lock. Use synchronized instead.

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35102/#review86779 --- Patch looks great! Reviews applied: [35088, 35089, 35090, 35091,

Re: Review Request 35000: Doxygen'ized Subprocess.

2015-06-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35000/#review86787 --- Ship it! 3rdparty/libprocess/include/process/subprocess.hpp

Re: Review Request 33271: Update style guide to disallow capturing temporaries by reference.

2015-06-05 Thread Joris Van Remoortere
Here is the review. I used std::string instead. Also cleaned up an unused struct. https://reviews.apache.org/r/35120 On Fri, Jun 5, 2015 at 9:58 AM, Joris Van Remoortere joris.van.remoort...@gmail.com wrote: Hey BenM, BenH added spaces before the commit, but thanks for also catching it!

Re: Review Request 34256: Added Path::dirname() and Path::basename().

2015-06-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34256/ --- (Updated June 5, 2015, 1:03 p.m.) Review request for mesos and Cody Maloney.

Re: Review Request 34259: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34259/ --- (Updated June 5, 2015, 1:22 p.m.) Review request for mesos and Cody Maloney.

Re: Review Request 34256: Added Path::dirname() and Path::basename().

2015-06-05 Thread Till Toenshoff
On May 19, 2015, 8:07 p.m., Vinod Kone wrote: 3rdparty/libprocess/3rdparty/stout/tests/path_tests.cpp, line 29 https://reviews.apache.org/r/34256/diff/4/?file=962202#file962202line29 nice tests. Can I drop this issue :)? On May 19, 2015, 8:07 p.m., Vinod Kone wrote:

Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

2015-06-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35129/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-2801

Review Request 35131: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35131/ --- Review request for mesos and Cody Maloney. Bugs: MESOS-1303

Re: Review Request 34943: Added validation to flags.

2015-06-05 Thread Benjamin Hindman
On June 2, 2015, 3:38 p.m., Marco Massenzio wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 141 https://reviews.apache.org/r/34943/diff/1/?file=976658#file976658line141 can you please add some documentation to explain what each type (and the relative

Re: Review Request 34260: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34260/ --- (Updated June 5, 2015, 1:26 p.m.) Review request for mesos and Cody Maloney.

Review Request 35125: Fixed verb naming of Flag::loader to Flag::load.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35125/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 35127: Updated libprocess to match stout Flags changes.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35127/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 35128: Updated Mesos to match stout Flags changes.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35128/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Review Request 35126: Used C++11 lambdas instead of functors in FlagsBase.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35126/ --- Review request for mesos and Till Toenshoff. Repository: mesos Description

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/ --- (Updated June 5, 2015, 1:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 35125: Fixed verb naming of Flag::loader to Flag::load.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35125/ --- (Updated June 5, 2015, 2:21 p.m.) Review request for mesos and Till Toenshoff.

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Vinod Kone
On June 5, 2015, 5:42 p.m., Vinod Kone wrote: src/master/allocator/mesos/hierarchical.hpp, lines 455-456 https://reviews.apache.org/r/33159/diff/4/?file=979945#file979945line455 I don't follow. Why are these CHECKs? Is there currently code in the master that guarantees that these

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review86808 --- src/common/http.hpp

Re: Review Request 33159: Pump updateFramework through Allocator from Master.

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33159/#review86818 --- src/master/allocator/mesos/hierarchical.hpp

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/#review86819 --- I made some minor comments below but I think a better way to do

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Niklas Nielsen
On June 5, 2015, 11:42 a.m., Vinod Kone wrote: src/common/http.cpp, line 212 https://reviews.apache.org/r/34687/diff/6/?file=977637#file977637line212 Why do you need this temporary? BenH brought this up - look above. I think this is fine if it is made const. - Niklas

Re: Review Request 34258: Removed os::dirname and os::basename.

2015-06-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34258/ --- (Updated June 5, 2015, 4:39 p.m.) Review request for mesos and Cody Maloney.

Re: Review Request 35129: Refactor Future::Data to use ResultT. Remove dynamic allocation.

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35129/#review86812 --- Patch looks great! Reviews applied: [35129] All tests passed. -

Re: Review Request 34258: Removed os::dirname and os::basename.

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34258/#review86814 --- Bad patch! Reviews applied: [34256, 35131, 34259, 34260] Failed

Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

2015-06-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34970/ --- (Updated June 5, 2015, 7:56 p.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34970/#review86846 --- Ship it! src/examples/no_executor_framework.cpp

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Marco Massenzio
On June 5, 2015, 6:42 p.m., Vinod Kone wrote: I made some minor comments below but I think a better way to do this is to *not* write custom masterinfo json - protobuf converters. I prefer we just add a new optional field (say ipAddress of type string). Then you can just leverage the

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/#review86847 --- Patch looks great! Reviews applied: [35150, 35152] All tests

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Marco Massenzio
On June 5, 2015, 6:42 p.m., Vinod Kone wrote: I made some minor comments below but I think a better way to do this is to *not* write custom masterinfo json - protobuf converters. I prefer we just add a new optional field (say ipAddress of type string). Then you can just leverage the

Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Niklas Nielsen
On June 5, 2015, 11:42 a.m., Vinod Kone wrote: I made some minor comments below but I think a better way to do this is to *not* write custom masterinfo json - protobuf converters. I prefer we just add a new optional field (say ipAddress of type string). Then you can just leverage the

Review Request 35119: Introduced metrics for revocable resources.

2015-06-05 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35119/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2776

Review Request 35157: Added test for ResourceEstimator fetching ResoruceUsage from ResourceMonitor.

2015-06-05 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/ --- Review request for mesos, Ben Mahler, Jie Yu, Niklas Nielsen, Szymon Konefal,

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/#review86843 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 34984: Added help for files

2015-06-05 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34984/#review86849 --- Ship it! I will make the change for you below. Thanks Aditi!

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Vinod Kone
On June 5, 2015, 6:42 p.m., Vinod Kone wrote: I made some minor comments below but I think a better way to do this is to *not* write custom masterinfo json - protobuf converters. I prefer we just add a new optional field (say ipAddress of type string). Then you can just leverage the

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34687/ --- (Updated June 5, 2015, 8:18 p.m.) Review request for mesos, haosdent huang and

Re: Review Request 35150: Add output stream operation for handle to use in port_mapping.cpp

2015-06-05 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35150/#review86845 --- Ship it! Ship It! - Chi Zhang On June 5, 2015, 8:30 p.m., Paul

Re: Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118/#review86850 --- src/master/master.cpp

Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

2015-06-05 Thread Ben Mahler
On June 5, 2015, 6:24 a.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [34968, 34969, 34970] Failed command: ./support/apply-review.sh -n -r 34970 Error: 2015-06-05 06:24:06 URL:https://reviews.apache.org/r/34970/diff/raw/ [16370/16370] - 34970.patch [1] error:

Review Request 35118: Made updateSlave() update its 'totalResources'.

2015-06-05 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35118/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2776

Re: Review Request 35119: Introduced metrics for revocable resources.

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35119/#review86851 --- Ship it! src/master/metrics.hpp

Re: Review Request 34943: Added validation to flags.

2015-06-05 Thread Marco Massenzio
On June 2, 2015, 3:38 p.m., Marco Massenzio wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp, line 184 https://reviews.apache.org/r/34943/diff/1/?file=976658#file976658line184 too much choice, IMO - there are (if I counted them right) 8 different `add()`

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/ --- (Updated June 5, 2015, 11:55 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 35131: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35131/#review86869 --- Ship it! Ship It! - Joerg Schad On June 5, 2015, 1:20 p.m.,

Review Request 35165: Extend fq_codel to allow parent and handle to be specified at runtime.

2015-06-05 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35165/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 35157: Added unit tests for fetching ResoruceUsage in both QoS Controller and Resource Estimator .

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/#review86882 --- Patch looks great! Reviews applied: [35164, 35157] All tests

Re: Review Request 35119: Introduced metrics for revocable resources.

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35119/#review86853 --- Patch looks great! Reviews applied: [35118, 35119] All tests

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/#review86856 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 35131: Replaced os::dirname and os::basename with Path::dirname and Path::basename.

2015-06-05 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35131/#review86864 --- Ship it! Ship It! - Vinod Kone On June 5, 2015, 1:20 p.m., Till

Re: Review Request 35150: Add output stream operation for handle to use in port_mapping.cpp

2015-06-05 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35150/ --- (Updated June 5, 2015, 11:33 p.m.) Review request for mesos, Chi Zhang, Ian

Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor.

2015-06-05 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35164/ --- Review request for mesos, Jie Yu, Niklas Nielsen, Szymon Konefal, and Vinod

Re: Review Request 35157: Added test for ResourceEstimator fetching ResoruceUsage from ResourceMonitor.

2015-06-05 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/#review86859 --- Above ReviewBot message refers to the initial patch before

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/#review86870 --- src/slave/containerizer/isolators/network/port_mapping.cpp

Re: Review Request 35157: Added test for ResourceEstimator fetching ResoruceUsage from ResourceMonitor.

2015-06-05 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/ --- (Updated June 5, 2015, 10:52 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 35157: Added unit tests for fetching ResoruceUsage in both QoS Controller and Resource Estimator .

2015-06-05 Thread Bartek Plotka
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/ --- (Updated June 5, 2015, 11:53 p.m.) Review request for mesos, Ben Mahler, Jie

Re: Review Request 34894: Add new message for Traffic Control statistics

2015-06-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34894/#review86860 --- Ship it! LGTM. I'll wait for Ian's shipit. - Jie Yu On June 3,

Re: Review Request 35150: Add output stream operation for handle to use in port_mapping.cpp

2015-06-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35150/#review86861 --- Ship it! src/linux/routing/handle.hpp

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-05 Thread Vinod Kone
On June 5, 2015, 6:42 p.m., Vinod Kone wrote: I made some minor comments below but I think a better way to do this is to *not* write custom masterinfo json - protobuf converters. I prefer we just add a new optional field (say ipAddress of type string). Then you can just leverage the

Re: Review Request 35152: Document and consolidate qdisc handles

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35152/#review86867 --- Patch looks great! Reviews applied: [35150, 35152] All tests

Re: Review Request 35165: Extend fq_codel to allow parent and handle to be specified at runtime.

2015-06-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35165/#review86894 --- Patch looks great! Reviews applied: [35150, 35152, 35165] All

Re: Review Request 30774: Fetcher Cache

2015-06-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/#review86871 --- Just took a cursory glance since this is a huge diff, could it have

Re: Review Request 34970: Cleaned up and generalized NoExecutorScheduler to be more configurable.

2015-06-05 Thread Ben Mahler
On June 5, 2015, 9:37 p.m., Vinod Kone wrote: src/examples/no_executor_framework.cpp, line 219 https://reviews.apache.org/r/34970/diff/2/?file=979734#file979734line219 LOG(FATAL)? because this is not possible with a command executor? Sure, this was to stay consistent with the other

Re: Review Request 34943: Added validation to flags.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/ --- (Updated June 5, 2015, 2:48 p.m.) Review request for mesos. Repository:

Re: Review Request 34943: Added validation to flags.

2015-06-05 Thread Benjamin Hindman
On June 2, 2015, 3:38 p.m., Marco Massenzio wrote: 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp, lines 514-517 https://reviews.apache.org/r/34943/diff/1/?file=976659#file976659line514 I'll admit I'm still a bith hazy about the new { } initializer, but could have this

Re: Review Request 33295: Added firewall mechanism to control access on libprocess http endpoints.

2015-06-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33295/#review86800 --- Ship it! 3rdparty/libprocess/include/process/firewall.hpp

Re: Review Request 34943: Added validation to flags.

2015-06-05 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/ --- (Updated June 5, 2015, 2:48 p.m.) Review request for mesos. Changes ---

Re: Review Request 34944: Used flags validation to handle --help.

2015-06-05 Thread Benjamin Hindman
On June 2, 2015, 3:54 p.m., Marco Massenzio wrote: Sweet! Only comment is that this does not give the client of FlagsBase an option as to the behavior of --help (ie, it prints and exit: like it or lump it :). Which is perfectly fine, IMO, but was wondering whether this was too