Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-11 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review87550 --- 3rdparty/libprocess/include/process/time.hpp

Review Request 35350: Fixes markdown of the Doxygen Styleguide to provide better rendering.

2015-06-11 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35350/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Joerg Schad.

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-11 Thread Michael Park
On June 11, 2015, 11:10 a.m., Michael Park wrote: 3rdparty/libprocess/include/process/time.hpp, lines 111-114 https://reviews.apache.org/r/34703/diff/4/?file=980765#file980765line111 Formatting: ```static const char* WEEK_DAYS[] = { Sun, Mon, Tue, Wed, Thu,

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-11 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34703/#review87543 --- Can we also introduce a corresponding `.cpp` for the

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

2015-06-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34976/#review87539 --- Sorry it took me so long to get back to this. I just had a few

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

2015-06-11 Thread Adam B
On June 11, 2015, 3:02 a.m., Adam B wrote: Sorry it took me so long to get back to this. I just had a few minor comments/questions, but you ought to get a Mac user to verify the OSX instructions. Also, for doc changes like this, it's helpful if you can post a link to a personal

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 11, 2015, 9:27 a.m.) Review request for Benjamin Hindman and

Re: Review Request 28763: Add configure flag to enable SSL.

2015-06-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28763/ --- (Updated June 11, 2015, 9:26 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 29406: Introduce libevent ssl socket.

2015-06-11 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29406/ --- (Updated June 11, 2015, 2:57 p.m.) Review request for Benjamin Hindman and

Re: Review Request 35361: Added doc for standalone to HA

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35361/#review87570 --- Patch looks great! Reviews applied: [35361] All tests passed. -

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87571 --- include/mesos/mesos.proto

Re: Review Request 34943: Added validation to flags.

2015-06-11 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/#review87573 --- 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 35341: Added Uber to the Powered-by-Mesos page

2015-06-11 Thread Niklas Nielsen
On June 10, 2015, 7:48 p.m., Niklas Nielsen wrote: docs/powered-by-mesos.md, line 91 https://reviews.apache.org/r/35341/diff/1/?file=982409#file982409line91 35341.patch:17: new blank line at EOF. + warning: 1 line adds whitespace errors. Mind fixing this,

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-11 Thread Vinod Kone
On June 11, 2015, 4:18 p.m., Niklas Nielsen wrote: include/mesos/mesos.proto, line 626 https://reviews.apache.org/r/35260/diff/3/?file=982288#file982288line626 I just thought of one thing - this represents the entire container and not the executor alone. Does it make sense to

Re: Review Request 34687: (De)Serializing MasterInfo PB to JSON

2015-06-11 Thread Niklas Nielsen
On June 10, 2015, 8:37 p.m., Ben Mahler wrote: How about adding an 'Address' message, which can contain 'ip' and 'port' for now? ``` message Address { required string ip; required uint32 port; // Later we can add 'hostname' or 'public_hostname', etc! } ```

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-11 Thread Jie Yu
On June 11, 2015, 4:18 p.m., Niklas Nielsen wrote: include/mesos/mesos.proto, line 626 https://reviews.apache.org/r/35260/diff/3/?file=982288#file982288line626 I just thought of one thing - this represents the entire container and not the executor alone. Does it make sense to

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-11 Thread Vinod Kone
On June 11, 2015, 4:18 p.m., Niklas Nielsen wrote: include/mesos/mesos.proto, line 626 https://reviews.apache.org/r/35260/diff/3/?file=982288#file982288line626 I just thought of one thing - this represents the entire container and not the executor alone. Does it make sense to

Re: Review Request 35157: Added unit tests for fetching ResourceUsage in both QoS Controller and Resource Estimator .

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/#review87587 --- src/common/type_utils.cpp

Re: Review Request 35321: Implemented the fixed resource estimator.

2015-06-11 Thread Jie Yu
On June 11, 2015, 1:07 a.m., Ben Mahler wrote: src/tests/oversubscription_tests.cpp, lines 404-406 https://reviews.apache.org/r/35321/diff/1/?file=982246#file982246line404 s/since the FixedResourcesEstimator is used// and maybe wrap to reduce jaggedness?

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35260/#review87592 --- Ship it! include/mesos/mesos.proto

Re: Review Request 35260: Refactored the ResourceMonitor to get statistics from the Slave.

2015-06-11 Thread Jie Yu
On June 11, 2015, 6:12 p.m., Niklas Nielsen wrote: src/slave/monitor.cpp, line 23 https://reviews.apache.org/r/35260/diff/3/?file=982291#file982291line23 C-style headers should be before C++ - take a look at zookeeper.cpp I think glog/logging.h is a C++ header (google never uses

Re: Review Request 35264: Added a slave integration test in MonitorTest.

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35264/#review87599 --- Ship it! src/tests/monitor_tests.cpp

Re: Review Request 35264: Added a slave integration test in MonitorTest.

2015-06-11 Thread Jie Yu
On June 11, 2015, 6:40 p.m., Niklas Nielsen wrote: src/tests/monitor_tests.cpp, line 22 https://reviews.apache.org/r/35264/diff/3/?file=982299#file982299line22 C-style include before C++ includes :) This is a C++ header:) - Jie

Re: Review Request 35280: Added Test QoS Controller module

2015-06-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35280/#review87601 --- Ship it! src/examples/test_qos_controller_module.cpp

Re: Review Request 35333: Small fix in updateSlave() to make resource math clearer.

2015-06-11 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35333/#review87603 --- Ship it! Thanks for following up! - Ben Mahler On June 11,

Re: Review Request 35281: Added QoS module loader to ::create() factory.

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35281/ --- (Updated June 11, 2015, 11:55 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 35280: Added Test QoS Controller module

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35280/ --- (Updated June 11, 2015, 11:55 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 35279: Added QoS Controller module

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35279/ --- (Updated June 11, 2015, 11:55 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 35278: Added missing flag initialization for qos controller.

2015-06-11 Thread Niklas Nielsen
On June 10, 2015, 6:32 a.m., Bartek Plotka wrote: src/slave/flags.cpp, line 519 https://reviews.apache.org/r/35278/diff/1/?file=981788#file981788line519 Could you change s/resource estimator/Resource Estimator/ to be compliant with QoS Controller name? If you are Upper casing

Re: Review Request 35281: Added QoS module loader to ::create() factory.

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35281/#review87610 --- Patch looks great! Reviews applied: [35278, 35279, 35280, 35281]

Re: Review Request 35157: Added unit tests for fetching ResourceUsage in both QoS Controller and Resource Estimator .

2015-06-11 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/#review87609 --- src/common/type_utils.cpp

Re: Review Request 34128: Enable different IP/Port for external access.

2015-06-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34128/#review87611 --- 3rdparty/libprocess/src/process.cpp

Re: Review Request 35157: Added unit tests for fetching ResourceUsage in both QoS Controller and Resource Estimator .

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35157/#review87613 --- Bad patch! Reviews applied: [35164, 35157] Failed command:

Re: Review Request 35247: Fixed race between EXPECT_CALL(resourceOffers, _) and driver.start() in fetcher_cache_tests.cpp.

2015-06-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35247/#review87616 --- I'll commit this for now with the reordering fix. Please follow up

Re: Review Request 34943: Added validation to flags.

2015-06-11 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/ --- (Updated June 11, 2015, 1:52 p.m.) Review request for mesos. Repository:

Re: Review Request 35350: Fixes markdown of the Doxygen Styleguide to provide better rendering.

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35350/#review87556 --- Patch looks great! Reviews applied: [35350] All tests passed. -

Re: Review Request 33208: Delete detector in MesosSchedulerDriver::stop

2015-06-11 Thread Niklas Nielsen
On April 19, 2015, 10:55 p.m., Adam B wrote: LGTM, barring a question about ordering/synchronization. I'll let another committer take a look before we commit it. Adam B wrote: Would also like to see a successful ReviewBot pass. That MasterFailover segfault seems like it could be

Re: Review Request 35350: Fixes markdown of the Doxygen Styleguide to provide better rendering.

2015-06-11 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35350/#review87623 --- This should be covered by https://reviews.apache.org/r/35364/. -

Re: Review Request 35367: Changed Resourcs JSON model() to combine non-revocable resources and ignore revocable resources.

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35367/#review87624 --- Patch looks great! Reviews applied: [35367] All tests passed. -

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-11 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/ --- (Updated June 11, 2015, 9:39 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-11 Thread Niklas Nielsen
On June 9, 2015, 6:25 p.m., Ben Mahler wrote: src/tests/master_tests.cpp, lines 3031-3034 https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031 Why bother with all this? Why not just have `key1`, `value1`, `key2`, `value2` inlined appropriately throughout

Re: Review Request 35367: Changed Resourcs JSON model() to combine non-revocable resources and ignore revocable resources.

2015-06-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35367/#review87649 --- src/common/http.cpp

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/ --- (Updated June 11, 2015, 3:58 p.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34720: Added kill executor correction to slave.

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34720/ --- (Updated June 11, 2015, 3:58 p.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 34719: Added QOS_KILLED as status reason

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34719/ --- (Updated June 11, 2015, 3:58 p.m.) Review request for mesos, Bartek Plotka,

Re: Review Request 35363: Improvements on libprocess/README.md.

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35363/#review87641 --- Patch looks great! Reviews applied: [35363] All tests passed. -

Re: Review Request 35330: Capped number of parallel inspect instances on a docker ps call.

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35330/#review87645 --- Patch looks great! Reviews applied: [35330] All tests passed. -

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-06-11 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/ --- (Updated June 11, 2015, 10:51 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 31915: MemIsolator: Improved some statistics naming. (MESOS-2104)

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31915/#review87655 --- Patch looks great! Reviews applied: [31914, 31915] All tests

Re: Review Request 35164: Added callback to the QoS Controller to retrieve usages from the monitor.

2015-06-11 Thread Bartek Plotka
On June 9, 2015, 12:34 a.m., Jie Yu wrote: I think the interface of getting resource usage is going to change per discussion here: https://issues.apache.org/jira/browse/MESOS-2818 Niklas Nielsen wrote: The new proposal doesn't mention changing the callback, does it? Jie Yu

Re: Review Request 35367: Changed Resourcs JSON model() to combine non-revocable resources and ignore revocable resources.

2015-06-11 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35367/#review87662 --- Ship it! Ship It! - Vinod Kone On June 12, 2015, 12:32 a.m.,

Re: Review Request 13620: Fix the Allocator to recover resources when a slave/framework is removed

2015-06-11 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13620/#review87671 --- Ben; is this still relevant? - Niklas Nielsen On Aug. 19, 2013,

Re: Review Request 35367: Changed Resourcs JSON model() to combine non-revocable resources and ignore revocable resources.

2015-06-11 Thread Jiang Yan Xu
On June 11, 2015, 4:36 p.m., Vinod Kone wrote: src/tests/common/http_tests.cpp, line 127 https://reviews.apache.org/r/35367/diff/1/?file=983104#file983104line127 camelcase? Wrote too much Python lately. - Jiang Yan ---

Re: Review Request 35367: Changed Resourcs JSON model() to combine non-revocable resources and ignore revocable resources.

2015-06-11 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35367/ --- (Updated June 11, 2015, 5:32 p.m.) Review request for mesos, Niklas Nielsen

Re: Review Request 34976: Added installation instructions for Ubuntu 14.04 and OSX

2015-06-11 Thread Marco Massenzio
On June 11, 2015, 10:02 a.m., Adam B wrote: docs/getting-started.md, line 39 https://reviews.apache.org/r/34976/diff/2/?file=977278#file977278line39 What about these python packages? Probably still necessary if you don't `configure --disable-python`. they are there - a few lines

Re: Review Request 34721: Added QoS kill executor correction test.

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34721/#review87663 --- Patch looks great! Reviews applied: [35079, 34631, 34632, 34633,

Re: Review Request 13620: Fix the Allocator to recover resources when a slave/framework is removed

2015-06-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13620/#review87673 --- Bad patch! Reviews applied: [13620] Failed command:

Re: Review Request 34703: Added stream manipulators for the Time object.

2015-06-11 Thread Alexander Rojas
On June 8, 2015, 2:59 p.m., Till Toenshoff wrote: 3rdparty/libprocess/include/process/time.hpp, line 150 https://reviews.apache.org/r/34703/diff/3/?file=974298#file974298line150 Lets think about a good replacement for that class name to make it intuitive - first thing that came

Re: Review Request 34361: converted hard-coded strings to consts

2015-06-11 Thread Colin Williams
On June 10, 2015, 1:25 a.m., Ben Mahler wrote: src/tests/master_tests.cpp, lines 3031-3034 https://reviews.apache.org/r/34361/diff/3/?file=971359#file971359line3031 Why bother with all this? Why not just have `key1`, `value1`, `key2`, `value2` inlined appropriately throughout