---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/
---
Review request for mesos, Marco Massenzio and Vinod Kone.
Bugs: MESOS-2900
On June 1, 2015, 4:32 p.m., Marco Massenzio wrote:
This is great -sorry it took so long to get to do a review.
Thanks for doing it, I'm quite looking forward to using it to learning more
about the Persistent Framework :)
it would be great if we could have a bit more comments in the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35506/#review88638
---
Ship it!
Ship It!
- Adam B
On June 16, 2015, 4:24 a.m.,
On June 14, 2015, 10:46 a.m., Benjamin Hindman wrote:
Just so I understand, does this mean if we happen to get in the unfortunate
situation where a slave has neglected to get the dynamic reservation
because it was just starting up and then it gets the task launch it will
shutdown the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review88640
---
src/master/http.cpp (line 124)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35583/#review88637
---
Ship it!
Ship It!
- Adam B
On June 17, 2015, 3:42 p.m., Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31838/#review88636
---
Ship it!
LGTM, although I agree with Alex that you could clean up
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35583/#review88641
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 17, 2015, 10:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35686/#review88635
---
Ship it!
Ship It!
- Alexander Rukletsov
On June 20, 2015, 4:42
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35335/#review88642
---
Patch looks great!
Reviews applied: [35335]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated June 20, 2015, 4:19 p.m.)
Review request for mesos and Joris Van
On June 18, 2015, 7:44 p.m., Joris Van Remoortere wrote:
Hey Mark,
Can you make the dependency chain purely linear so the reviewbot can apply
the patches correctly and build / run the tests?
`35287-35286-35285`
I submit a new review without any change then I try to discard the draft,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35285/
---
(Updated June 20, 2015, 4:49 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/
---
(Updated June 20, 2015, 4:48 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35286/
---
(Updated June 20, 2015, 4:47 p.m.)
Review request for mesos and Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35682/#review88660
---
Patch looks great!
Reviews applied: [35679, 35680, 35682]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated June 20, 2015, 8:19 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/
---
(Updated June 20, 2015, 7:06 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35687/#review88666
---
Patch looks great!
Reviews applied: [35687]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/
---
Review request for mesos and Ben Mahler.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35686/#review88663
---
Patch looks great!
Reviews applied: [35686]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35694/#review88661
---
Why do we use different approaches (emplace() and insert()) in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35565/
---
(Updated June 20, 2015, 7:01 p.m.)
Review request for mesos and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/
---
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35696/
---
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35697/
---
Review request for mesos, Benjamin Hindman and Till Toenshoff.
Repository:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35565/#review88681
---
Ship it!
Ship It!
- Marco Massenzio
On June 20, 2015, 7:01
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35695/#review88680
---
Ship it!
Ship It!
- Marco Massenzio
On June 20, 2015, 7:14
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35699/#review88684
---
Patch looks great!
Reviews applied: [35699]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/#review88686
---
Patch looks great!
Reviews applied: [35702]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35697/#review88682
---
Patch looks great!
Reviews applied: [35697]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35701/#review88685
---
Patch looks great!
Reviews applied: [35701]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35287/#review88668
---
Bad patch!
Reviews applied: [35285, 35286, 35287]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35567/#review88669
---
Bad patch!
Reviews applied: [35561, 35562, 35563, 35564]
Failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35696/#review88675
---
Patch looks great!
Reviews applied: [35696]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35611/#review88667
---
Bad patch!
Reviews applied: [35611]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35703/#review88687
---
Patch looks great!
Reviews applied: [35703]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/
---
(Updated June 21, 2015, 5:17 a.m.)
Review request for mesos, Adam B, Jie Yu,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9/
---
(Updated June 21, 2015, 5:37 a.m.)
Review request for mesos, Adam B, Jie Yu,
On June 1, 2015, 11:32 p.m., Marco Massenzio wrote:
src/examples/java/TestPersistentVolumeFramework.java, line 239
https://reviews.apache.org/r/9/diff/10/?file=941652#file941652line239
unless I'm mistaken and this is a unit test (is it?) can we please
rename this class in a
41 matches
Mail list logo