Re: Review Request 34137: Add support for container image provisioners.

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/ --- (Updated June 22, 2015, 9:44 a.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34908/ --- (Updated June 22, 2015, 9:55 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 34141: AppC provsioning backend.

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34141/ --- (Updated June 22, 2015, 9:53 a.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review88811 --- Patch looks great! Reviews applied: [32891, 32978, 31444] All

Re: Review Request 34140: AppC image store

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34140/ --- (Updated June 22, 2015, 9:51 a.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 35033: Define potentially missing MS_* mount flags.

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35033/ --- (Updated June 22, 2015, 9:51 a.m.) Review request for mesos, Jie Yu and Vinod

Re: Review Request 32891: Support for entering and configuring a Linux chroot.

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32891/ --- (Updated June 22, 2015, 9:38 a.m.) Review request for mesos, Chi Zhang, Jay

Re: Review Request 34142: AppC provisioner.

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34142/ --- (Updated June 22, 2015, 9:57 a.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 35686: Change the if statement to a CHECK at the end of _runTask.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35686/#review88812 --- Ship it! Ship It! - Jie Yu On June 20, 2015, 4:42 a.m., Michael

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-22 Thread Michael Park
On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: src/master/http.cpp, lines 519-520 https://reviews.apache.org/r/35702/diff/6/?file=989447#file989447line519 Some food for thought here. I think the ultimate decision whether to grant a request or not, should be taken by the

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/ --- (Updated June 22, 2015, 9:41 a.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 34139: AppC image discovery.

2015-06-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34139/ --- (Updated June 22, 2015, 9:54 a.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 35695: stout: Fixed test names.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35695/#review88810 --- Ship it! Ship It! - Till Toenshoff On June 20, 2015, 7:14 p.m.,

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31444/#review88814 --- src/tests/launch_tests.cpp (lines 118 - 120)

Re: Review Request 35697: mesos: Fixed test names.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35697/#review88808 --- Ship it! Thanks a bunch for these. - Till Toenshoff On June 20,

Re: Review Request 35703: Set refuse seconds on the correct filter in reservation test.

2015-06-22 Thread Michael Park
On June 22, 2015, 2:13 p.m., Alexander Rukletsov wrote: Looks like a copy-paste bug. How have you found it? Was the test flaky? I was using these tests as a reference for writing my new tests for [r35702](https://reviews.apache.org/r/35702/) and noticed it. - Michael

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-22 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/ --- (Updated June 22, 2015, 7:46 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35562: Removed unnecessary use of os::ExecEnv.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35562/#review88788 --- Ship it! Ship It! - Till Toenshoff On June 17, 2015, 2:28 p.m.,

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-22 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/ --- (Updated June 22, 2015, 7:57 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 35438: Fixed fetcher cache test race for resource offers when starting tasks and changed corresponding CHECK to EXPECT.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35438/#review88789 --- Patch looks great! Reviews applied: [35438] All tests passed. -

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
On June 18, 2015, 6:08 p.m., Niklas Nielsen wrote: A few high level comments: 1) Let's use an enum instead of an unstructured int to encode the namespaces 2) Let's get a test wired up 3) Think about Mac compatibility while introducing the enum :) - Added an enum that is protected by

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/ --- (Updated June 22, 2015, 1:56 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35697: mesos: Fixed test names.

2015-06-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35697/#review88840 --- Ship it! Thanks, will commit this for you. Also we are

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-22 Thread Michael Park
On June 22, 2015, 10:20 a.m., Alexander Rukletsov wrote: Before making a thorough review, let's discuss one high level question. Here is the problem how I understand it: we reserve for roles, but our code works mostly with frameworks (allocator methods, Offer protobuf). To

Re: Review Request 35701: Minor formatting cleanup in the Master.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35701/#review88821 --- src/master/master.cpp (lines 972 - 975)

Re: Review Request 35696: libprocess: Fixed test names.

2015-06-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35696/#review88834 --- Ship it! I'll get this committed for you, one other inconsistency

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

2015-06-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35714/#review88839 --- Adding this seems good since it's agnostic to how it is used. But

Re: Review Request 35744: Cleaned up the unknown orphans after all known orphans are recovered.

2015-06-22 Thread Jie Yu
On June 22, 2015, 9:37 p.m., Chi Zhang wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1886-1889 https://reviews.apache.org/r/35744/diff/1/?file=989925#file989925line1886 If we have 0 known orphans, 3 unknown orphans, we'd try to delete ICMP and ARP 3

Re: Review Request 35701: Minor formatting cleanup in the Master.

2015-06-22 Thread Ben Mahler
On June 22, 2015, 6:26 p.m., Till Toenshoff wrote: src/master/master.cpp, lines 972-975 https://reviews.apache.org/r/35701/diff/1/?file=989004#file989004line972 I understand this was updated due to some discussions on related RRs. I would however love to see the definitive answer

Re: Review Request 35714: Added a new HTTP response type: PreconditionFailed.

2015-06-22 Thread Michael Park
On June 22, 2015, 8:04 p.m., Ben Mahler wrote: Adding this seems good since it's agnostic to how it is used. But for reservations specifically, any reason not to use just BadRequest? From what I can tell, this is generally used for conditional requests (based on headers or some

Review Request 35744: Cleaned up the unknown orphans after all known orphans are recovered.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35744/ --- Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Bugs:

Re: Review Request 35701: Minor formatting cleanup in the Master.

2015-06-22 Thread Till Toenshoff
On June 22, 2015, 6:26 p.m., Till Toenshoff wrote: src/master/master.cpp, lines 972-975 https://reviews.apache.org/r/35701/diff/1/?file=989004#file989004line972 I understand this was updated due to some discussions on related RRs. I would however love to see the definitive answer

Re: Review Request 35743: flags: fixed const'ness of load

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/#review88862 --- Patch looks great! Reviews applied: [35743] All tests passed. -

Re: Review Request 35744: Cleaned up the unknown orphans after all known orphans are recovered.

2015-06-22 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35744/#review88855 --- Ship it! Ship It! - Chi Zhang On June 22, 2015, 9:58 p.m., Jie

Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.

2015-06-22 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/#review88875 --- Ship it! let us definitely improve the info pointer management,

Re: Review Request 35701: Minor formatting cleanup in the Master.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35701/#review7 --- Ship it! Ship It! - Till Toenshoff On June 20, 2015, 8 p.m.,

Re: Review Request 35701: Minor formatting cleanup in the Master.

2015-06-22 Thread Till Toenshoff
On June 22, 2015, 6:26 p.m., Till Toenshoff wrote: src/master/master.cpp, lines 972-975 https://reviews.apache.org/r/35701/diff/1/?file=989004#file989004line972 I understand this was updated due to some discussions on related RRs. I would however love to see the definitive answer

Re: Review Request 35738: Add slave metric to count container launch failures.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35738/#review88892 --- Patch looks great! Reviews applied: [35738] All tests passed. -

Re: Review Request 35701: Minor formatting cleanup in the Master.

2015-06-22 Thread Michael Park
On June 22, 2015, 6:26 p.m., Till Toenshoff wrote: src/master/master.cpp, lines 972-975 https://reviews.apache.org/r/35701/diff/1/?file=989004#file989004line972 I understand this was updated due to some discussions on related RRs. I would however love to see the definitive answer

Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/ --- (Updated June 22, 2015, 11:29 p.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 35697: mesos: Fixed test names.

2015-06-22 Thread Michael Park
On June 22, 2015, 8:12 p.m., Ben Mahler wrote: Thanks, will commit this for you. Also we are inconcistent on the Test suffix, e.g. MasterTest vs CRAMMD5Authentication. See two options: (1) We can use Test to signify that there is a fixture, if that's helpful. So remove any

Re: Review Request 35750: Added a test to verify recovering mixed known and unknown orphans for port mapping isolator.

2015-06-22 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35750/#review0 --- Ship it! It's not very clean to reply on `___recover`'s

Review Request 35756: Fixed a race condition in hook tests for remove-executor hook.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35756/ --- Review request for mesos and Niklas Nielsen. Bugs: MESOS-2226

Re: Review Request 35743: flags: fixed const'ness of load

2015-06-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/#review88852 --- Ship it! 3rdparty/libprocess/3rdparty/stout/tests/flags_tests.cpp

Re: Review Request 35738: Add slave metric to count container launch failures.

2015-06-22 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35738/#review88868 --- Ship it! Ship It! - Chi Zhang On June 22, 2015, 7:26 p.m., Paul

Review Request 35749: Fixed a memory bug in port mapping recovery logic.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/ --- Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Bugs:

Review Request 35750: Added a test to verify recovering mixed known and unknown orphans for port mapping isolator.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35750/ --- Review request for mesos, Chi Zhang, Paul Brett, and Vinod Kone. Bugs:

Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.

2015-06-22 Thread Jie Yu
On June 22, 2015, 11:19 p.m., Chi Zhang wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1905-1909 https://reviews.apache.org/r/35749/diff/1/?file=989997#file989997line1905 Do we need another for loop here to clean up unknownOrphans like you did above?

Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.

2015-06-22 Thread Jie Yu
On June 22, 2015, 11:33 p.m., Chi Zhang wrote: let us definitely improve the info pointer management, there is 7 'delete info' in this file right now... :( Yeah, I'll follow up with patches. - Jie --- This is an automatically

Re: Review Request 35715: Added revocable resource state validation.

2015-06-22 Thread Jie Yu
On June 21, 2015, 6:47 p.m., Vinod Kone wrote: src/common/resources.cpp, lines 479-487 https://reviews.apache.org/r/35715/diff/1/?file=989223#file989223line479 These checks are done in master's validation.cpp Michael Park wrote: Ah sorry, I missed that. This

Re: Review Request 35738: Add slave metric to count container launch failures.

2015-06-22 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35738/ --- (Updated June 23, 2015, 12:42 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 35744: Cleaned up the unknown orphans after all known orphans are recovered.

2015-06-22 Thread Jie Yu
On June 22, 2015, 9:37 p.m., Chi Zhang wrote: src/slave/containerizer/isolators/network/port_mapping.cpp, lines 1886-1889 https://reviews.apache.org/r/35744/diff/1/?file=989925#file989925line1886 If we have 0 known orphans, 3 unknown orphans, we'd try to delete ICMP and ARP 3

Re: Review Request 35744: Cleaned up the unknown orphans after all known orphans are recovered.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35744/ --- (Updated June 22, 2015, 9:58 p.m.) Review request for mesos, Chi Zhang, Paul

Re: Review Request 35749: Fixed a memory bug in port mapping recovery logic.

2015-06-22 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35749/#review88871 --- src/slave/containerizer/isolators/network/port_mapping.cpp (lines

Re: Review Request 35567: Added 'executor_environment_variables' flag to slave.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35567/#review88780 --- Ship it! src/slave/flags.cpp (line 28)

Review Request 35722: Really removed stout/memory.hpp from stout.

2015-06-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35722/ --- Review request for mesos, Benjamin Hindman and Till Toenshoff. Bugs:

Re: Review Request 35722: Really removed stout/memory.hpp from stout.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35722/#review88741 --- Patch looks great! Reviews applied: [35722] All tests passed. -

Re: Review Request 35717: Add reservations support to master's state.json

2015-06-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35717/ --- (Updated June 22, 2015, 11:37 a.m.) Review request for mesos, Adam B and

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/#review88761 --- Patch looks great! Reviews applied: [29507] All tests passed. -

Re: Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- (Updated June 22, 2015, 11:34 a.m.) Review request for mesos and Adam B.

Review Request 35728: Fix failing test: SlaveTest.ROOT_RunTaskWithCommandInfoWithUser.

2015-06-22 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35728/ --- Review request for mesos and Adam B. Repository: mesos Description ---

Re: Review Request 33564: stout: Removed stout/memory.hpp and switched from 'memory::' to 'std::'.

2015-06-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33564/#review88750 --- Follow up in order to remove stout/memory.hpp:

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-06-22 Thread Adam B
On June 1, 2015, 1:15 p.m., Niklas Nielsen wrote: LGTM - Would it make sense to have sane min/max values for the timeouts/counts? I wonder it would make sense to have a test to exercise an upgrade path (the timeout being different in the slaves, than in the master). Maybe I

Re: Review Request 29507: Added Configurable Slave Ping Timeouts

2015-06-22 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29507/ --- (Updated June 22, 2015, 3:03 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 35702: [WIP] Added /reserve HTTP endpoint to the master.

2015-06-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review88760 --- Before making a thorough review, let's discuss one high level

Re: Review Request 35738: Add slave metric to count container launch failures.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35738/#review88844 --- Patch looks great! Reviews applied: [35738] All tests passed. -

Review Request 35743: flags: fixed const'ness of load

2015-06-22 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35743/ --- Review request for mesos, Benjamin Hindman and Till Toenshoff. Repository:

Re: Review Request 35699: Added an invariant CHECK_EQ for available resources in HierarchicalAllocator::updateAllocation.

2015-06-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35699/#review88836 --- Ship it! Thanks for taking care of this! - Ben Mahler On June

Re: Review Request 35033: Define potentially missing MS_* mount flags.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35033/#review88822 --- Patch looks great! Reviews applied: [35033] All tests passed. -

Re: Review Request 34128: Enable different IP/Port for external access.

2015-06-22 Thread Anindya Sinha
On June 11, 2015, 7:34 p.m., Vinod Kone wrote: 3rdparty/libprocess/src/process.cpp, lines 820-836 https://reviews.apache.org/r/34128/diff/2/?file=963212#file963212line820 If two libprocess based unix processes (e.g., scheudler and master) are within the *same* bridged container,

Re: Review Request 35695: stout: Fixed test names.

2015-06-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35695/#review88841 --- Ship it! Thanks, will commit this for you. Ditto the previous

Re: Review Request 34128: Enable different IP/Port for external access.

2015-06-22 Thread Anindya Sinha
On June 11, 2015, 7:34 p.m., Vinod Kone wrote: 3rdparty/libprocess/src/process.cpp, lines 820-836 https://reviews.apache.org/r/34128/diff/2/?file=963212#file963212line820 If two libprocess based unix processes (e.g., scheudler and master) are within the *same* bridged container,

Re: Review Request 34128: Enable different IP/Port for external access.

2015-06-22 Thread Vinod Kone
On June 11, 2015, 7:34 p.m., Vinod Kone wrote: 3rdparty/libprocess/src/process.cpp, lines 820-836 https://reviews.apache.org/r/34128/diff/2/?file=963212#file963212line820 If two libprocess based unix processes (e.g., scheudler and master) are within the *same* bridged container,

Re: Review Request 34908: Rename --docker_sandbox_directory flag for general use.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34908/#review88833 --- Patch looks great! Reviews applied: [34908] All tests passed. -

Review Request 35738: Add slave metric to count container launch failures.

2015-06-22 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35738/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/#review88910 --- Patch looks great! Reviews applied: [35585, 35586] All tests

Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35763/#review88915 --- Patch looks great! Reviews applied: [35763] All tests passed. -

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review88919 --- Ship it! include/mesos/slave/isolator.hpp (lines 78 - 104)

Re: Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35762/ --- (Updated June 22, 2015, 10:41 p.m.) Review request for mesos and Jie Yu.

Review Request 35763: Document workaround for LIBNL_CFLAGS path

2015-06-22 Thread Roger Ignazio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35763/ --- Review request for mesos. Bugs: MESOS-1856

Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35762/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 35765: Updated network-monitoring docs to reflect correct libnl version.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35765/#review88912 --- Ship it! Ship It! - Till Toenshoff On June 23, 2015, 3:09 a.m.,

Review Request 35765: Updated network-monitoring docs to reflect correct libnl version.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35765/ --- Review request for mesos and Jie Yu. Bugs: MESOS-2917

Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 22, 2015, 10:21 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/#review88902 --- Hum, I don't see any change from r2 to r3? Did you upload the

Re: Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35762/#review88906 --- Ship it! Ship It! - Till Toenshoff On June 23, 2015, 2:41 a.m.,

Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 22, 2015, 10:48 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
On June 22, 2015, 10:23 p.m., Jie Yu wrote: Hum, I don't see any change from r2 to r3? Did you upload the correct diff? I accidentally committed the diffs into the dependent RR. Fixed now. Thanks! :) - Kapil --- This is an

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/ --- (Updated June 22, 2015, 10:48 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35762/ --- (Updated June 22, 2015, 11:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35762/#review88918 --- Ship it! Ship It! - Jie Yu On June 23, 2015, 3:05 a.m., Kapil

Re: Review Request 35765: Updated network-monitoring docs to reflect correct libnl version.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35765/#review88921 --- Patch looks great! Reviews applied: [35585, 35586, 35762, 35765]

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/ --- (Updated June 22, 2015, 10:20 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35762: Updated libnl configure check to reflect correct requirements.

2015-06-22 Thread Till Toenshoff
On June 23, 2015, 2:47 a.m., Till Toenshoff wrote: Ship It! As discussed, another RR updating docs/network-monitoring.md would be great to keep things in sync. - Till --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 35765: Updated network-monitoring docs to reflect correct libnl version.

2015-06-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35765/#review88917 --- Ship it! Ship It! - Jie Yu On June 23, 2015, 3:09 a.m., Kapil

Re: Review Request 35756: Fixed a race condition in hook tests for remove-executor hook.

2015-06-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35756/#review88900 --- Patch looks great! Reviews applied: [35756] All tests passed. -

Re: Review Request 35586: Updated LinuxLauncher to receive list of namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35586/ --- (Updated June 23, 2015, 12:59 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35585: Updated Isolator to return required namespaces.

2015-06-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35585/ --- (Updated June 23, 2015, 1:03 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path

2015-06-22 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35763/#review88924 --- Ship it! Thanks for this. A couple of minor formatting nits.

Re: Review Request 35763: Document workaround for LIBNL_CFLAGS path

2015-06-22 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35763/#review88925 --- Can you please add one of the committers as a reviewer? - Marco

  1   2   >