---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated June 27, 2015, 8:36 a.m.)
Review request for mesos, Adam B and Jie
On June 24, 2015, 9:30 a.m., Adam B wrote:
Looks great! We recently added validation lambdas to flag definitions, so
you may be able to take advantage of that.
We probably also want to do validation in the slave for the --resources
flag, since resources can be declared as reserved for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated June 27, 2015, 11:32 a.m.)
Review request for mesos, Adam B and Jie
On June 24, 2015, 6:34 p.m., Jie Yu wrote:
src/master/master.hpp, lines 630-651
https://reviews.apache.org/r/35711/diff/4/?file=989196#file989196line630
Can you move this function to src/master/validation.hpp|cpp
```
namespace role {
OptionError
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated June 27, 2015, 11:35 a.m.)
Review request for mesos, Adam B and Jie
On June 26, 2015, 2:30 a.m., Adam B wrote:
Nice work! So, running the command as root first will guarantee that
lt-mesos-executor exists before trying to run the task as the test-user
`nobody`? We might be able to fix this in a cleaner way, but this looks
good enough to me. Just fix
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review89627
---
src/Makefile.am (line 1489)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review89626
---
src/Makefile.am (line 362)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35728/
---
(Updated June 27, 2015, 4:37 p.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35728/
---
(Updated June 27, 2015, 4:37 p.m.)
Review request for mesos and Adam B.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35974/
---
Review request for mesos, Benjamin Hindman and Vinod Kone.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35974/#review89633
---
Ship it!
- Joerg Schad
On June 27, 2015, 7:30 p.m., Joris Van
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35974/#review89632
---
Ship it!
Ship It!
- Kapil Arya
On June 27, 2015, 3:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 28, 2015, 3:33 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35981/
---
Review request for mesos, Adam B, Jie Yu, and Timothy Chen.
Bugs: MESOS-2405
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35911/#review89651
---
Ship it!
Ship It!
- Vinod Kone
On June 27, 2015, 12:36 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 28, 2015, 3:23 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35721/
---
(Updated June 28, 2015, 5:51 a.m.)
Review request for mesos, Adam B, Jie Yu,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 28, 2015, 3:27 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32982/
---
(Updated June 28, 2015, 3:28 a.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35981/#review89655
---
Patch looks great!
Reviews applied: [32982, 35981]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35721/
---
(Updated June 28, 2015, 5:42 a.m.)
Review request for mesos, Adam B and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35721/
---
(Updated June 28, 2015, 5:46 a.m.)
Review request for mesos, Adam B and Jie
23 matches
Mail list logo
