Re: Review Request 35985: Consistent capitalization of NOTE in documentation

2015-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/#review89673 --- Patch looks great! Reviews applied: [35985] All tests passed. -

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

2015-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/#review89669 --- Patch looks great! Reviews applied: [35934, 35939, 35947, 35702,

Review Request 35985: Consistent capitalization of NOTE in documentation

2015-06-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35985/ --- Review request for mesos, Bernd Mathiske and Michael Park. Repository: mesos

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-28 Thread Joerg Schad
On June 28, 2015, 8:57 a.m., Alexander Rukletsov wrote: include/mesos/slave/isolator.hpp, line 64 https://reviews.apache.org/r/35927/diff/1/?file=993031#file993031line64 AFAIK, techinally, limitation does not necessarily end in termination, though it is so for

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-06-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated June 28, 2015, 8:35 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.

2015-06-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 28, 2015, 7:33 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 35927: Added TaskStatus::Reason to Termination Message.

2015-06-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35927/#review89667 --- include/mesos/containerizer/containerizer.proto (lines 87 - 89)

Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-06-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris

Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.

2015-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review89665 --- Patch looks great! Reviews applied: [35721] All tests passed. -

Re: Review Request 35816: Fixed the incorrect CHECK_EQ in updateAllocation.

2015-06-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35816/#review89666 --- src/tests/hierarchical_allocator_tests.cpp (line 791)

Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

2015-06-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/ --- Review request for mesos, Adam B, Benjamin Hindman, Ben Mahler, Jie Yu, Joris

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

2015-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review89676 --- Patch looks great! Reviews applied: [35986] All tests passed. -

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

2015-06-28 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/ --- (Updated June 28, 2015, 4:08 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

2015-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/#review89680 --- Patch looks great! Reviews applied: [35934, 35939, 35947, 35702,

Re: Review Request 32982: Added reservation user guide.

2015-06-28 Thread Benjamin Hindman
On May 13, 2015, 10:25 p.m., Marco Massenzio wrote: docs/reservation.md, line 71 https://reviews.apache.org/r/32982/diff/1/?file=921006#file921006line71 this seems to imply that in the Request, the `slave_id` is some part of a form submission: ``` -d, --data data

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/#review89691 --- Ship it! src/master/master.cpp (line 2242)

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-28 Thread Benjamin Hindman
On June 25, 2015, 3:57 a.m., Isabel Jimenez wrote: src/master/master.cpp, line 1654 https://reviews.apache.org/r/35855/diff/2/?file=991807#file991807line1654 could we have here consistent braces syntax with scheduler.cpp switch case? Perhaps for consistency, and safety, we just

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

2015-06-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35858/#review89696 --- Ship it! Ship It! - Benjamin Hindman On June 25, 2015, 12:31

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

2015-06-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 1:22 a.m.) Review request for mesos and Benjamin

Re: Review Request 32982: Added reservation user guide.

2015-06-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32982/#review89689 --- Ship it! I made a few minor tweaks here before committing. (1)

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

2015-06-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35857/#review89693 --- Ship it! Ship It! - Benjamin Hindman On June 25, 2015, 1:11

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

2015-06-28 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review89695 --- Ship it! Ship It! - Isabel Jimenez On June 28, 2015, 1:49 p.m.,

Re: Review Request 31207: WIP: Support for SSL and non-ssl traffic simultaneously.

2015-06-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 1 a.m.) Review request for mesos and Benjamin Hindman.

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

2015-06-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/#review89698 --- This is an incomplete review but I wanted to publish it sot that we

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

2015-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/#review89701 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529,

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

2015-06-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/#review89700 --- 3rdparty/libprocess/src/libevent_ssl_socket.cpp (line 786)

Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.

2015-06-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 29, 2015, 2:35 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.

2015-06-28 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/ --- (Updated June 29, 2015, 2:36 a.m.) Review request for mesos, Adam B, Jie Yu,

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

2015-06-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/ --- (Updated June 29, 2015, 3:16 a.m.) Review request for mesos and Benjamin

Re: Review Request 35721: Set the ownership of persistent volume to match the sandbox directory.

2015-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35721/#review89702 --- Patch looks great! Reviews applied: [35721] All tests passed. -

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

2015-06-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/#review89703 --- Patch looks great! Reviews applied: [29526, 29527, 29528, 29529,