Re: Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review89876 --- Ship it! Ship It! - Isabel Jimenez On June 30, 2015, 6:28 a.m.,

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2015-06-30 Thread haosdent huang
On June 1, 2015, 8:34 a.m., Adam B wrote: src/master/http.cpp, line 1038 https://reviews.apache.org/r/34646/diff/3/?file=975522#file975522line1038 Could I ask you to write a quick unit test for this? haosdent huang wrote: yes haosdent huang wrote: @adam-mesos, I have

Review Request 36040: Change Server closing connections for every request

2015-06-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/ --- Review request for mesos, Anand Mazumdar, Marco Massenzio, and Vinod Kone.

Re: Review Request 36037: Adding /call endpoint to Master

2015-06-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated June 30, 2015, 9:07 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review89870 --- Looks good to me, but I'll let Vinod give the final approval. I was

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

2015-06-30 Thread Alexander Rojas
On June 30, 2015, 6:08 a.m., Adam B wrote: Minor points, but otherwise shippable. I guess I'm still a little confused by the motivation. When would the firewall filter rule have more information about how to respond than the caller would? Can you give an example? The idea is to

Review Request 36041: The configure phase breaks with the IBM JVM.

2015-06-30 Thread Jihun Kang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36041/ --- Review request for mesos. Repository: mesos Description --- The

Re: Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review89871 --- Patch looks great! Reviews applied: [36036] All tests passed. -

Re: Review Request 35711: Disallow special characters in role name.

2015-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 30, 2015, 7:53 a.m.) Review request for mesos, Adam B and Jie

Re: Review Request 35711: Disallow special characters in role name.

2015-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 30, 2015, 8:29 a.m.) Review request for mesos, Adam B and Jie

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

2015-06-30 Thread Adam B
On June 29, 2015, 5:57 p.m., Adam B wrote: docs/mesos-ssl.md, lines 58-59 https://reviews.apache.org/r/36003/diff/3/?file=995165#file995165line58 Can you list RHEL/Ubuntu instructions as well? (For OpenSSL as well) Joris Van Remoortere wrote: I'm reluctant to add the

Re: Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Marco Massenzio
On June 30, 2015, 7:26 a.m., Adam B wrote: Looks good to me, but I'll let Vinod give the final approval. I was wondering if there could be any upgrade issues, but I don't think so, since it's an optional field and we aren't even reading reading it anywhere, just setting it for new

Re: Review Request 35711: Disallow special characters in role name.

2015-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 30, 2015, 8:30 a.m.) Review request for mesos, Adam B and Jie

Re: Review Request 36068: MESOS-2966: Fix 'peer()' call for ssl socket.

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36068/ --- (Updated June 30, 2015, 5:33 p.m.) Review request for mesos, Adam B, Benjamin

Review Request 36072: New Unsupported HTTP response type

2015-06-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36072/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and

Re: Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/#review89991 --- Ship it! src/common/protobuf_utils.cpp (line 150)

Re: Review Request 36073: New Method Not Allowed HTTP response type

2015-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36073/#review89994 --- Ship it! Ship It! - Anand Mazumdar On July 1, 2015, 1:52 a.m.,

Re: Review Request 36041: The configure phase breaks with the IBM JVM.

2015-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36041/#review8 --- Patch looks great! Reviews applied: [36041] All tests passed. -

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/#review89984 --- Ship it! Ship It! - Joris Van Remoortere On June 30, 2015,

Re: Review Request 36037: Adding /call endpoint to Master

2015-06-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 1:52 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 36073: New Method Not Allowed HTTP response type

2015-06-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36073/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2015-06-30 Thread haosdent huang
On June 30, 2015, 6:48 p.m., Vinod Kone wrote: This is an API change! Before embarking on this change, it's prudent to get feedback from the community on acceptable semantics (e.g., what do popular metric collectors do if they encounter 302 redirect? do they ignore the value or

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2015-06-30 Thread haosdent huang
On June 30, 2015, 6:48 p.m., Vinod Kone wrote: This is an API change! Before embarking on this change, it's prudent to get feedback from the community on acceptable semantics (e.g., what do popular metric collectors do if they encounter 302 redirect? do they ignore the value or

Re: Review Request 35799: Support mounting relative paths with docker.

2015-06-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/ --- (Updated July 1, 2015, 12:14 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

2015-06-30 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/ --- (Updated June 30, 2015, 5:32 p.m.) Review request for mesos, Adam B and Joris

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2015-06-30 Thread Adam B
On June 30, 2015, 11:48 a.m., Vinod Kone wrote: This is an API change! Before embarking on this change, it's prudent to get feedback from the community on acceptable semantics (e.g., what do popular metric collectors do if they encounter 302 redirect? do they ignore the value or

Re: Review Request 36074: MESOS-2973: Allow SSL tests to run using gtest_repeat.

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36074/ --- (Updated July 1, 2015, 2:24 a.m.) Review request for mesos, Adam B and

Re: Review Request 36056: Add test cases to check the ownership of persistent volume.

2015-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36056/#review90003 --- Patch looks great! Reviews applied: [36056] All tests passed. -

Review Request 36071: Add flow diagram for docker containerizer.

2015-06-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Till Toenshoff.

Re: Review Request 36037: Adding /call endpoint to Master

2015-06-30 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/ --- (Updated July 1, 2015, 1:43 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 36074: MESOS-2973: Allow ssl tests to run using gtest_repeat.

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36074/ --- Review request for mesos, Adam B and Benjamin Hindman. Repository: mesos

Re: Review Request 36074: MESOS-2973: Allow SSL tests to run using gtest_repeat.

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36074/ --- (Updated July 1, 2015, 2:26 a.m.) Review request for mesos, Adam B and

Review Request 36078: Refactored Call message to include Subscribe message.

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36078/ --- Review request for mesos, Adam B, Benjamin Hindman, and Ben Mahler. Bugs:

Re: Review Request 35857: Added Acknowledge call support to the master and the C++ scheduler library.

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35857/ --- (Updated July 1, 2015, 5:26 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 31207: Support for SSL and non-ssl traffic simultaneously.

2015-06-30 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31207/#review89893 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 1380)

Re: Review Request 35799: Support mounting relative paths with docker.

2015-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35799/#review90006 --- Patch looks great! Reviews applied: [35799] All tests passed. -

Review Request 36077: Renamed low level scheduler libprocess test to event call framework test.

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36077/ --- Review request for mesos, Ben Mahler, Jie Yu, and Marco Massenzio. Repository:

Re: Review Request 35856: Added Revive call support to the master and C++ scheduler library.

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35856/ --- (Updated July 1, 2015, 5:25 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 35858: Added Message call support to the master and the C++ scheduler library.

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35858/ --- (Updated July 1, 2015, 5:26 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

2015-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/#review90008 --- Patch looks great! Reviews applied: [36061] All tests passed. -

Re: Review Request 36078: Refactored Call message to include Subscribe message.

2015-06-30 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36078/#review90009 --- include/mesos/scheduler/scheduler.proto (lines 297 - 304)

Re: Review Request 36071: Add flow diagram for docker containerizer.

2015-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/#review90010 --- Bad patch! Reviews applied: [36071] Failed command:

Re: Review Request 35855: Added Decline call support to the master and C++ scheduler library.

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35855/ --- (Updated July 1, 2015, 5:24 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36018: Remove http specific protocol from master redirect.

2015-06-30 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36018/#review89894 --- Ship it! I added a comment for posterity that explains why it's

Re: Review Request 35711: Disallow special characters in role name.

2015-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35711/ --- (Updated June 30, 2015, 4:56 p.m.) Review request for mesos, Adam B and Jie

Re: Review Request 34646: Redirect to the leader master when current master is not a leader.

2015-06-30 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34646/#review89945 --- This is an API change! Before embarking on this change, it's

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/#review89943 --- Thanks Marco! This is a great change for our users!

Re: Review Request 36040: Change Server closing connections for every request

2015-06-30 Thread Isabel Jimenez
On June 30, 2015, 4:24 p.m., Anand Mazumdar wrote: 3rdparty/libprocess/src/http.cpp, line 777 https://reviews.apache.org/r/36040/diff/1/?file=995839#file995839line777 What is this change intending to solve ? If it's the ability to not close the connection for streamed responses.

Re: Review Request 36056: Add test cases to check the ownership of persistent volume.

2015-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36056/ --- (Updated June 30, 2015, 4:53 p.m.) Review request for mesos, Adam B and Jie

Review Request 36061: Slave exits gracefully on DNS lookup failure.

2015-06-30 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/ --- Review request for mesos, Adam B and Joris Van Remoortere. Repository: mesos

Re: Review Request 36040: Change Server closing connections for every request

2015-06-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36040/#review89909 --- 3rdparty/libprocess/src/http.cpp (line 777)

Review Request 36056: Add test cases to check the ownership of persistent volume.

2015-06-30 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36056/ --- Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-2603

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/ --- (Updated June 30, 2015, 6:41 p.m.) Review request for mesos, Adam B and

Re: Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Marco Massenzio
On June 30, 2015, 6:01 p.m., Vinod Kone wrote: src/common/protobuf_utils.cpp, line 145 https://reviews.apache.org/r/36036/diff/1/?file=995699#file995699line145 We should've added a comment on this method that this is only used by the StandaloneMasterDetector (used in tests and

Re: Review Request 36003: MESOS-2942: Documentation for SSL.

2015-06-30 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36003/#review89949 --- Ship it! Ship It! - Adam B On June 30, 2015, 11:41 a.m., Joris

Re: Review Request 35981: Added persistent volume user guide.

2015-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35981/#review89867 --- Patch looks great! Reviews applied: [32982, 35981] All tests

Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/ --- Review request for mesos, Anand Mazumdar, Isabel Jimenez, and Vinod Kone.

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

2015-06-30 Thread Adam B
On June 29, 2015, 9:08 p.m., Adam B wrote: Minor points, but otherwise shippable. I guess I'm still a little confused by the motivation. When would the firewall filter rule have more information about how to respond than the caller would? Can you give an example? Alexander Rojas

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

2015-06-30 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89880 --- Patch looks great! Reviews applied: [35919] All tests passed. -

Review Request 36068: MESOS-2966: Fix 'peer()' call for ssl socket.

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36068/ --- Review request for mesos, Adam B, Benjamin Hindman, and Artem Harutyunyan.

Re: Review Request 36037: Adding /call endpoint to Master

2015-06-30 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36037/#review89977 --- This looks good, Isabel! Just a few nits about error messages and

Re: Review Request 30643: Optionally specify executor for mesos execute.

2015-06-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30643/#review89976 --- Ship it! Ship It! src/cli/execute.cpp (line 101)

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

2015-06-30 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36061/ --- (Updated June 30, 2015, 11:34 p.m.) Review request for mesos, Adam B and Joris

Re: Review Request 35874: Added template parameters and constructors to hashset which reflex the state of hashmap

2015-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35874/#review89982 --- Hi Alex, I just wanted to follow up on our conversation. As

Re: Review Request 36036: Add `version` string to MasterInfo

2015-06-30 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36036/ --- (Updated June 30, 2015, 11:23 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 34135: Add filesystem/ isolators for persistent volumes.

2015-06-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34135/#review89974 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 216)

Re: Review Request 34137: Add support for container image provisioners.

2015-06-30 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34137/#review89975 --- src/slave/containerizer/mesos/containerizer.cpp (line 626)

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-06-30 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35755/ --- (Updated June 30, 2015, 4:24 p.m.) Review request for mesos and Joris Van

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-06-30 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated June 30, 2015, 4:25 p.m.) Review request for mesos and Joris Van

Re: Review Request 36061: Slave exits gracefully on DNS lookup failure.

2015-06-30 Thread Marco Massenzio
On June 30, 2015, 6:48 p.m., Joris Van Remoortere wrote: 3rdparty/libprocess/src/process.cpp, lines 899-902 https://reviews.apache.org/r/36061/diff/1/?file=996141#file996141line899 1. Did you choose to `LOG(ERROR)` followed by `exit(EXIT_FAILURE)` for a specific reason? I