Re: Review Request 36167: Updated FirewallRule interface so is consistent with http::Response usage in the project.

2015-07-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36167/#review90450 --- Ship it! Ship It! - Till Toenshoff On July 3, 2015, 2:23 p.m.,

Re: Review Request 36167: Updated FirewallRule interface so is consistent with http::Response usage in the project.

2015-07-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36167/#review90449 --- Ship it! Ship It! - Adam B On July 3, 2015, 7:23 a.m.,

Review Request 36193: Improved Doxygen-Styleguide.

2015-07-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36193/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, and Joseph Wu.

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-07-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated July 6, 2015, 2:38 p.m.) Review request for mesos, Adam B and Till

Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone. Bugs:

Re: Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review90473 --- docs/committers.md (line 7)

Re: Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Bernd Mathiske
On July 6, 2015, 5:39 a.m., Joerg Schad wrote: docs/committers.md, line 13 https://reviews.apache.org/r/36197/diff/1/?file=999718#file999718line13 Sometimes you use Mesos PMC and sometimes Current Committers, there is a difference but currently the sets are identically (with the

Review Request 36200: Change framework for framwork

2015-07-06 Thread Ryuichi Okumura
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36200/ --- Review request for mesos. Bugs: MESOS-2989

Re: Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/ --- (Updated July 6, 2015, 6:43 a.m.) Review request for mesos, Benjamin Hindman,

Review Request 36202: Fixed style problem in TODO

2015-07-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36202/ --- Review request for mesos, Isabel Jimenez, Joerg Schad, and Till Toenshoff.

Re: Review Request 36049: Added support for modularized Authorizer

2015-07-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated July 6, 2015, 5:42 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 36068: MESOS-2966: Fix 'peer()' call for ssl socket.

2015-07-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36068/#review90491 --- Joris, this is discarded now and can be removed right? - Benjamin

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Michael Park
Hey Mark, First off, thanks for these patches! I appreciate you taking the time to fix this. Second, I think the review chain is reversed currently. The *stout* changes should be the start of the chain, as it has the introduction of *getOrElse* function. So if you could flip it around to be

Re: Review Request 36207: Unified line wrapping for defines in gtest.hpp.

2015-07-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36207/ --- (Updated July 6, 2015, 5:19 p.m.) Review request for mesos and Alexander

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-06 Thread Joris Van Remoortere
On July 6, 2015, 3:02 a.m., Benjamin Hindman wrote: Hey Ben, Great questions in the latter half of your review. It turns out that the original test was malformed. It happened to pass because there is also a help process that responds to the `/help` endpoint. The original intent of the test,

Re: Review Request 31444: Support chrooting in MesosContainerizer launch helper.

2015-07-06 Thread Ian Downes
On June 29, 2015, 4:29 p.m., Jiang Yan Xu wrote: src/slave/containerizer/mesos/launch.cpp, lines 64-65 https://reviews.apache.org/r/31444/diff/7/?file=989735#file989735line64 must be relative to is really is interpreted as relative to right? Just wanted be sure clarify:

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90510 --- Thanks Bartek! See my detailed comments.

Re: Review Request 36189: Add strings::Mode to strings::trim.

2015-07-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/#review90512 --- Ship it! Ship It! - Vinod Kone On July 6, 2015, 3:29 p.m.,

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/#review90499 --- Bad patch! Reviews applied: [35285, 35286] Failed command:

Re: Review Request 36068: MESOS-2966: Fix 'peer()' call for ssl socket.

2015-07-06 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36068/ --- (Updated July 6, 2015, 5:08 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/#review90504 --- Hi Mark, Can you please make sure to rebase and post-review all of

Re: Review Request 36200: Change framework for framwork

2015-07-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36200/#review90506 --- Ship it! Thank you! - Vinod Kone On July 6, 2015, 1:38 p.m.,

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Mark Wang
On July 6, 2015, 5:23 p.m., Joris Van Remoortere wrote: Hi Mark, Can you please make sure to rebase and post-review all of the patches in the dependency chain? The build bot will keep reporting this conflict until it can apply the patches in the order it reports in its review. Yea, I

Re: Review Request 35285: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (mesos)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/ --- (Updated July 6, 2015, 6:02 p.m.) Review request for mesos and Joris Van

Re: Review Request 36204: Pass slave's total resources in ResourceUsage.

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36204/#review90516 --- Patch looks great! Reviews applied: [36204] All tests passed. -

Re: Review Request 36200: Change framework for framwork

2015-07-06 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36200/#review90490 --- Ship it! Ship It! - Kapil Arya On July 6, 2015, 9:38 a.m.,

Re: Review Request 36197: Documented how to become a committer.

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36197/#review90496 --- Patch looks great! Reviews applied: [36197] All tests passed. -

Review Request 36207: Unified line wrapping for defines in gtest.hpp.

2015-07-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36207/ --- Review request for mesos and Alexander Rojas. Repository: mesos Description

Re: Review Request 36106: cgroups: added cpuacct subsystem

2015-07-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/ --- (Updated July 6, 2015, 6:20 p.m.) Review request for mesos, Ian Downes, Jie

Review Request 36216: Only run netcat tests when nc is available.

2015-07-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36216/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.

Review Request 36214: Fix running docker executor tests.

2015-07-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36214/ --- Review request for mesos, Bernd Mathiske, Joerg Schad, and Till Toenshoff.

Review Request 36215: Dummy /call endpoint for master

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36215/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and

Re: Review Request 36215: Dummy /call endpoint for master

2015-07-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36215/#review90602 --- Ship it! Thanks isabel, I left some comments and cleaned them up

Re: Review Request 23784: Missing Apache headers for stout

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/#review90609 --- Patch looks great! Reviews applied: [23784] All tests passed. -

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-07-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review90610 --- Thanks for adding the hook! There is one more code path that a

Re: Review Request 36205: Added AWAIT_EXPECT_TRUE and AWAIT_EXPECT_FALSE macros.

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36205/#review90616 --- Ship it! Ship It! - Isabel Jimenez On July 6, 2015, 3:44 p.m.,

Re: Review Request 36152: Updated CHANGELOG for 0.23.0.

2015-07-06 Thread Adam B
On July 3, 2015, 12:18 p.m., Vinod Kone wrote: Thanks for the review. I've addressed your comments in the following commit: commit 7f1d97c93a4492d4b9469301237ce96083f5408d Author: Adam B a...@mesosphere.io Date: Mon Jul 6 16:11:13 2015 -0700 Updated 0.23.0 CHANGELOG per Vinod's

Re: Review Request 36216: Only run netcat tests when nc is available.

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36216/#review90597 --- Patch looks great! Reviews applied: [36216] All tests passed. -

Re: Review Request 36217: Adding http validations to master call request validations

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36217/ --- (Updated July 6, 2015, 11:31 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36106: cgroups: added cpuacct subsystem

2015-07-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/ --- (Updated July 7, 2015, 12:26 a.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 36189: Add strings::Mode to strings::trim.

2015-07-06 Thread Artem Harutyunyan
On July 6, 2015, 1:53 p.m., Artem Harutyunyan wrote: Ship It! Thanks for taking care of this! - Artem --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/#review90558

Re: Review Request 36189: Add strings::Mode to strings::trim.

2015-07-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36189/#review90558 --- Ship it! Ship It! - Artem Harutyunyan On July 6, 2015, 8:29

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/ --- (Updated July 6, 2015, 6:32 p.m.) Review request for mesos and Joris Van

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/#review90536 --- Ship it! Ship It! - Joris Van Remoortere On July 6, 2015, 6:46

Re: Review Request 36217: Adding http validations to master call request validations

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36217/ --- (Updated July 6, 2015, 9:24 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36215: Dummy /call endpoint for master

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36215/#review90585 --- Patch looks great! Reviews applied: [36215] All tests passed. -

Re: Review Request 36193: Improved Doxygen-Styleguide.

2015-07-06 Thread Joseph Wu
On July 6, 2015, 11:39 a.m., Joseph Wu wrote: docs/mesos-doxygen-style-guide.md, line 102 https://reviews.apache.org/r/36193/diff/1/?file=999588#file999588line102 This isn't part of the diff, but should this `@note` tag be replaced with a `**NOTE:**`? Joerg Schad wrote:

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 6, 2015, 1:59 p.m.) Review request for Joris Van Remoortere.

Re: Review Request 36193: Improved Doxygen-Styleguide.

2015-07-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36193/#review90525 --- docs/mesos-doxygen-style-guide.md (line 101)

Re: Review Request 23784: Missing Apache headers for stout

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/ --- (Updated July 6, 2015, 10:02 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35770: Consistent 'Test' suffix in mesos test names.

2015-07-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35770/#review90543 --- Ship it! Ship It! - Ben Mahler On June 23, 2015, 1:21 p.m.,

Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/ --- (Updated July 6, 2015, 6:46 p.m.) Review request for mesos and Joris Van

Re: Review Request 35285: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (mesos)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/ --- (Updated July 6, 2015, 6:45 p.m.) Review request for mesos and Joris Van

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/ --- (Updated July 6, 2015, 6:46 p.m.) Review request for mesos and Joris Van

Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/#review90537 --- Ship it! Ship It! - Joris Van Remoortere On July 6, 2015, 6:46

Re: Review Request 36214: Fix running docker executor tests.

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36214/#review90557 --- Patch looks great! Reviews applied: [36214] All tests passed. -

Re: Review Request 35285: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (mesos)

2015-07-06 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/#review90538 --- Ship it! Ship It! - Joris Van Remoortere On July 6, 2015, 6:47

Re: Review Request 36024: Refactored OSNetUri tests for fetcher to avoid code copy/pasting.

2015-07-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36024/ --- (Updated July 6, 2015, 1:51 p.m.) Review request for mesos and Joris Van

Re: Review Request 36193: Improved Doxygen-Styleguide.

2015-07-06 Thread Marco Massenzio
On July 6, 2015, 6:06 p.m., Joseph Wu wrote: Can you comment on the use of the `@copydoc` tag? I used it in the associated review (36141), but it isn't mentioned in the Doxygen style guide. I am somewhat hesitant about us trying to whitelist *everything* that is allowed. I much prefer

Re: Review Request 36106: cgroups: added cpuacct subsystem

2015-07-06 Thread Joris Van Remoortere
On July 1, 2015, 9:46 p.m., Timothy Chen wrote: src/linux/cgroups.cpp, line 2014 https://reviews.apache.org/r/36106/diff/1/?file=997647#file997647line2014 I don't think we usually define a inline function like this anywhere else, so curious to see what others think.

Re: Review Request 23783: Missing Apache headers for libprocess

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/ --- (Updated July 6, 2015, 10:21 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36005: Removed obsolete ec2 scripts.

2015-07-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36005/#review90552 --- Ship it! LGTM. Mind adding to CHANGELOG that these have been

Re: Review Request 23784: Missing Apache headers for stout

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23784/ --- (Updated July 6, 2015, 9:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 35285: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (mesos)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/ --- (Updated July 6, 2015, 6:33 p.m.) Review request for mesos and Joris Van

Re: Review Request 36205: Added AWAIT_EXPECT_TRUE and AWAIT_EXPECT_FALSE macros.

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36205/#review90534 --- Patch looks great! Reviews applied: [36205] All tests passed. -

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/ --- (Updated July 6, 2015, 6:45 p.m.) Review request for mesos and Joris Van

Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/#review90546 --- Ship it! Ship It! - Benjamin Hindman On July 6, 2015, 6:46

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/#review90545 --- Ship it! Ship It! - Benjamin Hindman On July 6, 2015, 6:46

Re: Review Request 35755: Changed fetcher to handle leading whitespace in URLs.

2015-07-06 Thread Artem Harutyunyan
On July 5, 2015, 8:02 p.m., Benjamin Hindman wrote: Joris Van Remoortere wrote: Hey Ben, Great questions in the latter half of your review. It turns out that the original test was malformed. It happened to pass because there is also a help process that responds to the

Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/ --- (Updated July 6, 2015, 6:45 p.m.) Review request for mesos and Joris Van

Re: Review Request 35285: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (mesos)

2015-07-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/#review90547 --- Ship it! Ship It! - Benjamin Hindman On July 6, 2015, 6:47

Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/ --- Review request for mesos and Benjamin Hindman. Repository: mesos-incubating

Re: Review Request 36106: cgroups: added cpuacct subsystem

2015-07-06 Thread Joris Van Remoortere
On July 2, 2015, 11:32 p.m., Ben Mahler wrote: src/linux/cgroups.hpp, lines 443-472 https://reviews.apache.org/r/36106/diff/1/?file=997646#file997646line443 Thanks! (1) Do you mind updating my TODO on cgroups::stat() to reflect that cpuacct::stat is implemented?

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23749/ --- (Updated July 6, 2015, 10:25 p.m.) Review request for mesos and Benjamin

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23749/ --- (Updated July 6, 2015, 10:33 p.m.) Review request for mesos and Benjamin

Review Request 36217: Adding http validations to master call request validations

2015-07-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36217/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, Marco Massenzio, and

Re: Review Request 36207: Unified line wrapping for defines in gtest.hpp.

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36207/#review90549 --- Patch looks great! Reviews applied: [36207] All tests passed. -

Re: Review Request 36071: Add flow diagram for docker containerizer.

2015-07-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36071/ --- (Updated July 6, 2015, 9:37 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36193: Improved Doxygen-Styleguide.

2015-07-06 Thread Joerg Schad
On July 6, 2015, 6:39 p.m., Joseph Wu wrote: docs/mesos-doxygen-style-guide.md, line 102 https://reviews.apache.org/r/36193/diff/1/?file=999588#file999588line102 This isn't part of the diff, but should this `@note` tag be replaced with a `**NOTE:**`? Good catch! But not part of

Re: Review Request 35286: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (libprocess)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35286/ --- (Updated July 6, 2015, 6:33 p.m.) Review request for mesos and Joris Van

Re: Review Request 36216: Only run netcat tests when nc is available.

2015-07-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36216/ --- (Updated July 6, 2015, 8:40 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 36214: Fix running docker executor tests.

2015-07-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36214/ --- (Updated July 6, 2015, 8:40 p.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 35285: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (mesos)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35285/ --- (Updated July 6, 2015, 6:47 p.m.) Review request for mesos and Joris Van

Re: Review Request 36193: Improved Doxygen-Styleguide.

2015-07-06 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36193/#review90529 --- docs/mesos-doxygen-style-guide.md (line 17)

Re: Review Request 36106: cgroups: added cpuacct subsystem

2015-07-06 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90581 --- Hey Jojy, great work so far! Thanks for writing up the JIRA first

Re: Review Request 35986: Allow slave attributes flag take a value with ':'.

2015-07-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35986/#review90623 --- Very good, but there are some subtleties that we should not ignore

Re: Review Request 23783: Missing Apache headers for libprocess

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23783/#review90624 --- Patch looks great! Reviews applied: [23783] All tests passed. -

Re: Review Request 36217: Adding http validations to master call request validations

2015-07-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36217/#review90625 --- Thanks Isabel! Left some comments per our chat. Also, can we

Re: Review Request 34943: Added validation to flags.

2015-07-06 Thread Benjamin Mahler
Wasn't sure if you guys saw this? On Wed, Jun 24, 2015 at 3:22 PM, Ben Mahler benjamin.mah...@gmail.com wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34943/ 3rdparty/libprocess/3rdparty/stout/include/stout/flags/flags.hpp

Re: Review Request 36226: Missing Apache headers for libprocess 3rdparty

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36226/#review90621 --- Patch looks great! Reviews applied: [36226] All tests passed. -

Re: Review Request 23749: Missing Apache headers for mesos

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/23749/#review90628 --- Patch looks great! Reviews applied: [23749] All tests passed. -

Re: Review Request 36106: cgroups: added cpuacct subsystem

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36106/#review90636 --- Patch looks great! Reviews applied: [36106] All tests passed. -

Re: Review Request 32982: Added reservation user guide.

2015-07-06 Thread Adam B
On June 29, 2015, 4:43 p.m., Adam B wrote: Looks great! I know this is already committed, but I had a few questions/clarifications. Maybe you've answered these elsewhere, but I've been out of the loop for a while. Thanks for answering my questions. I don't think there's anything that

Re: Review Request 36217: Adding http validations to master call request validations

2015-07-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36217/#review90640 --- Patch looks great! Reviews applied: [36215, 36217] All tests

Review Request 36245: Fix compilation error for clang-3.5 type deduction error.

2015-07-06 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/ --- Review request for mesos, Benjamin Hindman and Michael Park. Bugs: MESOS-2943

Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.

2015-07-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/#review90648 --- Ship it! Ship It! - Adam B On July 6, 2015, 10:16 p.m., Joris

Re: Review Request 36245: Fix compilation error for clang-3.5 type deduction error.

2015-07-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36245/#review90650 --- Ship it! Ship It! - Artem Harutyunyan On July 6, 2015, 10:16

Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.

2015-07-06 Thread Timothy Chen
On July 6, 2015, 5:25 a.m., Adam B wrote: docs/attributes-resources.md, line 11 https://reviews.apache.org/r/36173/diff/1/?file=999015#file999015line11 s/either supported by Attributes or Resources/supported by Attributes and Resources/ And are sets a 'type' or just a

Re: Review Request 36173: Update attributes doc to reflect current supported attributes types.

2015-07-06 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36173/#review90445 --- docs/attributes-resources.md (line 35)

Re: Review Request 35287: Rename OptionT::get(const T _t) to getOrElse() and refactor original functions (stout)

2015-07-06 Thread Mark Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35287/ --- (Updated July 6, 2015, 3:04 p.m.) Review request for mesos and Joris Van

  1   2   >