Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/#review92621 --- src/tests/persistent_volume_tests.cpp (lines 595 - 596)

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/#review92622 --- Ship it! src/slave/containerizer/isolators/filesystem/posix.cpp

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36586/ --- (Updated July 22, 2015, 6:11 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36586: Updated scheduler driver to send SUBSCRIBE call.

2015-07-22 Thread Vinod Kone
On July 20, 2015, 9:46 p.m., Ben Mahler wrote: src/tests/rate_limiting_tests.cpp, lines 134-136 https://reviews.apache.org/r/36586/diff/2/?file=1015049#file1015049line134 Note that in these tests, we've lost the fact that some of these subscribe calls should not have a

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92626 --- nice tests!

Re: Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36680/#review92629 --- Ship it! Ship It! - Vinod Kone On July 22, 2015, 6:33 a.m., Ben

Re: Review Request 36629: stout: Added support for 'synchronized_wait'.

2015-07-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36629/ --- (Updated July 22, 2015, 7:07 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36425: Enabling IP Discovery script

2015-07-22 Thread Benjamin Mahler
https://issues.apache.org/jira/browse/MESOS-2902 says this will be done in a module instead? Do we still need this review? On Wed, Jul 22, 2015 at 3:31 AM, Mesos ReviewBot reviews@mesos.apache.org wrote: --- This is an automatically

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

2015-07-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/ --- (Updated July 22, 2015, 8:09 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/ --- (Updated July 22, 2015, 8:09 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92630 --- Can you write a test for this? include/mesos/mesos.proto (line

Re: Review Request 36698: Updated scheduler library to send REQUEST call.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36698/#review92631 --- Patch looks great! Reviews applied: [36698] All tests passed. -

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-22 Thread Michael Park
On July 21, 2015, 10:59 p.m., Artem Harutyunyan wrote: 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 676 https://reviews.apache.org/r/36656/diff/1/?file=1018171#file1018171line676 s/protocol/protocols/ Now that we're only referring to SSL-V3, I think it should be:

Re: Review Request 36658: Updated SSL documentation. Added to home page.

2015-07-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review92640 --- Sorry, most of the issues I raised in this review are unrelated to

Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

2015-07-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36705/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

2015-07-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Bugs:

Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/ --- Review request for mesos, Ben Mahler, Michael Park, and Vinod Kone. Bugs:

Re: Review Request 36425: Enabling IP Discovery script

2015-07-22 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 22, 2015, 7:33 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36041: The configure phase breaks with the IBM JVM.

2015-07-22 Thread Jihun Kang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36041/ --- (Updated July 22, 2015, 7:29 a.m.) Review request for mesos. Bugs:

Re: Review Request 36425: Enabling IP Discovery script

2015-07-22 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/ --- (Updated July 22, 2015, 7:39 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/#review92560 --- Patch looks great! Reviews applied: [36683, 36684] All tests

Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

2015-07-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36680/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-3067

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/ --- (Updated July 22, 2015, 6:33 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92554 --- Thank you!! No need to update, I will get this committed for you

Re: Review Request 36424: Created a command executor helper method.

2015-07-22 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36424/ --- (Updated July 22, 2015, 6:20 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36318: [MESOS-2294] Add support to master for streaming subscribed events

2015-07-22 Thread Ben Mahler
On July 9, 2015, 10:24 p.m., Marco Massenzio wrote: src/master/http.cpp, line 307 https://reviews.apache.org/r/36318/diff/2/?file=1003768#file1003768line307 while you are at it, do you mind adding javadoc doxy documentation to this method? what it does, what the @param's

Re: Review Request 36673: Removed pthread from Once and Gate.

2015-07-22 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36673/#review92553 --- Ship it! Ship It! - Artem Harutyunyan On July 21, 2015, 10:55

Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Jie Yu. Bugs:

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92556 --- Bad patch! Reviews applied: [36677] Failed command:

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 22, 2015, 11:21 a.m.) Review request for mesos and Joerg Schad.

Re: Review Request 36425: Enabling IP Discovery script

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36425/#review92572 --- Patch looks great! Reviews applied: [36424, 36425] All tests

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-22 Thread Jan Schlicht
On July 21, 2015, 7:28 p.m., Vinod Kone wrote: docs/reconciliation.md, line 96 https://reviews.apache.org/r/36617/diff/2/?file=1016806#file1016806line96 what about other terminal states? Of course! I had only the TASK_LOST send during explicit reconciliation in mind. Other

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-22 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/ --- (Updated July 22, 2015, 11:14 a.m.) Review request for mesos and Joerg Schad.

Re: Review Request 35998: Added doxygen styled comments to Path::basename and Path::dirname.

2015-07-22 Thread Bernd Mathiske
On July 14, 2015, 5:13 a.m., Bernd Mathiske wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp, line 99 https://reviews.apache.org/r/35998/diff/1-2/?file=994383#file994383line99 / - | ? Turns out this is a review board display artifact. - Bernd

Re: Review Request 36617: Improved task reconciliation documentation.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36617/#review92582 --- Patch looks great! Reviews applied: [36617] All tests passed. -

Re: Review Request 36041: The configure phase breaks with the IBM JVM.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36041/#review92566 --- Patch looks great! Reviews applied: [36041] All tests passed. -

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-22 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated July 22, 2015, 10:04 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36680: Added recordio_test.cpp to libprocess Makefile.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36680/#review92558 --- Patch looks great! Reviews applied: [36677, 36680] All tests

Re: Review Request 36197: Documented how to become a committer.

2015-07-22 Thread Bernd Mathiske
On July 9, 2015, 3:32 p.m., Ben Mahler wrote: docs/committers.md, line 11 https://reviews.apache.org/r/36197/diff/2/?file=999881#file999881line11 No unanimous requirement :) https://community.apache.org/newcommitter.html @bmahler Would you support shipping this? - Bernd

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92585 --- Patch looks great! Reviews applied: [36612, 36620] All tests

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/#review92648 --- Patch looks great! Reviews applied: [36683, 36684] All tests

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

2015-07-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36708/#review92663 --- include/mesos/scheduler/scheduler.proto (lines 46 - 53)

Re: Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36705/#review92666 --- Patch looks great! Reviews applied: [36629, 36672, 36673, 36674,

Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36712/#review92701 --- Patch looks great! Reviews applied: [36712] All tests passed. -

Review Request 36716: Add NotImplemented status code

2015-07-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36716/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2294

Re: Review Request 36716: Add NotImplemented status code

2015-07-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36716/#review92707 --- Ship it! Ship It! - Ben Mahler On July 23, 2015, 2:11 a.m.,

Review Request 36717: Add missing include in cpp file.

2015-07-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36717/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2294

Review Request 36718: Converted Limitation and ExecutorRunState structs into protobufs.

2015-07-22 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36718/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Bugs: MESOS-3115

Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-07-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-2294

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 23, 2015, 4:25 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 23, 2015, 5:47 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36717: Add missing include in cpp file.

2015-07-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36717/#review92710 --- Patch looks great! Reviews applied: [36717] All tests passed. -

Re: Review Request 36627: Fixed cgroups oom killer test on Ubuntu 14.04

2015-07-22 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 22, 2015, 3:04 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Jie Yu
On July 22, 2015, 10:30 p.m., Vinod Kone wrote: src/tests/persistent_volume_tests.cpp, line 700 https://reviews.apache.org/r/36683/diff/1-2/?file=1018474#file1018474line700 Would it receive TASK_FAILED here or immediately after slave recovery finishes, irrespective of whether

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

2015-07-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/ --- (Updated July 22, 2015, 10:55 p.m.) Review request for mesos, Ben Mahler,

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/ --- (Updated July 22, 2015, 10:54 p.m.) Review request for mesos, Ben Mahler,

Review Request 36712: Added ONCE guard for Eventloop::initialize

2015-07-22 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36712/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 36712: Added ONCE guard for Eventloop::initialize

2015-07-22 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36712/ --- (Updated July 23, 2015, 12:17 a.m.) Review request for mesos and Joris Van

Re: Review Request 36698: Updated scheduler library to send REQUEST call.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36698/ --- (Updated July 23, 2015, 12:21 a.m.) Review request for mesos and Ben Mahler.

Review Request 36715: Used std::thread instead of pthread for Libprocess process.

2015-07-22 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36715/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36684: Fixed a bug related to persistent volumes during slave recovery.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36684/#review92664 --- Ship it! src/slave/containerizer/isolators/filesystem/posix.cpp

Re: Review Request 36683: Added a persistent volume test for slave recovery.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36683/#review92673 --- Ship it! Ship It! - Vinod Kone On July 22, 2015, 10:54 p.m.,

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-22 Thread Ben Mahler
On July 22, 2015, 6:46 p.m., Vinod Kone wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/recordio.hpp, lines 54-61 https://reviews.apache.org/r/36677/diff/2/?file=1018410#file1018410line54 Add comments! Added a javadoc at the top of encoder and decoder to capture that these

Re: Review Request 36708: Added HEARTBEAT event to the scheduler API.

2015-07-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36708/ --- (Updated July 23, 2015, 12:23 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-22 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36677/#review92690 --- I'll add a note about completion semantics (surface an error when