Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36763/#review92872 --- Patch looks great! Reviews applied: [36763] All tests passed. -

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/ --- (Updated July 24, 2015, 9:57 a.m.) Review request for mesos. Bugs:

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Klaus Ma
On July 20, 2015, 4:42 p.m., haosdent huang wrote: src/tests/fetcher_tests.cpp, line 297 https://reviews.apache.org/r/36501/diff/6/?file=1015170#file1015170line297 According

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Klaus Ma
On July 20, 2015, 4:42 p.m., haosdent huang wrote: haosdent huang wrote: Its a bit difficult to follow the mesos style guide at first. Maybe the committer could help you reformat it when summit @klausma1982 . :-) Thanks very much for your patience; yes, it tooks time for me to

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/#review92901 --- Bad patch! Reviews applied: [36612, 36620] Failed command:

Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-24 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/ --- Review request for mesos. Bugs: MESOS-3112

Review Request 36774: Updated Authorization Documentation to use /teardown endpoint.

2015-07-24 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36774/ --- Review request for mesos, Alexander Rojas and Till Toenshoff. Bugs: MESOS-2697

Re: Review Request 36732: Remove deprecated /shutdown master endpoint.

2015-07-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36732/#review92888 --- Ship it! Ship It! - Bernd Mathiske On July 23, 2015, 10:33

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92889 --- Patch looks great! Reviews applied: [36501] All tests passed. -

Re: Review Request 36757: Added https support.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review92924 --- Patch looks great! Reviews applied: [36712, 36757] All tests

Re: Review Request 36757: Added https support.

2015-07-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review92921 --- Ship it! 3rdparty/libprocess/src/tests/ssl_tests.cpp (line 988)

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Klaus Ma
On July 24, 2015, 2:01 p.m., Klaus Ma wrote: If you don't get to them first, I will fix the remaining little style suggestions when committing. OK, please help to fix it. I'll learn it from the final code :). Thanks very much. - Klaus

Re: Review Request 36676: Removed pthread from Zookeeper test helper.

2015-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36676/#review92980 --- Ship it! Ship It! - Benjamin Hindman On July 22, 2015, 5:59

Re: Review Request 34128: Enable different IP/Port for external access.

2015-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34128/#review92983 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 774)

Review Request 36794: Handle potential 'net::hostname()' failure.

2015-07-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36794/ --- Review request for mesos and Benjamin Hindman. Bugs: MESOS-3145

Re: Review Request 36733: Moved framework struct in master to end of file

2015-07-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36733/ --- (Updated July 24, 2015, 8:12 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36794: Handle potential 'net::hostname()' failure.

2015-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36794/#review92986 --- Ship it! Committing, thanks MPark! src/sched/sched.cpp (line

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

2015-07-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36763/ --- (Updated July 24, 2015, 5:26 p.m.) Review request for mesos, Ben Mahler, Kapil

Re: Review Request 36717: Add missing include in cpp file.

2015-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36717/#review92940 --- Ship it! Ship It! - Ben Mahler On July 23, 2015, 2:25 a.m.,

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

2015-07-24 Thread Jie Yu
On July 24, 2015, 5:58 p.m., Timothy Chen wrote: src/slave/containerizer/isolator.hpp, line 19 https://reviews.apache.org/r/36763/diff/2/?file=1021104#file1021104line19 Just wondering if we ever decided on a standard on these, seems odd to see just ISOLATOR_HPP here and

Re: Review Request 36741: Add small fixes allowing CMake to build Process lib tests on OS X 10.10

2015-07-24 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36741/#review92930 --- Ship it! Ship It! - Artem Harutyunyan On July 23, 2015, 4:40

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

2015-07-24 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36763/#review92933 --- Ship it! Ship It! - Kapil Arya On July 24, 2015, 1:26 p.m., Jie

Re: Review Request 36757: Added https support.

2015-07-24 Thread Jojy Varghese
On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote: 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 989 https://reviews.apache.org/r/36757/diff/1-3/?file=1020505#file1020505line989 AWAIT_EXPECT_RESPONSE_STATUS_EQ(OK().status, response); The pattern ASSERT_EQ(http::statuses[200],

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36760/#review92945 --- modulo anand's comments. src/messages/messages.proto (lines 347 -

Re: Review Request 36761: Added tests for unset framework pid in the slave.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36761/#review92954 --- src/tests/mesos.hpp (lines 1300 - 1303)

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

2015-07-24 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36763/#review92942 --- Ship it! Ship It! src/slave/containerizer/isolator.hpp (line 19)

Re: Review Request 36757: Added https support.

2015-07-24 Thread Anand Mazumdar
On July 24, 2015, 3:58 p.m., Anand Mazumdar wrote: 3rdparty/libprocess/src/tests/ssl_tests.cpp, line 1015 https://reviews.apache.org/r/36757/diff/1-3/?file=1020505#file1020505line1015 s/{}/None() s/payload/None() You should be able to do without setting headers

Re: Review Request 36759: Added an ExecutorToFramework message handler on the master.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36759/#review92939 --- Ship it! src/master/master.cpp (line 3199)

Re: Review Request 35947: Added a new API call 'updateAvailable' to the allocator.

2015-07-24 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35947/ --- (Updated July 24, 2015, 3:50 p.m.) Review request for mesos, Alexander

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-07-24 Thread Michael Park
On June 22, 2015, 1:32 p.m., Alexander Rukletsov wrote: src/master/master.cpp, line 749 https://reviews.apache.org/r/35702/diff/6/?file=989449#file989449line749 I think reserve is too abstract and may collide with future actions (think quota). How about `/dynamic/reserve`?

Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.

2015-07-24 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36799/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos

Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

2015-07-24 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 24, 2015, 6:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 36754: Updated Isolator::prepare to return ContainerPrepareInfo.

2015-07-24 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36754/ --- (Updated July 24, 2015, 6:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 36761: Added tests for unset framework pid in the slave.

2015-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36761/ --- (Updated July 24, 2015, 10:27 p.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 36759: Added an ExecutorToFramework message handler on the master.

2015-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36759/ --- (Updated July 24, 2015, 10:27 p.m.) Review request for mesos, Anand Mazumdar

Review Request 36801: Moved containerizer related tests under src/tests/containerizer.

2015-07-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36801/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, and Vinod Kone.

Re: Review Request 36318: Refactored framework struct in master to support http frameworks

2015-07-24 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36318/ --- (Updated July 24, 2015, 9:42 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36705: Libprocess: Replaced ThreadLocal use with thread_local.

2015-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36705/#review92991 --- Ship it! Ship It! - Benjamin Hindman On July 22, 2015, 8:23

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

2015-07-24 Thread Ben Mahler
On July 24, 2015, 2:17 a.m., Anand Mazumdar wrote: src/slave/slave.cpp, line 1302 https://reviews.apache.org/r/36760/diff/1/?file=1020568#file1020568line1302 OptionUPID frameworkPid; The default constructor already initializes to None. Right, we often do this just to

Re: Review Request 36761: Added tests for unset framework pid in the slave.

2015-07-24 Thread Ben Mahler
On July 24, 2015, 6:36 p.m., Vinod Kone wrote: src/tests/slave_tests.cpp, line 2641 https://reviews.apache.org/r/36761/diff/1/?file=1020576#file1020576line2641 s/Fail over/Restart/ Yeah that's better, I'll change the test name too. - Ben

Review Request 36804: Added documentation about MesosIsolator.

2015-07-24 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36804/ --- Review request for mesos and Benjamin Hindman. Repository: mesos Description

Re: Review Request 36801: Moved containerizer related tests under src/tests/containerizer.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36801/#review93005 --- Ship it! src/Makefile.am (line 1481)

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

2015-07-24 Thread Jie Yu
On July 24, 2015, 6:52 p.m., Benjamin Hindman wrote: src/slave/containerizer/isolator.hpp, line 37 https://reviews.apache.org/r/36763/diff/2/?file=1021104#file1021104line37 This class should be documented. In particular, that it's just a wrapper around IsolatorProcess that to

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Bernd Mathiske
On July 20, 2015, 9:42 a.m., haosdent huang wrote: haosdent huang wrote: Its a bit difficult to follow the mesos style guide at first. Maybe the committer could help you reformat it when summit @klausma1982 . :-) Klaus Ma wrote: Thanks very much for your patience; yes, it

Re: Review Request 36501: MESOS-3023

2015-07-24 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36501/#review92911 --- Ship it! src/tests/fetcher_tests.cpp (line 295)

Re: Review Request 35361: Added doc for standalone to HA

2015-07-24 Thread Michael Schenck
On June 11, 2015, 4:03 p.m., Mesos ReviewBot wrote: Patch looks great! Reviews applied: [35361] All tests passed. This has been reviewable for a while now. What are the next steps? - Michael --- This is an automatically

Re: Review Request 36757: Added https support.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review92962 --- Patch looks great! Reviews applied: [36712, 36757] All tests

Re: Review Request 36763: Made the Isolator interface not dependent on IsolatorProcess.

2015-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36763/#review92961 --- src/slave/containerizer/isolator.hpp (line 37)

Re: Review Request 36757: Added https support.

2015-07-24 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review92966 --- 3rdparty/libprocess/src/http.cpp (line 707)

Re: Review Request 34128: Enable different IP/Port for external access.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34128/#review92974 --- Ship it! Ship It! - Vinod Kone On May 18, 2015, 10:08 p.m.,

Re: Review Request 34129: Add 2 optional args public_ip and public_port for libprocess to advertise.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34129/#review92977 --- Ship it! docs/operational-guide.md (line 50)

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review92958 --- include/mesos/mesos.proto (line 397)

Re: Review Request 36757: Added https support.

2015-07-24 Thread Jojy Varghese
On July 24, 2015, 7:23 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 1025-1029 https://reviews.apache.org/r/36757/diff/4/?file=1021132#file1021132line1025 Why do you need a std::stringstream for this? We can simplify with just a string, and also

Re: Review Request 36757: Added https support.

2015-07-24 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/ --- (Updated July 24, 2015, 5:49 p.m.) Review request for mesos, Joris Van

Re: Review Request 36677: Introduced 'recordio' encoding facilities to stout.

2015-07-24 Thread Benjamin Hindman
On July 23, 2015, 11:52 p.m., Benjamin Hindman wrote: 3rdparty/libprocess/3rdparty/stout/tests/recordio_tests.cpp, line 32 https://reviews.apache.org/r/36677/diff/3/?file=1019202#file1019202line32 Why not add these to try.hpp like we did with Option? Ben Mahler wrote:

Re: Review Request 36760: Handle scheduler pid as optional in the slave.

2015-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36760/ --- (Updated July 24, 2015, 10:27 p.m.) Review request for mesos, Anand Mazumdar

Review Request 36805: Updated slave to always set task status's uuid in status update.

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36805/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-24 Thread Artem Harutyunyan
On July 23, 2015, 8:02 p.m., Marco Massenzio wrote: src/tests/memory_test_helper.cpp, line 87 https://reviews.apache.org/r/36627/diff/2/?file=1019121#file1019121line87 micro-nit: missing an `a` in `posix_memlign` Fixed in the latest commit. Thanks! - Artem

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-24 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/#review93017 --- Ship it! Ship It! - Vinod Kone On July 25, 2015, 12:36 a.m.,

Re: Review Request 36805: Updated slave to always set task status's uuid in status update.

2015-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36805/#review93013 --- Ship it! Thanks! - Ben Mahler On July 25, 2015, 12:04 a.m.,

Re: Review Request 36803: Added helpers for converting scheduler messages to Events.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36803/#review93014 --- Patch looks great! Reviews applied: [36803] All tests passed. -

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/#review93018 --- Bad patch! Reviews applied: [36618, 36627] Failed command:

Re: Review Request 36625: Windows: Split up platform specific functions into separate headers.

2015-07-24 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36625/ --- (Updated July 24, 2015, 6:11 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 36803: Added helpers for converting scheduler messages to Events.

2015-07-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36803/#review93012 --- Ship it! Ship It! - Ben Mahler On July 24, 2015, 11:27 p.m.,

Re: Review Request 36805: Updated slave to always set task status's uuid in status update.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36805/#review93015 --- Bad patch! Reviews applied: [36805] Failed command:

Re: Review Request 36627: WIP: Fixed cgroups oom killer test on Ubuntu 14.04

2015-07-24 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 24, 2015, 5:32 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36627: Fixed cgroups oom killer and memory pressure tests on Ubuntu 14.04.

2015-07-24 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36627/ --- (Updated July 24, 2015, 5:32 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36663: Added ip_address field to MasterInfo

2015-07-24 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36663/ --- (Updated July 25, 2015, 12:36 a.m.) Review request for mesos, Anand Mazumdar

Review Request 36807: [WIP] Adding a test for MasterInfo

2015-07-24 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36807/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2736

Re: Review Request 36773: Implemented a LRU entry selection criteria for cache eviction.

2015-07-24 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36773/#review92895 --- src/slave/containerizer/fetcher.cpp (line 994)

Re: Review Request 36774: Updated Authorization Documentation to use /teardown endpoint.

2015-07-24 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36774/#review92899 --- Patch looks great! Reviews applied: [36774] All tests passed. -