Review Request 36819: Use setup.py in python cli package.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- Review request for mesos. Repository: mesos Description --- Use

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:10 p.m.) Review request for mesos and Benjamin

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36656/ --- (Updated July 26, 2015, 5:28 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36799/#review93057 --- Patch looks great! Reviews applied: [36718, 36754, 36755, 36799]

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/ --- (Updated July 26, 2015, 5:24 p.m.) Review request for mesos and Benjamin

Re: Review Request 36656: Removed 'SSL_ENABLE_SSL_V2' configuration flag for SSLv2.

2015-07-26 Thread Joris Van Remoortere
On July 22, 2015, 7:51 p.m., Michael Park wrote: 3rdparty/libprocess/src/openssl.cpp, line 332 https://reviews.apache.org/r/36656/diff/1/?file=1018170#file1018170line332 Saw this while grepping for `SSLv2`. We still need to use this rather than `TLS_method` currently

Review Request 36828: Used std::thread instead of pthread for stout proc tests.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36828/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-07-26 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93060 --- src/master/http.cpp (line 339)

Review Request 36825: Removed common/thread as it is not used.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36825/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/#review93056 --- Patch looks great! Reviews applied: [36821] All tests passed. -

Review Request 36827: Removed and guarded pthread specifics for libevent-openssl.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36827/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-07-26 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review93048 --- src/master/http.cpp (line 359)

Review Request 36820: Fixed clang warning [-Wunevaluated-expression] in process tests.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36820/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36658: Updated SSL documentation. Added to home page.

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/#review93053 --- Patch looks great! Reviews applied: [36646, 36656, 36658] All

Re: Review Request 36754: Updated Isolator::prepare to return ContainerPrepareInfo.

2015-07-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36754/ --- (Updated July 26, 2015, 2:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36799: Renamed Executor{Limitation, RunState} to Container{Limitation, State}.

2015-07-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36799/ --- (Updated July 26, 2015, 2:49 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36755: Passed env vars returned by Isolator::prepare() to executor.

2015-07-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36755/ --- (Updated July 26, 2015, 2:49 p.m.) Review request for mesos, Benjamin Hindman

Review Request 36826: Removed common/factory as it is not used.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36826/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Review Request 36830: Libprocess: Introduce configurable `UNIMPLEMENTED` macro.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and

Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36829/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Joseph Wu, and

Re: Review Request 36757: Added https support.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36757/#review93049 --- Can you add (or at least make TODOs for) tests for the negative

Review Request 36821: Fix disable endpoints rule fails to recognize HTTP path delegates.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36821/ --- Review request for mesos. Bugs: MESOS-3143

Review Request 36824: Used std::thread instead of pthread for ns tests.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36824/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Review Request 36822: Used std::thread instead of pthread for Long Lived Executor.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36822/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Review Request 36823: Used std::thread instead of pthread for cgroups tests.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36823/ --- Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review93066 --- Bad patch! Reviews applied: [36837] Failed command:

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review93067 --- Bad patch! Reviews applied: [36837] Failed command:

Re: Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36831/#review93065 --- Patch looks great! Reviews applied: [36718, 36754, 36755, 36799,

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 3:48 a.m.) Review request for mesos. Bugs:

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:03 a.m.) Review request for mesos. Bugs:

Re: Review Request 36830: Libprocess: Introduce configurable `UNIMPLEMENTED` macro.

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36830/#review93063 --- Patch looks great! Reviews applied: [36822, 36823, 36824, 36825,

Review Request 36831: Allowed Isolator::prepare to return a list of CommandInfos.

2015-07-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36831/ --- Review request for mesos, Benjamin Hindman and Jie Yu. Repository: mesos

Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- Review request for mesos. Bugs: MESOS-3141

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated July 27, 2015, 4:18 a.m.) Review request for mesos. Bugs:

Re: Review Request 36829: Stout: Introduced configurable `UNIMPLEMENTED()` macro.

2015-07-26 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36829/#review93077 --- Ship it!

Review Request 36838: Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36838/ --- Review request for mesos. Repository: mesos Description --- Use

Re: Review Request 36838: Use flags.executor_shutdown_grace_period as shutdownTimeout in ShutdownProcess.

2015-07-26 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36838/ --- (Updated July 27, 2015, 5:47 a.m.) Review request for mesos and Benjamin

Re: Review Request 36819: Use setup.py in python cli package.

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review93047 --- Patch looks great! Reviews applied: [36819] All tests passed. -

Re: Review Request 36820: Fixed clang warning [-Wunevaluated-expression] in process tests.

2015-07-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36820/#review93051 --- Patch looks great! Reviews applied: [36820] All tests passed. -

Re: Review Request 36658: Updated SSL documentation. Added to home page.

2015-07-26 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36658/ --- (Updated July 26, 2015, 6:01 p.m.) Review request for mesos, Benjamin Hindman