Re: Review Request 36987: Extended 'getFormValue' to 'getFormValues' in order to parse input uniformly.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36987/ --- (Updated Aug. 5, 2015, 6:05 a.m.) Review request for mesos, Ben Mahler and Jie

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94196 --- Ship it! Ship It! - Marco Massenzio On Aug. 5, 2015, 4:21 a.m.,

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Marco Massenzio
On Aug. 5, 2015, 6:05 a.m., Marco Massenzio wrote: Ship It! Tested on Mac OSX 10.10 (Python 2.7) and Ubuntu 14.04: by `export PYTHONPATH=$MESOS_INSTALL_DIR/lib/python/site-packages` importing `mesos` and associated modules works. Thanks for fixing this, @haosdent! - Marco

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94203 --- Patch looks great! Reviews applied: [37097, 36402] All tests

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-05 Thread Alexander Rojas
On Aug. 3, 2015, 4:20 p.m., Bernd Mathiske wrote: include/mesos/authorizer/authorizer.proto, line 28 https://reviews.apache.org/r/36048/diff/11/?file=1017127#file1017127line28 What is local authorization? Link or explanation, please! Added the sentence `(See authorization.md file

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-05 Thread Alexander Rojas
On Aug. 3, 2015, 4:34 p.m., Bernd Mathiske wrote: src/local/local.cpp, line 221 https://reviews.apache.org/r/36049/diff/8/?file=1017149#file1017149line221 That's a bit too subtle for me. Proposals, either: - pass the acls to the custom authorizer and let it decide what to do

Re: Review Request 36978: MESOS-3142 Refactoring os::shell - patch 1/2

2015-08-05 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36978/ --- (Updated Aug. 5, 2015, 7:56 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-05 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/#review94207 --- Ship it! src/local/local.cpp (line 226)

Re: Review Request 36050: Added test authorizer module.

2015-08-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 5, 2015, 11:04 a.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-05 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 5, 2015, 11:04 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 36050: Added test authorizer module.

2015-08-05 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/#review94209 --- Ship it! Ship It! - Jan Schlicht On Aug. 5, 2015, 11:04 a.m.,

Re: Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37106/#review94208 --- Patch looks great! Reviews applied: [37106] All tests passed. -

Re: Review Request 34835: Add constexpr to C++ whitelist

2015-08-05 Thread Bernd Mathiske
On Aug. 4, 2015, 8:03 p.m., Anand Mazumdar wrote: docs/mesos-c++-style-guide.md, line 557 https://reviews.apache.org/r/34835/diff/4/?file=993626#file993626line557 This line does not wrap over and muddles up the UI with a scroll bar. The other examples for const expressions also

Review Request 37123: Fixed markdown rendering in C++ style guide.

2015-08-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37123/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Joerg Schad.

Re: Review Request 37123: Fixed markdown rendering in C++ style guide.

2015-08-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37123/ --- (Updated Aug. 5, 2015, 2:35 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 37123: Fixed markdown rendering in C++ style guide.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37123/#review94212 --- Ship it! Ship It! - haosdent huang On Aug. 5, 2015, 9:35 a.m.,

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94213 --- Ship it! Ship It! - Bernd Mathiske On Aug. 4, 2015, 9:21 p.m.,

Re: Review Request 36987: Extended 'getFormValue' to 'getFormValues' in order to parse input uniformly.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36987/ --- (Updated Aug. 5, 2015, 9:46 a.m.) Review request for mesos, Ben Mahler and Jie

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94214 --- Ship it! LGTM module the file ordering. src/Makefile.am (lines

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 5, 2015, 9:51 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 5, 2015, 9:54 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Aug. 5, 2015, 9:54 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 5, 2015, 9:55 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35984: Added tests for /reserve and /unreserve HTTP endpoints.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35984/ --- (Updated Aug. 5, 2015, 9:55 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94215 --- src/python/interface/setup.py.in (line 27)

Review Request 37110: Enabled the Authorizer to handle Reserve/Unreserve ACLs.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37110/ --- Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-3062

Re: Review Request 37123: Fixed markdown rendering in C++ style guide.

2015-08-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37123/#review94216 --- Ship it! Ship It! - Joerg Schad On Aug. 5, 2015, 9:35 a.m.,

Review Request 37125: Added 'Master::authorize' for Reserve/Unreserve.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37125/ --- Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-3062

Review Request 37126: Added authorization for dynamic reservation master endpoints.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37126/ --- Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-3062

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: src/python/interface/setup.py.in, line 27 https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27 This seems weird to me. Why do you need to add the bindings for the google search engine?

Review Request 37127: Added framework authorization for dynamic reservation.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37127/ --- Review request for mesos, Adam B and Jie Yu. Bugs: MESOS-3062

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: src/python/interface/setup.py.in, line 27 https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27 This seems weird to me. Why do you need to add the bindings for the google search engine?

Re: Review Request 36987: Extended 'getFormValue' to 'getFormValues' in order to parse input uniformly.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36987/ --- (Updated Aug. 5, 2015, 10:04 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37053/#review94219 --- Patch looks great! Reviews applied: [37053] All tests passed. -

Re: Review Request 37126: Added authorization for dynamic reservation master endpoints.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37126/ --- (Updated Aug. 5, 2015, 10:15 a.m.) Review request for mesos, Adam B and Jie

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 5, 2015, 10:28 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/ --- (Updated Aug. 5, 2015, 10:29 a.m.) Review request for mesos, Bernd Mathiske,

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: src/python/interface/setup.py.in, line 27 https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27 This seems weird to me. Why do you need to add the bindings for the google search engine?

Re: Review Request 36987: Extended 'getFormValue' to 'getFormValues' in order to parse input uniformly.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36987/ --- (Updated Aug. 5, 2015, 10:38 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Aug. 5, 2015, 10:44 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 5, 2015, 10:44 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37126: Added authorization for dynamic reservation master endpoints.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37126/ --- (Updated Aug. 5, 2015, 10:46 a.m.) Review request for mesos, Adam B and Jie

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote: src/master/http.cpp, line 475 https://reviews.apache.org/r/35702/diff/12/?file=1026443#file1026443line475 We typically use leading undescore for temp variables. The tailing underscore is for class members (following google style).

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Aug. 5, 2015, 11:15 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37127: Added framework authorization for dynamic reservation.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37127/ --- (Updated Aug. 5, 2015, 11:17 a.m.) Review request for mesos, Adam B and Jie

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: src/python/interface/setup.py.in, line 27 https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27 This seems weird to me. Why do you need to add the bindings for the google search engine?

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: src/python/interface/setup.py.in, line 27 https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27 This seems weird to me. Why do you need to add the bindings for the google search engine?

Re: Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

2015-08-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37075/ --- (Updated Aug. 5, 2015, 4:37 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 37012: mesos: Removed unused 'fatal' and 'fatalerror' macros.

2015-08-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37012/#review94228 --- Ship it! Ship It! - Bernd Mathiske On Aug. 4, 2015, 10:43 a.m.,

Re: Review Request 37012: mesos: Removed unused 'fatal' and 'fatalerror' macros.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37012/ --- (Updated Aug. 5, 2015, 4:47 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37011/ --- (Updated Aug. 5, 2015, 4:51 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

2015-08-05 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37011/#review94229 --- Ship it! Ship It! - Bernd Mathiske On Aug. 5, 2015, 4:51 a.m.,

Re: Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37011/ --- (Updated Aug. 5, 2015, 4:52 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37011: libprocess: Removed unused 'fatal' and 'fatalerror' macros.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37011/ --- (Updated Aug. 5, 2015, 4:54 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37010: stout: Removed unused 'fatal' and 'fatalerror' macros.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37010/ --- (Updated Aug. 5, 2015, 4:56 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37109: Removed ability to mutate user from scheduler library

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37109/#review94230 --- Patch looks great! Reviews applied: [37109] All tests passed. -

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: src/python/interface/setup.py.in, line 27 https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27 This seems weird to me. Why do you need to add the bindings for the google search engine?

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94235 --- Patch looks great! Reviews applied: [37045] All tests passed. -

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote: src/python/interface/setup.py.in, line 27 https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27 This seems weird to me. Why do you need to add the bindings for the google search engine?

Re: Review Request 37127: Added framework authorization for dynamic reservation.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37127/#review94240 --- Patch looks great! Reviews applied: [36987, 35702, 35983, 35984,

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94243 --- Ship it! I would say ship it if everyone agrees that this now

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Sebastien Pahl
On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote: I would say ship it if everyone agrees that this now depends on this python package just as a hack to add an empty __init__.py to the google submodule for protobuf. A better solution could be found later of course.

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread haosdent huang
On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote: I would say ship it if everyone agrees that this now depends on this python package just as a hack to add an empty __init__.py to the google submodule for protobuf. A better solution could be found later of course. Sebastien Pahl

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-05 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/ --- (Updated Aug. 5, 2015, 2:03 p.m.) Review request for mesos, Alexander

Re: Review Request 37081: Let __init__.py getting installed to $PREFIX/lib/pythonX.Y/site-packages/mesos.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37081/#review94249 --- Patch looks great! Reviews applied: [37081] All tests passed. -

Review Request 37073: Added process id prefix for cram_md5_authentication_tests.

2015-08-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37073/ --- Review request for mesos. Bugs: MESOS-1457

Review Request 37074: Added process id prefix for benchmarks and process tests.

2015-08-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37074/ --- Review request for mesos. Bugs: MESOS-1457

Re: Review Request 36911: Removed unnecessary using directive.

2015-08-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36911/#review94251 --- Ship it! Ship It! - Till Toenshoff On Aug. 3, 2015, 2:58 p.m.,

Re: Review Request 36910: Patch configure.ac to include $LIBS in the CRAM-MD5 check

2015-08-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36910/#review94252 --- Ship it! Ship It! - Till Toenshoff On Aug. 4, 2015, 1:49 p.m.,

Re: Review Request 36916: Doxygenified a comment in the allocator.proto.

2015-08-05 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36916/#review94256 --- Ship it! Ship It! - Till Toenshoff On July 29, 2015, 4:58 p.m.,

Re: Review Request 37080: Introduced RecordIO response reader

2015-08-05 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37080/ --- (Updated Aug. 5, 2015, 3:31 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review94258 --- Patch looks great! Reviews applied: [36908] All tests passed. -

Re: Review Request 37106: PortMappingIsolatorProcess shell script can silently fail.

2015-08-05 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37106/#review94260 --- Ship it! Ship It! - Chi Zhang On Aug. 5, 2015, 12:58 a.m., Paul

Re: Review Request 37074: Added process id prefix for benchmarks and process tests.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37074/#review94261 --- Patch looks great! Reviews applied: [37074] All tests passed. -

Re: Review Request 18723: Prevent gflags detection from glog configuration phase

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18723/#review94266 --- Ship it! Ship It! - haosdent huang On March 6, 2014, 6:48 p.m.,

Re: Review Request 36979: Updating all references to os::shell

2015-08-05 Thread Marco Massenzio
On Aug. 5, 2015, 4:16 a.m., Artem Harutyunyan wrote: src/tests/containerizer/isolator_tests.cpp, line 1269 https://reviews.apache.org/r/36979/diff/1/?file=1026037#file1026037line1269 You are right that the awk did not actually seem to accomplish anything meaningful here. my

Re: Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

2015-08-05 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37053/ --- (Updated Aug. 5, 2015, 1:09 p.m.) Review request for mesos, Niklas Nielsen and

Re: Review Request 36979: Updating all references to os::shell

2015-08-05 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- (Updated Aug. 5, 2015, 5:10 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37073: Added process id prefix for cram_md5_authentication_tests.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37073/#review94269 --- Patch looks great! Reviews applied: [37073] All tests passed. -

Review Request 37133: Add a frameworks parameter to the hierarchical allocator benchmark.

2015-08-05 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37133/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3209

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-08-05 Thread Jie Yu
On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote: src/master/http.cpp, line 573 https://reviews.apache.org/r/35702/diff/12/?file=1026443#file1026443line573 What is 'Nothing' here? Michael Park wrote: The `Nothing` here comes from the result of `master-apply` which returns a

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-08-05 Thread Jie Yu
On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote: src/master/http.cpp, line 534 https://reviews.apache.org/r/35702/diff/12/?file=1026443#file1026443line534 I don't like the name 'flatten' :( Could you at least be more explicit about it (i.e., emphasize that 'remaining' only

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94272 --- Mostly comments from the last review src/linux/perf.cpp (lines

Re: Review Request 37053: Set TaskStatus.executor_id on receiving a StatusUpdate from Executor.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37053/#review94277 --- Patch looks great! Reviews applied: [37053] All tests passed. -

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-05 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/ --- (Updated Aug. 5, 2015, 6:23 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37072: Added test for allocator update on scheduler failover

2015-08-05 Thread Aditi Dixit
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/ --- (Updated Aug. 5, 2015, 6:51 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/ --- (Updated Aug. 5, 2015, 7 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36979: Updating all references to os::shell

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94286 --- Patch looks great! Reviews applied: [36978, 36979] All tests

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/ --- (Updated Aug. 5, 2015, 7:12 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote: src/master/http.cpp, line 573 https://reviews.apache.org/r/35702/diff/12/?file=1026443#file1026443line573 What is 'Nothing' here? Michael Park wrote: The `Nothing` here comes from the result of `master-apply` which returns a

Re: Review Request 35983: Added /unreserve HTTP endpoint to the master.

2015-08-05 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35983/ --- (Updated Aug. 5, 2015, 7:12 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 36814: Fill executor_id in state.json when task is run in CommandExecutor.

2015-08-05 Thread Ben Mahler
On Aug. 4, 2015, 3:21 a.m., Adam B wrote: LGTM. I like the idea of not setting the executorId=taskId in the actual TaskInfo/Task, since that could confuse other logic downstream that expects the executor/executorId to be empty for command executors. However, since this is exposed in

Re: Review Request 37045: Convert Linux perf sampler to use process:await().

2015-08-05 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37045/#review94278 --- Ship it! Will get this committed now, thanks! I've made some

Re: Review Request 37133: Add a frameworks parameter to the hierarchical allocator benchmark.

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37133/#review94297 --- Patch looks great! Reviews applied: [37133] All tests passed. -

Re: Review Request 37072: Added test for allocator update on scheduler failover

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37072/#review94304 --- Patch looks great! Reviews applied: [37072] All tests passed. -

Re: Review Request 37105: Removed the code of checkpointing container root filesystem path.

2015-08-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37105/ --- (Updated Aug. 5, 2015, 9:16 p.m.) Review request for mesos, Ian Downes,

Review Request 37142: Removed the unneeded ExecutorInfo from Container struct in MesosContainerizer.

2015-08-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37142/ --- Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.

Re: Review Request 36837: Update gmock to 1.7.0 .

2015-08-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 5, 2015, 9:24 p.m.) Review request for mesos and Michael Park.

Re: Review Request 37142: Removed the unneeded ExecutorInfo from Container struct in MesosContainerizer.

2015-08-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37142/#review94318 --- Ship it! LGTM - Guangya Liu On 八月 5, 2015, 9:22 p.m., Jie Yu

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94321 --- Patch looks great! Reviews applied: [37097, 36402] All tests

  1   2   >