---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/
---
(Updated Aug. 5, 2015, 6:05 a.m.)
Review request for mesos, Ben Mahler and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94196
---
Ship it!
Ship It!
- Marco Massenzio
On Aug. 5, 2015, 4:21 a.m.,
On Aug. 5, 2015, 6:05 a.m., Marco Massenzio wrote:
Ship It!
Tested on Mac OSX 10.10 (Python 2.7) and Ubuntu 14.04: by `export
PYTHONPATH=$MESOS_INSTALL_DIR/lib/python/site-packages` importing `mesos` and
associated modules works.
Thanks for fixing this, @haosdent!
- Marco
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94203
---
Patch looks great!
Reviews applied: [37097, 36402]
All tests
On Aug. 3, 2015, 4:20 p.m., Bernd Mathiske wrote:
include/mesos/authorizer/authorizer.proto, line 28
https://reviews.apache.org/r/36048/diff/11/?file=1017127#file1017127line28
What is local authorization? Link or explanation, please!
Added the sentence `(See authorization.md file
On Aug. 3, 2015, 4:34 p.m., Bernd Mathiske wrote:
src/local/local.cpp, line 221
https://reviews.apache.org/r/36049/diff/8/?file=1017149#file1017149line221
That's a bit too subtle for me. Proposals, either:
- pass the acls to the custom authorizer and let it decide what to do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36978/
---
(Updated Aug. 5, 2015, 7:56 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/#review94207
---
Ship it!
src/local/local.cpp (line 226)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/
---
(Updated Aug. 5, 2015, 11:04 a.m.)
Review request for mesos, Adam B, Bernd
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated Aug. 5, 2015, 11:04 a.m.)
Review request for mesos, Adam B, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36050/#review94209
---
Ship it!
Ship It!
- Jan Schlicht
On Aug. 5, 2015, 11:04 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37106/#review94208
---
Patch looks great!
Reviews applied: [37106]
All tests passed.
-
On Aug. 4, 2015, 8:03 p.m., Anand Mazumdar wrote:
docs/mesos-c++-style-guide.md, line 557
https://reviews.apache.org/r/34835/diff/4/?file=993626#file993626line557
This line does not wrap over and muddles up the UI with a scroll bar.
The other examples for const expressions also
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/
---
Review request for mesos, Anand Mazumdar, haosdent huang, and Joerg Schad.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/
---
(Updated Aug. 5, 2015, 2:35 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/#review94212
---
Ship it!
Ship It!
- haosdent huang
On Aug. 5, 2015, 9:35 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94213
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 4, 2015, 9:21 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/
---
(Updated Aug. 5, 2015, 9:46 a.m.)
Review request for mesos, Ben Mahler and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94214
---
Ship it!
LGTM module the file ordering.
src/Makefile.am (lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated Aug. 5, 2015, 9:51 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 9:54 a.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35983/
---
(Updated Aug. 5, 2015, 9:54 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated Aug. 5, 2015, 9:55 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35984/
---
(Updated Aug. 5, 2015, 9:55 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94215
---
src/python/interface/setup.py.in (line 27)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37110/
---
Review request for mesos, Adam B and Jie Yu.
Bugs: MESOS-3062
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37123/#review94216
---
Ship it!
Ship It!
- Joerg Schad
On Aug. 5, 2015, 9:35 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37125/
---
Review request for mesos, Adam B and Jie Yu.
Bugs: MESOS-3062
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37126/
---
Review request for mesos, Adam B and Jie Yu.
Bugs: MESOS-3062
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/
---
(Updated Aug. 5, 2015, 10:04 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37053/#review94219
---
Patch looks great!
Reviews applied: [37053]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37126/
---
(Updated Aug. 5, 2015, 10:15 a.m.)
Review request for mesos, Adam B and Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 10:28 a.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/
---
(Updated Aug. 5, 2015, 10:29 a.m.)
Review request for mesos, Bernd Mathiske,
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36987/
---
(Updated Aug. 5, 2015, 10:38 a.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated Aug. 5, 2015, 10:44 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37126/
---
(Updated Aug. 5, 2015, 10:46 a.m.)
Review request for mesos, Adam B and Jie
On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote:
src/master/http.cpp, line 475
https://reviews.apache.org/r/35702/diff/12/?file=1026443#file1026443line475
We typically use leading undescore for temp variables. The tailing
underscore is for class members (following google style).
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35983/
---
(Updated Aug. 5, 2015, 11:15 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37127/
---
(Updated Aug. 5, 2015, 11:17 a.m.)
Review request for mesos, Adam B and Jie
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37075/
---
(Updated Aug. 5, 2015, 4:37 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37012/#review94228
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 4, 2015, 10:43 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37012/
---
(Updated Aug. 5, 2015, 4:47 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/
---
(Updated Aug. 5, 2015, 4:51 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/#review94229
---
Ship it!
Ship It!
- Bernd Mathiske
On Aug. 5, 2015, 4:51 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/
---
(Updated Aug. 5, 2015, 4:52 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37011/
---
(Updated Aug. 5, 2015, 4:54 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37010/
---
(Updated Aug. 5, 2015, 4:56 a.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37109/#review94230
---
Patch looks great!
Reviews applied: [37109]
All tests passed.
-
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
On Aug. 5, 2015, 9:57 a.m., Sebastien Pahl wrote:
src/python/interface/setup.py.in, line 27
https://reviews.apache.org/r/37081/diff/6/?file=1032437#file1032437line27
This seems weird to me. Why do you need to add the bindings for the
google search engine?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94243
---
Ship it!
I would say ship it if everyone agrees that this now
On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote:
I would say ship it if everyone agrees that this now depends on this python
package just as a hack to add an empty __init__.py to the google submodule
for protobuf.
A better solution could be found later of course.
On Aug. 5, 2015, 1:47 p.m., Sebastien Pahl wrote:
I would say ship it if everyone agrees that this now depends on this python
package just as a hack to add an empty __init__.py to the google submodule
for protobuf.
A better solution could be found later of course.
Sebastien Pahl
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/
---
(Updated Aug. 5, 2015, 2:03 p.m.)
Review request for mesos, Alexander
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37081/#review94249
---
Patch looks great!
Reviews applied: [37081]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37073/
---
Review request for mesos.
Bugs: MESOS-1457
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37074/
---
Review request for mesos.
Bugs: MESOS-1457
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36911/#review94251
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 3, 2015, 2:58 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36910/#review94252
---
Ship it!
Ship It!
- Till Toenshoff
On Aug. 4, 2015, 1:49 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37080/
---
(Updated Aug. 5, 2015, 3:31 p.m.)
Review request for mesos, Ben Mahler and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review94258
---
Patch looks great!
Reviews applied: [36908]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37106/#review94260
---
Ship it!
Ship It!
- Chi Zhang
On Aug. 5, 2015, 12:58 a.m., Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37074/#review94261
---
Patch looks great!
Reviews applied: [37074]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18723/#review94266
---
Ship it!
Ship It!
- haosdent huang
On March 6, 2014, 6:48 p.m.,
On Aug. 5, 2015, 4:16 a.m., Artem Harutyunyan wrote:
src/tests/containerizer/isolator_tests.cpp, line 1269
https://reviews.apache.org/r/36979/diff/1/?file=1026037#file1026037line1269
You are right that the awk did not actually seem to accomplish anything
meaningful here.
my
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37053/
---
(Updated Aug. 5, 2015, 1:09 p.m.)
Review request for mesos, Niklas Nielsen and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/
---
(Updated Aug. 5, 2015, 5:10 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37073/#review94269
---
Patch looks great!
Reviews applied: [37073]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37133/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-3209
On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote:
src/master/http.cpp, line 573
https://reviews.apache.org/r/35702/diff/12/?file=1026443#file1026443line573
What is 'Nothing' here?
Michael Park wrote:
The `Nothing` here comes from the result of `master-apply` which returns
a
On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote:
src/master/http.cpp, line 534
https://reviews.apache.org/r/35702/diff/12/?file=1026443#file1026443line534
I don't like the name 'flatten' :(
Could you at least be more explicit about it (i.e., emphasize that
'remaining' only
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/#review94272
---
Mostly comments from the last review
src/linux/perf.cpp (lines
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37053/#review94277
---
Patch looks great!
Reviews applied: [37053]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/
---
(Updated Aug. 5, 2015, 6:23 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/
---
(Updated Aug. 5, 2015, 6:51 p.m.)
Review request for mesos and Vinod Kone.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37097/
---
(Updated Aug. 5, 2015, 7 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36979/#review94286
---
Patch looks great!
Reviews applied: [36978, 36979]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35702/
---
(Updated Aug. 5, 2015, 7:12 p.m.)
Review request for mesos, Adam B, Benjamin
On Aug. 5, 2015, 5:46 a.m., Jie Yu wrote:
src/master/http.cpp, line 573
https://reviews.apache.org/r/35702/diff/12/?file=1026443#file1026443line573
What is 'Nothing' here?
Michael Park wrote:
The `Nothing` here comes from the result of `master-apply` which returns
a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35983/
---
(Updated Aug. 5, 2015, 7:12 p.m.)
Review request for mesos, Adam B, Benjamin
On Aug. 4, 2015, 3:21 a.m., Adam B wrote:
LGTM. I like the idea of not setting the executorId=taskId in the actual
TaskInfo/Task, since that could confuse other logic downstream that expects
the executor/executorId to be empty for command executors. However, since
this is exposed in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37045/#review94278
---
Ship it!
Will get this committed now, thanks! I've made some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37072/#review94304
---
Patch looks great!
Reviews applied: [37072]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/
---
(Updated Aug. 5, 2015, 9:16 p.m.)
Review request for mesos, Ian Downes,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37142/
---
Review request for mesos, Timothy Chen, Vinod Kone, and Jiang Yan Xu.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36837/
---
(Updated Aug. 5, 2015, 9:24 p.m.)
Review request for mesos and Michael Park.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37142/#review94318
---
Ship it!
LGTM
- Guangya Liu
On 八月 5, 2015, 9:22 p.m., Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36402/#review94321
---
Patch looks great!
Reviews applied: [37097, 36402]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36837/
---
(Updated Aug. 6, 2015, 4:22 a.m.)
Review request for mesos and Michael Park.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/
---
Review request for mesos.
Repository: mesos
Description
---
Add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37160/
---
(Updated Aug. 6, 2015, 4:23 a.m.)
Review request for mesos.
Bugs: MESOS-3141
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36837/
---
(Updated Aug. 6, 2015, 5:08 a.m.)
Review request for mesos and Michael Park.
On Aug. 6, 2015, 3:27 a.m., Michael Park wrote:
I'm also getting the following error when I run `distcheck`. Do you happen
to know why?
```
ERROR: files left in build directory after distclean:
./3rdparty/libprocess/3rdparty/._gmock-1.7.0
make[1]: *** [distcleancheck] Error 1
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37065/
---
(Updated Aug. 5, 2015, 10:54 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36404/
---
(Updated Aug. 5, 2015, 8:26 p.m.)
Review request for mesos, Joris Van
1 - 100 of 123 matches
Mail list logo