Re: Review Request 37159: Delegated the container root filesystem provisioning to the filesystem isolator.

2015-08-06 Thread Jie Yu
On Aug. 6, 2015, 5:38 a.m., Timothy Chen wrote: src/slave/containerizer/mesos/containerizer.cpp, line 661 https://reviews.apache.org/r/37159/diff/1/?file=1033221#file1033221line661 Where does the provisioner go? I see it's removed here but I don't see where else we're calling

Re: Review Request 37194: Fixed a bug in the MesosContainerizer creation logic.

2015-08-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37194/#review9 --- Ship it! Ship It!

Re: Review Request 37194: Fixed a bug in the MesosContainerizer creation logic.

2015-08-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37194/#review94442 --- src/slave/containerizer/mesos/containerizer.cpp (line 132)

Re: Review Request 37190: WIP: Added POST support for /maintenance endpoint. Performed initial verification of the input.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37190/#review94446 --- Bad patch! Reviews applied: [36321, 36571, 37052, 37190] Failed

Review Request 37196: Add Docker Image type to Container Image protobuf.

2015-08-06 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37196/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2851

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-06 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 6, 2015, 9:03 p.m.) Review request for mesos. Bugs: MESOS-3187

Re: Review Request 36979: Updating all references to os::shell

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94452 --- Patch looks great! Reviews applied: [36978, 36979] All tests

Re: Review Request 37165: Introduced v1 API.

2015-08-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/#review94436 --- Ship it! LGTM. Please rebase and let the review bot give an OK

Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

2015-08-06 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2849

Re: Review Request 36979: Updating all references to os::shell

2015-08-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/#review94453 --- src/hdfs/hdfs.hpp (line 110)

Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-06 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2849

Re: Review Request 37197: Docker image store.

2015-08-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review94448 --- src/slave/containerizer/provisioners/docker/store.hpp (line 123)

Re: Review Request 36978: MESOS-3142 Refactoring os::shell - patch 1/2

2015-08-06 Thread Marco Massenzio
On Aug. 5, 2015, 2:54 a.m., Artem Harutyunyan wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp, line 50 https://reviews.apache.org/r/36978/diff/1/?file=1026032#file1026032line50 should the variable be called `_cmd`? Marco Massenzio wrote: note this

Review Request 37197: Docker image store.

2015-08-06 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2849

Re: Review Request 37179: Enhance the bootstrap script

2015-08-06 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37179/#review94385 --- Ship it! Ship It! - Yong Qiao Wang On Aug. 6, 2015, 9:28 a.m.,

Re: Review Request 37179: Enhance the bootstrap script

2015-08-06 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37179/ --- (Updated Aug. 6, 2015, 5:37 p.m.) Review request for mesos and Yong Qiao Wang.

Re: Review Request 37108: Remove unused failover functionality in scheduler library

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37108/#review94387 --- Ship it! Ship It! - Alexander Rojas On Aug. 5, 2015, 3:19 a.m.,

Re: Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

2015-08-06 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37075/#review94254 --- include/mesos/mesos.proto (line 304)

Review Request 37168: MESOS-3063

2015-08-06 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- Review request for mesos. Bugs: MESOS-3063

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37065/#review94376 --- Ship it! Thanks for the exploration, just a few comments on

Re: Review Request 37109: Removed ability to mutate user from scheduler library

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37109/#review94389 --- Ship it! - Alexander Rojas On Aug. 5, 2015, 3:23 a.m., Anand

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/#review94386 --- 3rdparty/libprocess/src/http.cpp (lines 133 - 138)

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36847/#review94388 --- 3rdparty/libprocess/include/process/http.hpp (line 754)

Re: Review Request 37168: MESOS-3063

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review94390 --- Patch looks great! Reviews applied: [37168] All tests passed. -

Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37162/#review94362 --- Patch looks great! Reviews applied: [37162] All tests passed. -

Re: Review Request 35874: Added template parameters and constructors to hashset to match the signature of hashmap

2015-08-06 Thread Michael Park
On June 30, 2015, 11:55 p.m., Joris Van Remoortere wrote: Hi Alex, I just wanted to follow up on our conversation. As discussed, I think it makes sense to refactor to use `std::unordered_set` first. After that, I think you can simplify this code significantly: ``` hashset(const

Review Request 37198: Add Docker image provisioner and copy backend.

2015-08-06 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-2850

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-06 Thread Anand Mazumdar
On Aug. 6, 2015, 6:39 p.m., Ben Mahler wrote: src/master/master.cpp, line 4990 https://reviews.apache.org/r/36720/diff/9/?file=1033626#file1033626line4990 Don't we still want this since we call pid.get()? Persisted the CHECK_SOME. Removed the misleading message though as we have

Re: Review Request 37197: Docker image store.

2015-08-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review94494 --- src/slave/containerizer/provisioners/docker/store.cpp (line 403)

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-06 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- (Updated Aug. 7, 2015, 5:04 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37192: More basic call validation tests for http api

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/#review94497 --- Patch looks great! Reviews applied: [37080, 36720, 37082, 37192]

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 7, 2015, 2:27 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread haosdent huang
On Aug. 7, 2015, midnight, Michael Park wrote: 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake, line 36 https://reviews.apache.org/r/36837/diff/7/?file=1033437#file1033437line36 `s/1.6.0/1.7.0/` Thank you very much, let me update. - haosdent

Re: Review Request 37197: Docker image store.

2015-08-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review94488 --- src/slave/containerizer/provisioners/docker/store.hpp (line 128)

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/ --- (Updated Aug. 7, 2015, 2:56 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Anand Mazumdar
On Aug. 7, 2015, 12:21 a.m., Vinod Kone wrote: src/tests/http_api_tests.cpp, line 187 https://reviews.apache.org/r/37082/diff/3-4/?file=1032065#file1032065line187 No CHECK's in test code please. It will crash the program. Use ASSERT_SOME() instead. here and

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 7, 2015, 3:24 a.m.) Review request for mesos and Michael Park.

Re: Review Request 37197: Docker image store.

2015-08-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review94491 --- src/slave/containerizer/provisioners/docker/store.hpp (line 72)

Re: Review Request 37197: Docker image store.

2015-08-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review94489 --- src/slave/containerizer/provisioners/docker/store.hpp (line 54)

Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37162/ --- (Updated Aug. 7, 2015, 3:30 a.m.) Review request for mesos and Michael Park.

Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37162/ --- (Updated Aug. 7, 2015, 3:30 a.m.) Review request for mesos and Michael Park.

Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread haosdent huang
On Aug. 7, 2015, 12:01 a.m., Michael Park wrote: We should also update the `LICENSE` file to reflect this update. ``` == -For gmock-1.6.0 (3rdparty/libprocess/3rdparty/gmock-1.6.0.tar.gz): +For gmock-1.7.0

Re: Review Request 37198: Add Docker image provisioner and copy backend.

2015-08-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94485 --- Ship it! LGTM - Guangya Liu On 八月 6, 2015, 8:37 p.m., Lily Chen

Re: Review Request 37197: Docker image store.

2015-08-06 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/#review94493 --- src/slave/containerizer/provisioners/docker/store.cpp (line 169)

Re: Review Request 37196: Add Docker Image type to Container Image protobuf.

2015-08-06 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37196/#review94480 --- Ship it! Ship It! - Guangya Liu On 八月 6, 2015, 9:27 p.m., Lily

Re: Review Request 37192: More basic call validation tests for http api

2015-08-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/ --- (Updated Aug. 7, 2015, 3:05 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37194: Fixed a bug in the MesosContainerizer creation logic.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37194/#review94463 --- Patch looks great! Reviews applied: [36929, 36930, 36954, 36956,

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94466 --- 3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake (line 36)

Re: Review Request 37202: Fixed flaky MasterAuthorizationTest.DuplicateRegistration test.

2015-08-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37202/#review94464 --- Ship it! Ship It! - Ben Mahler On Aug. 6, 2015, 11:52 p.m.,

Re: Review Request 37192: More basic call validation tests for http api

2015-08-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/#review94432 --- Ship it! src/tests/http_api_tests.cpp (line 137)

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94468 --- src/tests/http_api_tests.cpp (line 182)

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-06 Thread Vaibhav Khanduja
On Aug. 7, 2015, 1:31 a.m., Timothy Chen wrote: We already have a flag called docker_socket that I think we can reuse instead of doing this. Thanks .. I will make the change ... On Aug. 7, 2015, 1:31 a.m., Timothy Chen wrote: src/docker/docker.hpp, line 45

Review Request 37202: Fixed flaky MasterAuthorizationTest.DuplicateRegistration test.

2015-08-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37202/ --- Review request for mesos. Bugs: MESOS-3203

Re: Review Request 37162: Add GTEST_LANG_CXX11 to configure.ac when compile.

2015-08-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37162/#review94467 --- We should also update the `LICENSE` file to reflect this update.

Re: Review Request 37198: Add Docker image provisioner and copy backend.

2015-08-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/#review94475 --- src/slave/containerizer/provisioners/docker.hpp (line 81)

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/#review94456 --- Patch looks great! Reviews applied: [37196, 37197, 37198, 37199,

Re: Review Request 37105: Removed the code of checkpointing container root filesystem path.

2015-08-06 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37105/#review94153 --- src/slave/containerizer/mesos/containerizer.hpp (line 184)

Re: Review Request 36431: Show stdout/stderr when using mesos-execute.

2015-08-06 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/#review94460 --- Before we go too far down this path, can you please see

Re: Review Request 36431: Show stdout/stderr when using mesos-execute.

2015-08-06 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/#review94459 --- Before we go too far down this path, can you please see

Re: Review Request 36431: Show stdout/stderr when using mesos-execute.

2015-08-06 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36431/#review94461 --- - Marco Massenzio On Aug. 4, 2015, 9:33 a.m., haosdent huang

Re: Review Request 37190: WIP: Added POST support for /maintenance endpoint. Performed initial verification of the input.

2015-08-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37190/ --- (Updated Aug. 6, 2015, 6:34 p.m.) Review request for Benjamin Hindman, Joris

Re: Review Request 37196: Add Docker Image type to Container Image protobuf.

2015-08-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37196/#review94474 --- Ship it! Ship It! - Timothy Chen On Aug. 6, 2015, 9:27 p.m.,

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-06 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review94472 --- We already have a flag called docker_socket that I think we can

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 6:26 a.m.) Review request for mesos and Michael Park.

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-06 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review94395 --- Ship it! Ship It! - Jan Schlicht On Aug. 6, 2015, 1:59 p.m.,

Re: Review Request 37179: Enhance the bootstrap script

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37179/#review94397 --- Patch looks great! Reviews applied: [37179] All tests passed. -

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37065/#review94393 --- Patch looks great! Reviews applied: [37065] All tests passed. -

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/#review94396 --- Patch looks great! Reviews applied: [36837] All tests passed. -

Re: Review Request 37075: Protobuf definitions instructing the fetcher cache about checksums and their validation.

2015-08-06 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37075/#review94391 --- include/mesos/mesos.proto (line 292)

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37065/#review94394 --- src/tests/containerizer/memory_test_helper.cpp (lines 75 - 76)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 6, 2015, 1:59 p.m.) Review request for mesos, Adam B, Alexander

Review Request 37192: More basic call validation tests for http api

2015-08-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Re: Review Request 37097: Fix 'Accept-Encoding' parsing

2015-08-06 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37097/ --- (Updated Aug. 6, 2015, 5:35 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36979: Updating all references to os::shell

2015-08-06 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36979/ --- (Updated Aug. 6, 2015, 6:24 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37065/#review94431 --- Patch looks great! Reviews applied: [37065] All tests passed. -

Re: Review Request 36978: MESOS-3142 Refactoring os::shell - patch 1/2

2015-08-06 Thread Artem Harutyunyan
On Aug. 4, 2015, 7:54 p.m., Artem Harutyunyan wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp, line 50 https://reviews.apache.org/r/36978/diff/1/?file=1026032#file1026032line50 should the variable be called `_cmd`? Marco Massenzio wrote: note this

Re: Review Request 37082: Tests for subscribe/failover functionality for http based framework

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37082/#review94422 --- Patch looks great! Reviews applied: [37080, 36720, 37082] All

Review Request 37194: Fixed a bug in the MesosContainerizer creation logic.

2015-08-06 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37194/ --- Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan

Re: Review Request 36979: Updating all references to os::shell

2015-08-06 Thread Marco Massenzio
On Aug. 5, 2015, 4:16 a.m., Artem Harutyunyan wrote: src/tests/containerizer/port_mapping_tests.cpp, line 986 https://reviews.apache.org/r/36979/diff/1/?file=1026038#file1026038line986 ditto. + extra newline. Marco Massenzio wrote: Having looked at both tests, I was

Re: Review Request 37192: More basic call validation tests for http api

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37192/#review94427 --- Patch looks great! Reviews applied: [37080, 36720, 37082, 37192]

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-06 Thread Artem Harutyunyan
On Aug. 6, 2015, 4:47 a.m., Alexander Rojas wrote: src/tests/containerizer/memory_test_helper.cpp, lines 79-87 https://reviews.apache.org/r/37065/diff/3/?file=1033300#file1033300line79 After reading the man pages, `mlock()` exists in Linux too and frankly it looks safer to use

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37065/ --- (Updated Aug. 6, 2015, 10:34 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37065: Fixed MemIsolatorTest failure on OSX.

2015-08-06 Thread Artem Harutyunyan
On Aug. 6, 2015, 1:21 a.m., Michael Park wrote: src/tests/containerizer/memory_test_helper.cpp, lines 81-83 https://reviews.apache.org/r/37065/diff/3/?file=1033300#file1033300line81 `mlockall` is not what we want ideally right? Can we mention that it's not ideal but

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-06 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94428 --- Thanks, I'll get the HttpConnection change committed, left some

Re: Review Request 36979: Updating all references to os::shell

2015-08-06 Thread Marco Massenzio
On Aug. 5, 2015, 4:16 a.m., Artem Harutyunyan wrote: src/tests/containerizer/port_mapping_tests.cpp, line 986 https://reviews.apache.org/r/36979/diff/1/?file=1026038#file1026038line986 ditto. + extra newline. Marco Massenzio wrote: Having looked at both tests, I was

Review Request 37114: MESOS-3187, support docker host command line option

2015-08-06 Thread Vaibhav Khanduja
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/ --- Review request for mesos. Bugs: MESOS-3187

Re: Review Request 36978: MESOS-3142 Refactoring os::shell - patch 1/2

2015-08-06 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36978/ --- (Updated Aug. 6, 2015, 6:20 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 37190: WIP: Added POST support for /maintenance endpoint. Performed initial verification of the input.

2015-08-06 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37190/ --- (Updated Aug. 6, 2015, 11:27 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37108: Remove unused failover functionality in scheduler library

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37108/#review94400 --- Patch looks great! Reviews applied: [37108] All tests passed. -

Re: Review Request 37160: Add GTEST_LANG_CXX11 to StoutTestsConfigure when compile.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37160/#review94372 --- Patch looks great! Reviews applied: [37160] All tests passed. -

Re: Review Request 37074: Added process id prefix for benchmarks and process tests.

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37074/#review94383 --- Ship it! Ship It! - Alexander Rojas On Aug. 5, 2015, 4:52 p.m.,

Re: Review Request 37073: Added process id prefix for cram_md5_authentication_tests.

2015-08-06 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37073/#review94384 --- Ship it! Ship It! - Alexander Rojas On Aug. 5, 2015, 4:53 p.m.,

Review Request 37179: Enhance the bootstrap script

2015-08-06 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37179/ --- Review request for mesos and Yong Qiao Wang. Bugs: MESOS-3218

Re: Review Request 36837: Update gmock to 1.7.0.

2015-08-06 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36837/ --- (Updated Aug. 6, 2015, 9:20 a.m.) Review request for mesos and Michael Park.

Re: Review Request 37165: Introduced v1 API.

2015-08-06 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/#review94381 --- Bad patch! Reviews applied: [37165] Failed command:

Review Request 37165: Introduced v1 API.

2015-08-06 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone.

Re: Review Request 36978: MESOS-3142 Refactoring os::shell - patch 1/2

2015-08-06 Thread Marco Massenzio
On Aug. 6, 2015, 5:48 a.m., Benjamin Hindman wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os/posix/shell.hpp, line 44 https://reviews.apache.org/r/36978/diff/2/?file=1032323#file1032323line44 s/cmd/command/ Reverted. On Aug. 6, 2015, 5:48 a.m., Benjamin Hindman wrote:

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-06 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/#review94413 --- src/common/http.cpp (line 60)

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-06 Thread Anand Mazumdar
On Aug. 6, 2015, 4:10 p.m., Vinod Kone wrote: src/common/http.cpp, line 60 https://reviews.apache.org/r/36720/diff/8/?file=1033227#file1033227line60 need a return here to aviod compiler warning. I am putting in a fix for that. This looks to be as a GCC bug. With

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-06 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 6, 2015, 4:25 p.m.) Review request for mesos, Ben Mahler and

  1   2   >