---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94539
---
Ship it!
Ship It!
- Alexander Rojas
On Aug. 7, 2015, 1:52 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37222/#review94573
---
Patch looks great!
Reviews applied: [37221, 37222]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37228/
---
(Updated Aug. 7, 2015, 3:44 p.m.)
Review request for mesos and Niklas Nielsen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37228/#review94588
---
Ship it!
Ship It!
- Niklas Nielsen
On Aug. 7, 2015, 3:44 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/#review94584
---
Could you consider my comment on MESOS-2968 w.r.t the Backend API:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37236/
---
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review94576
---
Patch looks great!
Reviews applied: [35711]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
---
(Updated Aug. 7, 2015, 1:40 p.m.)
Review request for Benjamin Hindman, Joris
On Aug. 7, 2015, 1:45 a.m., Timothy Chen wrote:
src/slave/flags.cpp, line 81
https://reviews.apache.org/r/37198/diff/1/?file=1033693#file1033693line81
Is this going to be the same with appc? Should we just have one config?
Changed to /tmp/mesos/containers/docker, to match the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/
---
Review request for mesos, Ian Downes, Timothy Chen, Vinod Kone, and Jiang Yan
On Aug. 6, 2015, 10:26 p.m., Guangya Liu wrote:
src/hdfs/hdfs.hpp, line 110
https://reviews.apache.org/r/36979/diff/3/?file=1033647#file1033647line110
Why not use the following?
return !out.get().empty();
Actually, that was exactly what I originally typed :)
However,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37165/
---
(Updated Aug. 7, 2015, 6:38 a.m.)
Review request for mesos, Anand Mazumdar,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36837/#review94503
---
Patch looks great!
Reviews applied: [36837]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/#review94509
---
Patch looks great!
Reviews applied: [37114]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37208/
---
Review request for mesos and Zhiwei Chen.
Bugs: MESOS-3228
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36837/#review94510
---
Ship it!
Ship It!
- Michael Park
On Aug. 7, 2015, 3:24 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36720/#review94496
---
Ship it!
I left some comments here so you could see the issues I
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37160/#review94511
---
Ship it!
Ship It!
- Michael Park
On Aug. 6, 2015, 5:13 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37097/#review94513
---
Ship it!
3rdparty/libprocess/src/http.cpp (line 133)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37162/#review94512
---
Ship it!
Ship It!
- Michael Park
On Aug. 7, 2015, 3:30 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/
---
(Updated Aug. 7, 2015, 11:45 a.m.)
Review request for mesos, Alexander Rojas
On Aug. 7, 2015, 8:43 a.m., Michael Park wrote:
Ship It!
Thank you for your great help. LoL
- haosdent
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36837/#review94510
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36431/
---
(Updated Aug. 7, 2015, 10:30 a.m.)
Review request for mesos, Adam B and
On Aug. 6, 2015, 11:43 p.m., Marco Massenzio wrote:
Before we go too far down this path, can you please see
https://reviews.apache.org/r/36424/ and see whether it does what you are
trying to achieve here?
(maybe not, I'm not familiar at all with `cli` - just asking)
Hi, @marco .Thank
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---
(Updated Aug. 7, 2015, 12:28 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 7, 2015, 12:27 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/
---
(Updated Aug. 7, 2015, 12:28 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94523
---
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---
(Updated Aug. 7, 2015, 11:46 a.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/#review94516
---
Ship it!
Ship It!
- Alexander Rojas
On Aug. 7, 2015, 11:45
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37208/#review94518
---
Patch looks great!
Reviews applied: [37208]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36431/
---
(Updated Aug. 7, 2015, 10:37 a.m.)
Review request for mesos, Adam B and
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 7, 2015, 11:44 a.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37187/
---
(Updated Aug. 7, 2015, 11:45 a.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/#review94517
---
Ship it!
3rdparty/libprocess/src/tests/http_tests.cpp (lines 677
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94519
---
include/mesos/type_utils.hpp (line 515)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/
---
(Updated Aug. 7, 2015, 2:31 p.m.)
Review request for mesos, Benjamin Hindman,
On Aug. 5, 2015, 3:38 a.m., Cody Maloney wrote:
configure.ac, line 548
https://reviews.apache.org/r/36811/diff/6/?file=1025039#file1025039line548
The check should come before we do the AC_SUBST. I don't want to just
move the AC_SUBST way away from the rest of the protobuf
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/
---
(Updated Aug. 7, 2015, 3:35 p.m.)
Review request for mesos, Adam B and Michael
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated Aug. 7, 2015, 3:48 p.m.)
Review request for mesos, Adam B, Jie Yu,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37222/
---
Review request for mesos.
Bugs: MESOS-3234
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37221/
---
Review request for mesos.
Bugs: MESOS-3234
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35712/
---
Review request for mesos.
Repository: mesos
Description
---
u
Diffs
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/#review94554
---
Patch looks great!
Reviews applied: [36819]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/
---
(Updated Aug. 7, 2015, 3:21 p.m.)
Review request for mesos, Adam B, Cody
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated Aug. 7, 2015, 3:40 p.m.)
Review request for mesos, Adam B, Jie Yu,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36811/#review94562
---
Patch looks great!
Reviews applied: [36810, 36811]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37097/
---
(Updated Aug. 7, 2015, 6:52 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37082/#review94568
---
Ship it!
Ship It!
- Vinod Kone
On Aug. 7, 2015, 2:56 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37228/
---
Review request for mesos and Niklas Nielsen.
Repository: mesos
Description
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/
---
(Updated Aug. 7, 2015, 6:50 p.m.)
Review request for mesos, Adam B, Jie Yu,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37190/
---
(Updated Aug. 7, 2015, 10:05 a.m.)
Review request for Benjamin Hindman, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36816/#review94569
---
Patch looks great!
Reviews applied: [36816]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35711/#review94571
---
Bad patch!
Reviews applied: [35711]
Failed command: make -j3
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36819/
---
(Updated Aug. 7, 2015, 3:08 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37228/#review94578
---
Patch looks great!
Reviews applied: [37228]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37114/
---
(Updated Aug. 7, 2015, 9:19 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36431/#review94530
---
Patch looks great!
Reviews applied: [36431]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/#review94533
---
Patch looks great!
Reviews applied: [37187, 37188, 37189]
All
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37189/
---
(Updated Aug. 7, 2015, 1:52 p.m.)
Review request for mesos, Alexander Rojas
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37188/
---
(Updated Aug. 7, 2015, 1:53 p.m.)
Review request for mesos, Alexander Rojas
On Aug. 7, 2015, 12:06 p.m., Alexander Rojas wrote:
include/mesos/type_utils.hpp, line 515
https://reviews.apache.org/r/37189/diff/1/?file=1033607#file1033607line515
Perhaps add a summarized version of this comment into the code?
I've added a comment to every occurence to explain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/
---
(Updated Aug. 7, 2015, 11:30 p.m.)
Review request for mesos, Lily Chen, Ian
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37142/#review94594
---
Ship it!
Ship It!
- Jiang Yan Xu
On Aug. 5, 2015, 2:22 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/#review94582
---
src/slave/containerizer/provisioners/docker/store.hpp (line 125)
On Aug. 6, 2015, 9:34 p.m., Timothy Chen wrote:
src/slave/containerizer/provisioners/docker/store.hpp, line 123
https://reviews.apache.org/r/37197/diff/1/?file=1033680#file1033680line123
End comment with period. And why not use ImageName as keys, or
basically everywhere else in
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37241/#review94595
---
Ship it!
Ship It!
- Isabel Jimenez
On Aug. 7, 2015, 11:44 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37241/
---
Review request for mesos, Anand Mazumdar, Benjamin Hindman, and Ben Mahler.
On Aug. 6, 2015, 11:16 p.m., Jiang Yan Xu wrote:
src/slave/containerizer/mesos/containerizer.hpp, line 184
https://reviews.apache.org/r/37105/diff/2/?file=1032855#file1032855line184
Simple documentation on the return value?
This code will be removed soon. So I'll just leave as it
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37105/#review94598
---
Ship it!
Ship It!
- Jiang Yan Xu
On Aug. 5, 2015, 2:16 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37159/#review94601
---
Ship it!
Ship It!
- Timothy Chen
On Aug. 6, 2015, 4:20 a.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37194/
---
(Updated Aug. 8, 2015, 12:18 a.m.)
Review request for mesos, Ian Downes,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37244/
---
Review request for mesos, Anand Mazumdar and Ben Mahler.
Bugs: MESOS-3195
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37241/#review94605
---
Patch looks great!
Reviews applied: [37240, 37241]
All tests
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37196/
---
(Updated Aug. 8, 2015, 1:29 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37197/
---
(Updated Aug. 8, 2015, 1:30 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37198/
---
(Updated Aug. 8, 2015, 1:31 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/
---
(Updated Aug. 8, 2015, 1:32 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37200/
---
(Updated Aug. 8, 2015, 1:33 a.m.)
Review request for mesos and Timothy Chen.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/
---
Review request for mesos and Timothy Chen.
Bugs: MESOS-2850
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37246/
---
Review request for mesos and Timothy Chen.
Bugs: MESOS-2849
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37247/
---
Review request for mesos and Timothy Chen.
Bugs: MESOS-3021
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37237/#review94611
---
Patch looks great!
Reviews applied: [36929, 36930, 36954, 36956,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37244/#review94612
---
Patch looks great!
Reviews applied: [37244]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---
(Updated Aug. 8, 2015, 3:49 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/
---
(Updated Aug. 8, 2015, 3:50 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37252/
---
Review request for mesos and Ben Mahler.
Bugs: MESOS-3238
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37252/
---
(Updated Aug. 8, 2015, 4:14 a.m.)
Review request for mesos and Ben Mahler.
On Aug. 3, 2015, 7:45 p.m., Ben Mahler wrote:
src/master/http.cpp, line 958
https://reviews.apache.org/r/37023/diff/2/?file=1027280#file1027280line958
Could you fix this in a separate patch?
I split here. https://reviews.apache.org/r/37252/ Thank you very much!
- haosdent
On Aug. 3, 2015, 7:37 p.m., Ben Mahler wrote:
Thanks! Let's include the git / build information as well.
Another question, how are you planning to add this to the scheduler driver
and executor driver? In these cases, it is likely better to create a
'Version' Process with process id
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37023/#review94618
---
Patch looks great!
Reviews applied: [37023]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37252/#review94619
---
Patch looks great!
Reviews applied: [37252]
All tests passed.
-
92 matches
Mail list logo