Re: Review Request 37335: Fixed scheduler library tests after moving to http

2015-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37335/#review94873 --- Bad patch! Reviews applied: [37298, 37300, 37301, 37302] Failed

Review Request 37340: Added CERN to Mesos users list.

2015-08-10 Thread Artem Harutyunyan
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37340/ --- Review request for mesos, Benjamin Hindman and Michael Park. Repository: mesos

Re: Review Request 37340: Added CERN to Mesos users list.

2015-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37340/#review94878 --- Patch looks great! Reviews applied: [37340] All tests passed. -

Re: Review Request 37335: Fixed scheduler library tests after moving to http

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37335/ --- (Updated Aug. 11, 2015, 5:40 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 11, 2015, 5:53 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37165: Introduced v1 API.

2015-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37165/#review94746 --- src/Makefile.am (line 244)

Re: Review Request 37301: Scheduler tests

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- (Updated Aug. 10, 2015, 4:44 p.m.) Review request for mesos, Ben Mahler and

Review Request 37301: Scheduler tests

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552

Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 10, 2015, 4:45 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated Aug. 10, 2015, 5:29 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 36050: Added test authorizer module.

2015-08-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 10, 2015, 5:36 p.m.) Review request for mesos, Adam B, Bernd

Review Request 37303: Moved scheduler library to http

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552

Review Request 37298: Remove auth from scheduler library

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37298/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Review Request 37300: Disabled EventCallFramework test for now

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37300/ --- Review request for mesos, Ben Mahler and Vinod Kone. Bugs: MESOS-2552

Review Request 37309: Add app::paths which handles Appc related path manipulation.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37309/ --- Review request for mesos. Repository: mesos Description --- - Akin to

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review94776 --- 3rdparty/libprocess/3rdparty/CMakeLists.txt (line 55)

Re: Review Request 37298: Remove auth from scheduler library

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37298/#review94762 --- Ship it! Ship It! - Vinod Kone On Aug. 10, 2015, 4:42 p.m.,

Re: Review Request 37298: Remove auth from scheduler library

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37298/ --- (Updated Aug. 10, 2015, 5:27 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37300: Disabled EventCallFramework test for now

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37300/ --- (Updated Aug. 10, 2015, 5:27 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37165: Introduced v1 API.

2015-08-10 Thread haosdent huang
On Aug. 10, 2015, 2:57 p.m., haosdent huang wrote: haosdent huang wrote: If the order is 1. mv -f ../include/mesos/v1/mesos.pb.cc ../include/mesos/v1 2. mv -f ../include/mesos/v1/mesos.pb.cc v1 It would not left mesos.pb.cc in ../include/mesos/v1 If

Review Request 37310: Added Appc spec validation utility.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/ --- Review request for mesos, Chi Zhang, Ian Downes, and Jie Yu. Repository: mesos

Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/ --- Review request for mesos. Bugs: MESOS-3194

Re: Review Request 37165: Introduced v1 API.

2015-08-10 Thread haosdent huang
On Aug. 10, 2015, 2:57 p.m., haosdent huang wrote: If the order is 1. mv -f ../include/mesos/v1/mesos.pb.cc ../include/mesos/v1 2. mv -f ../include/mesos/v1/mesos.pb.cc v1 It would not left mesos.pb.cc in ../include/mesos/v1 If the order is 1. mv -f ../include/mesos/v1/mesos.pb.cc v1 2.

Re: Review Request 37263: Add support for non-subscribe HTTP calls in the master.

2015-08-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37263/#review94768 --- src/master/http.cpp (lines 396 - 398)

Re: Review Request 37272: [1/3]Remove thread_tests.cpp in stout.

2015-08-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37272/#review94775 --- See my review in #37291. There are a few changes we've made

Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/ --- Review request for mesos, Ian Downes, Jie Yu, Timothy Chen, and Vinod Kone.

Re: Review Request 37273: [2/3]Add CMake macro VsBuildCommand in libprocess.

2015-08-10 Thread Alex Clemmer
On Aug. 10, 2015, 6:42 p.m., Alex Clemmer wrote: 3rdparty/libprocess/3rdparty/glog-0.3.3.patch, line 21 https://reviews.apache.org/r/37273/diff/2/?file=1036048#file1036048line21 Looks like your updating the patchfile here to include my glog PR that opens it to working on MSVC

Re: Review Request 37310: Added Appc spec validation utility.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/ --- (Updated Aug. 10, 2015, 11:50 a.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37301: Scheduler tests

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/#review94769 --- src/tests/scheduler_tests.cpp (lines 166 - 170)

Re: Review Request 37291: Add missing unimplemented.hpp to windows specific OS code.

2015-08-10 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37291/#review94774 --- First, let me say thanks for putting this work in, and apologies

Review Request 37304: Add authorization for http based schedulers

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37304/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Re: Review Request 37301: Scheduler tests

2015-08-10 Thread Anand Mazumdar
On Aug. 10, 2015, 6:17 p.m., Vinod Kone wrote: src/tests/scheduler_tests.cpp, lines 167-171 https://reviews.apache.org/r/37301/diff/1/?file=1036461#file1036461line167 I'm confused. Just because we are not using authentication, we are getting a new event here? Why didn't we

Review Request 37308: Added AppcImageManifest protobuf.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37308/ --- Review request for mesos, Ian Downes and Jie Yu. Bugs: MESOS-3194

Re: Review Request 37291: Add missing unimplemented.hpp to windows specific OS code.

2015-08-10 Thread haosdent huang
On Aug. 10, 2015, 6:26 p.m., Alex Clemmer wrote: First, let me say thanks for putting this work in, and apologies for not communicating the exact status of the port ahead of time -- we're in a rush to get things in shape for MesosCon, and a lot of things are in the air right now.

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 10, 2015, 6:46 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 10, 2015, 6:47 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37310: Added Appc spec validation utility.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37310/ --- (Updated Aug. 10, 2015, 12:18 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37307/#review94792 --- include/mesos/mesos.proto (line 1208)

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-10 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 10, 2015, 4:35 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37189: Added std::hash template specializations.

2015-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94748 --- Patch looks great! Reviews applied: [37187, 37188, 37189] All

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-10 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/#review94781 --- Ship it! Maybe the code around checking for acceptable headers

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/ --- (Updated Aug. 10, 2015, 12:19 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37303: Moved scheduler library to http

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review94777 --- looks like the SchedulerTest.Subscribe test failed?

Re: Review Request 37315: Added basic authentication documentation

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37315/#review94799 --- Thanks for doing this. Looking pretty good, just some minor

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-10 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36402/ --- (Updated Aug. 10, 2015, 9:52 p.m.) Review request for mesos, Anand Mazumdar,

Review Request 37322: Added filesystem isolator tests to test volumes from the host.

2015-08-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37322/ --- Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen,

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/#review94814 --- src/slave/containerizer/provisioners/appc/store.cpp (line 63)

Review Request 37315: Added basic authentication documentation

2015-08-10 Thread Tim Anderegg
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37315/ --- Review request for mesos. Bugs: MESOS-1838

Re: Review Request 37315: Added basic authentication documentation

2015-08-10 Thread Tim Anderegg
On Aug. 10, 2015, 9:33 p.m., Vinod Kone wrote: Thanks for doing this. Looking pretty good, just some minor comments. Thanks for taking the time to review, Vinod. I'll make those changes tomorrow. - Tim --- This is an automatically

Re: Review Request 36402: Adding 'Accept' header in request

2015-08-10 Thread Isabel Jimenez
On Aug. 10, 2015, 7:03 p.m., Marco Massenzio wrote: 3rdparty/libprocess/src/http.cpp, lines 219-220 https://reviews.apache.org/r/36402/diff/10/?file=1032819#file1032819line219 I'm not sure I understand why you do this. Can you please comment or explain? Here we introduce two

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37311/#review94810 --- Patch looks great! Reviews applied: [37307, 37308, 37309, 37310,

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/ --- (Updated Aug. 10, 2015, 10:13 p.m.) Review request for mesos, Lily Chen, Ian

Re: Review Request 37197: Docker image store.

2015-08-10 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37197/ --- (Updated Aug. 10, 2015, 10:30 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37304: Add authorization for http based schedulers

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37304/#review94819 --- Ship it! src/master/master.cpp (line 1828)

Re: Review Request 37198: Add Docker image provisioner and copy backend.

2015-08-10 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37198/ --- (Updated Aug. 10, 2015, 10:47 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37311: Implemented a 'read-only' Appc image store.

2015-08-10 Thread Jiang Yan Xu
On Aug. 10, 2015, 3:20 p.m., Timothy Chen wrote: src/tests/containerizer/appc_provisioner_tests.cpp, line 119 https://reviews.apache.org/r/37311/diff/2/?file=1036569#file1036569line119 Btw looking at this and the read-only store, is there documentation around how users can

Re: Review Request 37322: Added filesystem isolator tests to test volumes from the host.

2015-08-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37322/#review94828 --- Ship it! Ship It! - Timothy Chen On Aug. 10, 2015, 10:15 p.m.,

Re: Review Request 37247: Added Docker image reference store.

2015-08-10 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/ --- (Updated Aug. 10, 2015, 10:53 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 36811: Don't check protobuf jar when --disable-java flag.

2015-08-10 Thread Cody Maloney
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36811/#review94830 --- Ship it! Looks reasonable for me. Not run/tested locally for

Re: Review Request 37196: Add Docker Image type to Container Image protobuf.

2015-08-10 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37196/ --- (Updated Aug. 10, 2015, 10:30 p.m.) Review request for mesos, Ian Downes, Jie

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

2015-08-10 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/ --- (Updated Aug. 10, 2015, 10:54 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-10 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review94622 --- src/slave/containerizer/isolators/filesystem/linux.cpp (line 370)

Review Request 37326: Added a TODO on recordio::Decoder for EOF semantics.

2015-08-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37326/ --- Review request for mesos, Anand Mazumdar and Vinod Kone. Repository: mesos

Review Request 37327: Added a recordio::Reader for wrapping an http::Pipe::Reader.

2015-08-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37327/ --- Review request for mesos, Anand Mazumdar, Benjamin Hindman, Jie Yu, and Vinod

Re: Review Request 37327: Added a recordio::Reader for wrapping an http::Pipe::Reader.

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37327/#review94831 --- Ship it! src/common/recordio.hpp (line 177)

Re: Review Request 37326: Added a TODO on recordio::Decoder for EOF semantics.

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37326/#review94834 --- Ship it! Ship It! - Vinod Kone On Aug. 10, 2015, 11:41 p.m.,

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 11, 2015, 12:17 a.m.) Review request for mesos, Ben Mahler and

Review Request 37328: Remove namespace ambiguity

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37328/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Re: Review Request 37303: Moved scheduler library to http

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- (Updated Aug. 11, 2015, 12:17 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 36720: Add subscribe- subscribed workflow for http frameworks

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36720/ --- (Updated Aug. 10, 2015, 7:20 p.m.) Review request for mesos, Ben Mahler and

Review Request 37335: Fixed scheduler library tests after moving to http

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37335/ --- Review request for mesos, Ben Mahler and Vinod Kone. Repository: mesos

Re: Review Request 37334: Added a persistent volume test for linux filesystem isolator.

2015-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37334/#review94857 --- Patch looks great! Reviews applied: [36929, 36930, 36954, 36956,

Re: Review Request 37304: Add authorization for http based schedulers

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37304/ --- (Updated Aug. 11, 2015, 3:24 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/ --- (Updated Aug. 11, 2015, 3:24 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37328: Remove namespace ambiguity

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37328/ --- (Updated Aug. 11, 2015, 3:24 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37335: Fixed scheduler library tests after moving to http

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37335/ --- (Updated Aug. 11, 2015, 3:25 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review94782 --- 3rdparty/libprocess/3rdparty/stout/include/stout/hashmap.hpp

Re: Review Request 37188: Added std::hash template specializations.

2015-08-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37188/#review94858 --- 3rdparty/libprocess/include/process/address.hpp (line 160)

Re: Review Request 37189: Added std::hash template specializations.

2015-08-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/#review94859 --- Looks good overall! Same question as

Re: Review Request 37187: Changed hashmap, hashset to use std::unordered_{set, map} instead of boost::unordered_{set, map}.

2015-08-10 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37187/#review94864 --- 3rdparty/libprocess/3rdparty/stout/include/stout/hashset.hpp

Re: Review Request 37300: Removed auth from example event call framework

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37300/#review94863 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 2:08 a.m.,

Re: Review Request 37301: Scheduler tests

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/#review94865 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 2:07 a.m.,

Re: Review Request 37302: Delete receive,install

2015-08-10 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37302/#review94867 --- Ship it! Ship It! - Vinod Kone On Aug. 11, 2015, 3:24 a.m.,

Re: Review Request 37307: Changed Image::AppC::id from required to optional.

2015-08-10 Thread Jiang Yan Xu
On Aug. 10, 2015, 1:29 p.m., Timothy Chen wrote: include/mesos/mesos.proto, line 1208 https://reviews.apache.org/r/37307/diff/1/?file=1036508#file1036508line1208 Should the user have the ability then to specify either a name or a id? If name is required then I don't see

Re: Review Request 37298: Remove auth from scheduler library

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37298/ --- (Updated Aug. 11, 2015, 2:08 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37301: Scheduler tests

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37301/ --- (Updated Aug. 11, 2015, 2:07 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37300: Removed auth from example event call framework

2015-08-10 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37300/ --- (Updated Aug. 11, 2015, 2:08 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37240: Added support to handle queries to nested HTTP paths.

2015-08-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37240/#review94827 --- Ship it! 3rdparty/libprocess/include/process/http.hpp (line 112)

Re: Review Request 37247: Added Docker image reference store.

2015-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37247/#review94840 --- Bad patch! Reviews applied: [37196, 37197, 37198, 37199, 37200,

Re: Review Request 37328: Remove namespace ambiguity

2015-08-10 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37328/#review94849 --- Patch looks great! Reviews applied: [37300, 37328] All tests

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/ --- (Updated Aug. 11, 2015, 1:57 a.m.) Review request for mesos, Lily Chen, Ian

Re: Review Request 37303: Moved scheduler library to http

2015-08-10 Thread Anand Mazumdar
On Aug. 10, 2015, 7:52 p.m., Vinod Kone wrote: src/common/http.hpp, line 73 https://reviews.apache.org/r/37303/diff/1/?file=1036466#file1036466line73 this helper seems weird. i would rather have isOK()and isAccepted() helpers. anyway, this seems to be used only once.

Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/ --- Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen,

Re: Review Request 37327: Added a recordio::Reader for wrapping an http::Pipe::Reader.

2015-08-10 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37327/ --- (Updated Aug. 11, 2015, 12:41 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 37327: Added a recordio::Reader for wrapping an http::Pipe::Reader.

2015-08-10 Thread Ben Mahler
On Aug. 11, 2015, 12:13 a.m., Vinod Kone wrote: Added to the documentation that the caller is responsible for closing the pipe reader when a failure or end-of-file is encountered. On Aug. 11, 2015, 12:13 a.m., Vinod Kone wrote: src/common/recordio.hpp, line 177

Review Request 37334: Added a persistent volume test for linux filesystem isolator.

2015-08-10 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37334/ --- Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen,

Re: Review Request 37189: Added std::hash template specializations.

2015-08-10 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37189/ --- (Updated Aug. 10, 2015, 10:51 a.m.) Review request for mesos, Alexander Rojas

Re: Review Request 37259: libprocess: Fixed break before braces style for 'enum'.

2015-08-10 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37259/#review94714 --- Ship it! Ship It! - Till Toenshoff On Aug. 10, 2015, 12:59

Re: Review Request 37275: [3/3]Generate make batch file to build project in windows.

2015-08-10 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/ --- (Updated Aug. 10, 2015, 9:52 a.m.) Review request for mesos and Alex Clemmer.

  1   2   >