Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 4:56 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 18723: Prevent gflags detection from glog configuration phase

2015-08-12 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18723/ --- (Updated Aug. 12, 2015, 2:50 p.m.) Review request for mesos and Benjamin

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review95168 --- Ship it! Ship It! - Joseph Wu On Aug. 10, 2015, 12:05 a.m.,

Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog

2015-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/ --- (Updated Aug. 12, 2015, 9:04 p.m.) Review request for mesos, Joris Van

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-12 Thread Marco Massenzio
On Aug. 6, 2015, 9:56 a.m., Alexander Rojas wrote: 3rdparty/libprocess/include/process/http.hpp, line 754 https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754 I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right

Re: Review Request 37277: (WIP) Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-12 Thread Vinod Kone
On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote: src/master/master.hpp, line 1288 https://reviews.apache.org/r/37277/diff/1/?file=1035712#file1035712line1288 ? oops. fixed. On Aug. 11, 2015, 6:01 p.m., Ben Mahler wrote: src/master/master.hpp, line 1290

Re: Review Request 37277: Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37277/ --- (Updated Aug. 13, 2015, 12:01 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote: This thing is rather complex and it deals with Mesos managed persisetent volumes and other system volumes in different but related ways; rootfs may or may not be used; and we'll provision image volumes later. I hope we iterate on this

Re: Review Request 37422: Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37422/#review95205 --- Ship it! Ideally we can verify in both cases the host mount table

Re: Review Request 37405: Adding HTTP Method check to the scheduler endpoint

2015-08-12 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37405/ --- (Updated Aug. 12, 2015, 8:35 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review95182 --- src/master/master.cpp (line 2716)

Re: Review Request 37334: Added a persistent volume test for linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37334/#review95200 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 10, 2015, 6:58 p.m.,

Review Request 37423: Split out common functions for running perf into a common perf class with wrapper functions to allow for reuse between sample, valid and version operations.

2015-08-12 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37423/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-3185

Review Request 37417: Convert Perf event validator to use new shared object.

2015-08-12 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37417/ --- Review request for mesos. Repository: mesos Description --- Convert

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/ --- (Updated Aug. 12, 2015, 3:07 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 10:59 p.m., Jiang Yan Xu wrote: include/mesos/mesos.proto, line 1255 https://reviews.apache.org/r/37236/diff/3/?file=1038690#file1038690line1255 There is another reference to Absoluate path here which should be updated. It says ... or a path relative to the

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/#review95175 --- Ship it! The protobuf changes could be moved up the chain to

Re: Review Request 37405: Adding HTTP Method check to the scheduler endpoint

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37405/#review95183 --- Patch looks great! Reviews applied: [37403, 37405] All tests

Review Request 37420: Added note regarding glog and gflags to documentation

2015-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37420/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs:

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- (Updated Aug. 12, 2015, 10:26 p.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37414: Fix flaky ExamplesTest.JavaLog

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/#review95193 --- Patch looks great! Reviews applied: [37414] All tests passed. -

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95192 --- Ship it! Ship It! - Timothy Chen On Aug. 12, 2015, 6:54 p.m.,

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37237/#review95194 --- Ship it! Ship It! - Timothy Chen On Aug. 8, 2015, 12:32 a.m.,

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/ --- (Updated Aug. 12, 2015, 8:29 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/ --- (Updated Aug. 12, 2015, 9:09 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/#review95172 --- Why are the InverseOffers (and Offers) hashed as pointers?

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote: src/slave/containerizer/isolators/filesystem/linux.cpp, line 485 https://reviews.apache.org/r/37330/diff/2/?file=1037046#file1037046line485 s/other/another/ 'other' sounds fine to me here. On Aug. 12, 2015, 10:47 p.m., Jiang Yan

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/ --- (Updated Aug. 12, 2015, 11:21 p.m.) Review request for mesos, Lily Chen, Ian

Re: Review Request 37415: Fix flaky ExamplesTest.JavaFramework

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/#review95203 --- Patch looks great! Reviews applied: [37415] All tests passed. -

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/#review95154 --- This thing is rather complex and it deals with Mesos managed

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95195 --- include/mesos/mesos.proto (line 1255)

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95198 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 12, 2015, 11:54 a.m.,

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/ --- (Updated Aug. 12, 2015, 11:12 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
On Aug. 12, 2015, 3:59 p.m., Jiang Yan Xu wrote: include/mesos/mesos.proto, line 1255 https://reviews.apache.org/r/37236/diff/3/?file=1038690#file1038690line1255 There is another reference to Absoluate path here which should be updated. Jie Yu wrote: It says ... or a path

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review95165 --- include/mesos/maintenance/maintenance.hpp (line 33)

Re: Review Request 37410: Disallow copy construction/assignment

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37410/#review95170 --- Patch looks great! Reviews applied: [37410] All tests passed. -

Re: Review Request 37268: Style checker checking for { on newline

2015-08-12 Thread José Guilherme Vanz
On Aug. 9, 2015, 11:28 p.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [37266] Failed command: ./support/apply-review.sh -n -r 37266 Error: 2015-08-09 23:28:17 URL:https://reviews.apache.org/r/37266/diff/raw/ [8119/8119] - 37266.patch [1] Traceback (most recent

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37330/#review95208 --- Ship it! Ship It! - Jiang Yan Xu On Aug. 12, 2015, 4:21 p.m.,

Review Request 37414: Add sleep to TestLog.java

2015-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37414/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs:

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 10:47 p.m., Jiang Yan Xu wrote: src/slave/containerizer/isolators/filesystem/linux.cpp, line 579 https://reviews.apache.org/r/37330/diff/2/?file=1037046#file1037046line579 What happens when persistent volumes are used without a new rootfs? Jie Yu wrote:

Review Request 37415: Fix flaky ExamplesTest.JavaFramework

2015-08-12 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37415/ --- Review request for mesos, Joris Van Remoortere and Till Toenshoff. Bugs:

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review95179 --- Ship it! Ship It! - Joseph Wu On Aug. 10, 2015, 12:06 a.m.,

Re: Review Request 37422: Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.

2015-08-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37422/ --- (Updated Aug. 12, 2015, 11:34 p.m.) Review request for mesos, Lily Chen, Ian

Review Request 37422: Added a persistent volume test for linux filesystem isolator to test case where the container does not specify a root filesystem.

2015-08-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37422/ --- Review request for mesos, Lily Chen, Ian Downes, Jojy Varghese, Timothy Chen,

Review Request 37424: Timeout the perf future if the process does not complete.

2015-08-12 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37424/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 37168: MESOS-3063

2015-08-12 Thread haosdent huang
On Aug. 13, 2015, 2:56 a.m., haosdent huang wrote: Hi, @klaus1982 Thanks you for you nice example. I think you need add your Shepherd as reviewer in this patch. - haosdent --- This is an automatically generated e-mail. To reply,

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review95230 --- Bad patch! Reviews applied: [37426, 37427] Failed command:

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review95231 --- Patch looks great! Reviews applied: [37423, 37424, 37417, 37416]

Review Request 37426: MESOS-3251 : Fixing host field of request header.

2015-08-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37426/ --- Review request for mesos, Anand Mazumdar and Timothy Chen. Bugs: MESOS-3251

Review Request 37427: Docker registry: adding TokenManager.

2015-08-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- Review request for mesos, Lily Chen and Timothy Chen. Repository: mesos

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/#review95220 --- Ship it! Ship It! - Cong Wang On Aug. 12, 2015, 9:09 p.m., Paul

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/#review95210 --- Patch looks great! Reviews applied: [37399] All tests passed. -

Re: Review Request 37277: Added Heartbeater to master to send periodic heartbeats to HTTP schedulers.

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37277/#review95225 --- Patch looks great! Reviews applied: [37277] All tests passed. -

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-12 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 13, 2015, 4:47 a.m.) Review request for mesos, Lily Chen and

Re: Review Request 37168: MESOS-3063

2015-08-12 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review95227 --- src/examples/dynamic_reservation_framework.cpp (line 267)

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-12 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/#review95235 --- src/linux/perf.cpp (line 411)

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-12 Thread haosdent huang
On Aug. 12, 2015, 4:47 p.m., Alexander Rojas wrote: src/cli/python/mesos/__init__.py, line 1 https://reviews.apache.org/r/36819/diff/6/?file=1034329#file1034329line1 Why was the shebang line removed? The origin file is __init__.py. __init__.py need have shebang line. But this file

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- (Updated Aug. 13, 2015, 5:39 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/#review95226 --- src/common/http.hpp (line 51)

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-12 Thread Timothy Chen
On Aug. 12, 2015, 6:13 p.m., Timothy Chen wrote: src/slave/flags.cpp, line 391 https://reviews.apache.org/r/37114/diff/2/?file=1034775#file1034775line391 This will cause problem in the docker containerizer since we also try to mount in the socket when we launch executors in a

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/#review95236 --- src/slave/containerizer/isolators/network/port_mapping.cpp (lines

Re: Review Request 37420: Added note regarding glog and gflags to documentation

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37420/#review95217 --- Patch looks great! Reviews applied: [37420] All tests passed. -

Re: Review Request 37328: Remove namespace ambiguity

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37328/ --- (Updated Aug. 13, 2015, 5:43 a.m.) Review request for mesos, Ben Mahler and

Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-12 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- Review request for mesos and Ben Mahler. Repository: mesos Description

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95065 --- Patch looks great! Reviews applied: [37382] All tests passed. -

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95069 --- Ship it! Ship It!

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37303/ --- (Updated Aug. 12, 2015, 6:51 a.m.) Review request for mesos, Ben Mahler and

Re: Review Request 37303: Moved scheduler library to http

2015-08-12 Thread Anand Mazumdar
On Aug. 12, 2015, 5:09 a.m., Ben Mahler wrote: Sorry for not elaborating on all of these, I added some more explanations here. Main thing is cleaning up the read loop and figuring out the callback semantics (do we need to revisit 'connected' / 'disconnected'?). Let's keep the callback

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95096 --- include/mesos/authorizer/authorizer.hpp (line 139)

Re: Review Request 37382: Introduced provisioner Backend interface.

2015-08-12 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37382/#review95113 --- src/slave/containerizer/provisioners/backend.hpp (line 52)

Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 36620: WIP Added Non-Freezeer Task Killer.

2015-08-12 Thread Timothy Chen
On July 28, 2015, 7:20 p.m., Timothy Chen wrote: I notice there are no new tests added for this, can you add a test to verify the new change works? Are you able to add this? Otherwise let's add a TODO and get this in. - Timothy

Re: Review Request 36819: Use setup.py in python cli package.

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36819/#review95112 --- src/cli/python/mesos/__init__.py

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95106 --- Good points Alex, can you leave comments on this in the code of to

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Alexander Rojas
On Aug. 12, 2015, 5:57 p.m., Timothy Chen wrote: include/mesos/authorizer/authorizer.hpp, line 139 https://reviews.apache.org/r/36048/diff/16/?file=1038383#file1038383line139 Space between operator and The rule changed, we no longer put spaces between operators. Check commit

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-12 Thread Bernd Mathiske
On Aug. 6, 2015, 2:56 a.m., Alexander Rojas wrote: 3rdparty/libprocess/include/process/http.hpp, line 754 https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754 I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Bernd Mathiske
On Aug. 12, 2015, 6:04 a.m., Bernd Mathiske wrote: include/mesos/authorizer/authorizer.hpp, line 49 https://reviews.apache.org/r/36048/diff/15/?file=1036353#file1036353line49 If this is only relevant for the default implementation, then this method should be declared there, not

Re: Review Request 36847: Added HTTP Delete Method.

2015-08-12 Thread Bernd Mathiske
On Aug. 6, 2015, 2:56 a.m., Alexander Rojas wrote: 3rdparty/libprocess/include/process/http.hpp, line 754 https://reviews.apache.org/r/36847/diff/7/?file=1028524#file1028524line754 I'm rather late to the party, but AFAIK Mesos appreciates consistency over doing some things right

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/#review95079 --- include/mesos/authorizer/authorizer.hpp (line 48)

Re: Review Request 36049: Added support for modularized Authorizer

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36049/ --- (Updated Aug. 12, 2015, 3:52 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 36050: Added test authorizer module.

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36050/ --- (Updated Aug. 12, 2015, 3:52 p.m.) Review request for mesos, Adam B, Bernd

Re: Review Request 36048: Updated authorizer to allow for modularized implementations.

2015-08-12 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36048/ --- (Updated Aug. 12, 2015, 3:52 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/#review95126 --- Patch looks great! Reviews applied: [37399] All tests passed. -

Re: Review Request 37114: MESOS-3187, support docker host command line option

2015-08-12 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37114/#review95137 --- src/docker/executor.hpp (line 43)

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/#review95142 --- include/mesos/master/allocator.hpp (lines 96 - 101)

Re: Review Request 37237: Added a few MesosContainerizer filesystem tests to test the linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 6:16 p.m., Jiang Yan Xu wrote: src/tests/containerizer/provisioner.hpp, line 34 https://reviews.apache.org/r/37237/diff/3/?file=1035029#file1035029line34 Should this be called MockProvisioner? I think we use TestXYZ to 'XYZ that faciliates tests' and MockXYZ for

Re: Review Request 37405: Adding HTTP Method check to the scheduler endpoint

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37405/#review95144 --- Ship it! LGTM ! src/tests/http_api_tests.cpp (line 601)

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-08-12 Thread Joseph Wu
On Aug. 12, 2015, 12:01 p.m., Joseph Wu wrote: include/mesos/master/allocator.hpp, lines 96-101 https://reviews.apache.org/r/37173/diff/2/?file=1035790#file1035790line96 I'm not convinced that `addSlave` is the appropriate place to pass the unavailability. This

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
On Aug. 12, 2015, 6:31 p.m., Anand Mazumdar wrote: src/master/http.cpp, line 395 https://reviews.apache.org/r/37403/diff/1/?file=1038481#file1038481line395 This would crash if there was no accept header specified ? No this can only enter the if with an accept header - Isabel

Re: Review Request 37330: Added persistent volume support for linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 1:43 a.m., Timothy Chen wrote: src/slave/containerizer/isolators/filesystem/linux.cpp, line 399 https://reviews.apache.org/r/37330/diff/2/?file=1037046#file1037046line399 Can we also log the container id and it's the linux filesystem isolator? It's much easier

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/#review95122 --- Ship it!

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

2015-08-12 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/#review95119 --- Ship it! src/master/master.hpp (line 106)

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote: src/slave/containerizer/isolators/filesystem/linux.cpp, lines 267-269 https://reviews.apache.org/r/37236/diff/2/?file=1036681#file1036681line267 mesos.proto documentation on Volume::container_path and Volume::host_path both require

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37403/#review95135 --- Mainly comments around us having Accept header validations for all

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 11, 2015, 9:06 p.m., Jiang Yan Xu wrote: src/slave/containerizer/isolators/filesystem/linux.cpp, lines 318-335 https://reviews.apache.org/r/37236/diff/2/?file=1036681#file1036681line318 So this is the case where the target is expected to be within the work dir because a

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/#review95139 --- src/slave/containerizer/isolators/filesystem/linux.hpp (lines 105

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jie Yu
On Aug. 12, 2015, 6:44 p.m., Jiang Yan Xu wrote: src/slave/containerizer/isolators/filesystem/linux.hpp, lines 105-106 https://reviews.apache.org/r/37236/diff/2/?file=1036680#file1036680line105 So this field is really for https://reviews.apache.org/r/37330 but we are not

Re: Review Request 37403: Using AcceptMediaType Request method to validate Accept header

2015-08-12 Thread Isabel Jimenez
On Aug. 12, 2015, 6:31 p.m., Anand Mazumdar wrote: src/master/http.cpp, line 391 https://reviews.apache.org/r/37403/diff/1/?file=1038481#file1038481line391 Check my earlier comment on how we can simplify this. Also , we need to do Accept header validations for ALL call types and

Re: Review Request 37236: Added the linux filesystem isolator.

2015-08-12 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37236/ --- (Updated Aug. 12, 2015, 6:54 p.m.) Review request for mesos, Lily Chen, Ian

Re: Review Request 37399: Ignore no statistics condition for containers with no qdisc.

2015-08-12 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37399/#review95124 --- src/slave/containerizer/isolators/network/port_mapping.cpp (line

  1   2   >