Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-08-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review95972 --- src/tests/mesos.hpp (line 965)

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

2015-08-20 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/ --- (Updated Aug. 20, 2015, 10:03 a.m.) Review request for mesos, Benjamin

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-08-20 Thread haosdent huang
On Aug. 20, 2015, 5:02 p.m., Jie Yu wrote: src/tests/mesos.hpp, line 965 https://reviews.apache.org/r/36185/diff/10/?file=1044480#file1044480line965 Could you please move this to a separate header file like? ``` src/tests/containerizer/docker.hpp ``` Thank you.

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-08-20 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/ --- (Updated Aug. 20, 2015, 8:03 a.m.) Review request for mesos and Joris Van

Re: Review Request 37617: Added an error message to MesosContainerizerLaunch command.

2015-08-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37617/#review95930 --- Patch looks great! Reviews applied: [37617] All tests passed. -

Re: Review Request 37336: [WIP] Added `wait()` method to process::Subprocess

2015-08-20 Thread Marco Massenzio
On Aug. 17, 2015, 11:01 p.m., Ben Mahler wrote: In the same vein as os::shell, we should probably introduce an 'os' namespace in libprocess for asynchronous os utilities. In this case, process::os::shell which returns a Future of the output (although, ideally status, output, error).

Re: Review Request 36185: Create pre-launch hook before a docker container launches in slave.

2015-08-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36185/#review95932 --- Patch looks great! Reviews applied: [36185] All tests passed. -

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Aug. 21, 2015, 4:06 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Aug. 21, 2015, 12:48 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-20 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36620/ --- (Updated Aug. 20, 2015, 11:42 a.m.) Review request for mesos, Benjamin Hindman

Review Request 37669: Ignore overflow components in version parsing.

2015-08-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- Review request for mesos, Isabel Jimenez and Timothy Chen. Bugs: MESOS-2986

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Aug. 20, 2015, 11 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Aug. 20, 2015, 11:51 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.

2015-08-20 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/#review96020 --- docs/docker-containerizer.md (line 21)

Re: Review Request 37531: MESOS-3070

2015-08-20 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/ --- (Updated 八月 21, 2015, 2:10 a.m.) Review request for mesos. Bugs: MESOS-3070

Re: Review Request 37531: MESOS-3070

2015-08-20 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/#review95670 --- src/master/master.cpp (line 3218)

Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.

2015-08-20 Thread Klaus Ma
On 八月 21, 2015, 1:26 a.m., Klaus Ma wrote: docs/docker-containerizer.md, line 21 https://reviews.apache.org/r/37657/diff/1/?file=1045176#file1045176line21 I'm also not a native speaker, but i'd suggest to: If *iptables* enabled on slave, make sure *iptables* accept all

Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.

2015-08-20 Thread haosdent huang
On Aug. 21, 2015, 1:26 a.m., Klaus Ma wrote: docs/docker-containerizer.md, line 21 https://reviews.apache.org/r/37657/diff/1/?file=1045176#file1045176line21 I'm also not a native speaker, but i'd suggest to: If *iptables* enabled on slave, make sure *iptables* accept

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Aug. 20, 2015, 11:49 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Aug. 21, 2015, midnight) Review request for mesos and Ben Mahler.

Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.

2015-08-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/#review95994 --- Ship it! Ship It! - Timothy Chen On Aug. 20, 2015, 5:30 p.m.,

Review Request 37657: Document iptable rule need added when use docker bridge network mode.

2015-08-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/ --- Review request for mesos and Timothy Chen. Bugs: MESOS-3053

Re: Review Request 37460: Prevent perf test failures from killing the test harness.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37460/ --- (Updated Aug. 20, 2015, 5:52 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37657: Document iptable rule need added when use docker bridge network mode.

2015-08-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37657/#review95995 --- Patch looks great! Reviews applied: [37657] All tests passed. -

Re: Review Request 37442: Factor out the token extraction rules in prepartion for extending them to cope with multiple versions.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37442/ --- (Updated Aug. 20, 2015, 5:31 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37655: MESOS-3299: Add protobuf to represent time with integer precision.

2015-08-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37655/#review95981 --- Patch looks great! Reviews applied: [37655] All tests passed. -

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-20 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 20, 2015, 3:50 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37462: Add support for version detection and parsing.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Aug. 20, 2015, 7:17 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37532: Add QUIESCE call interface to the scheduler

2015-08-20 Thread Marco Massenzio
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37532/#review95997 --- include/mesos/scheduler.hpp (line 273)

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/#review96006 --- src/slave/containerizer/provisioners/docker/store.cpp (line 56)

Re: Review Request 37200: Refactored DockerImage struct to store a list of layer ids instead of linked list of DockerLayers.

2015-08-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37200/#review96007 --- src/slave/containerizer/provisioners/docker.hpp (line 54)

Re: Review Request 37245: Refactor Docker Image to exclude path and manifest.

2015-08-20 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37245/#review96008 --- Can we squash this to ImageName commit? - Timothy Chen On Aug.

Re: Review Request 37199: Added store interface and moved store implementation to LocalStore subclass.

2015-08-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37199/#review96010 --- Bad patch! Reviews applied: [37196, 37197, 37198, 37199] Failed

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-08-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37336/#review95936 --- Patch looks great! Reviews applied: [37336] All tests passed. -

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-20 Thread Paul Brett
On Aug. 19, 2015, 1:42 a.m., Ben Mahler wrote: src/linux/perf.cpp, lines 474-478 https://reviews.apache.org/r/37416/diff/3/?file=1043975#file1043975line474 Why `_supported` here that takes a version? Why not just have supported compute the version and then perform the necessary

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37416/ --- (Updated Aug. 20, 2015, 4:39 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review95969 --- Patch looks great! Reviews applied: [37426, 37427] All tests

Re: Review Request 37416: Perf supported() should be based on the version of perf, not the version of the kernel.

2015-08-20 Thread Paul Brett
On Aug. 19, 2015, 1:42 a.m., Ben Mahler wrote: src/linux/perf.cpp, lines 484-490 https://reviews.apache.org/r/37416/diff/3/?file=1043975#file1043975line484 Couple of things: (1) Let's add a comment as to why we're using await here, since it is an anti-pattern.

Re: Review Request 37617: Added an error message to MesosContainerizerLaunch command.

2015-08-20 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37617/#review95960 --- Ship it! Ship It! - Jie Yu On Aug. 19, 2015, 6:26 p.m., Jie Yu