---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36185/#review95972
---
src/tests/mesos.hpp (line 965)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/
---
(Updated Aug. 20, 2015, 10:03 a.m.)
Review request for mesos, Benjamin
On Aug. 20, 2015, 5:02 p.m., Jie Yu wrote:
src/tests/mesos.hpp, line 965
https://reviews.apache.org/r/36185/diff/10/?file=1044480#file1044480line965
Could you please move this to a separate header file like?
```
src/tests/containerizer/docker.hpp
```
Thank you.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37617/#review95930
---
Patch looks great!
Reviews applied: [37617]
All tests passed.
-
On Aug. 17, 2015, 11:01 p.m., Ben Mahler wrote:
In the same vein as os::shell, we should probably introduce an 'os'
namespace in libprocess for asynchronous os utilities. In this case,
process::os::shell which returns a Future of the output (although, ideally
status, output, error).
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36185/#review95932
---
Patch looks great!
Reviews applied: [36185]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37466/
---
(Updated Aug. 21, 2015, 4:06 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37462/
---
(Updated Aug. 21, 2015, 12:48 a.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36620/
---
(Updated Aug. 20, 2015, 11:42 a.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/
---
Review request for mesos, Isabel Jimenez and Timothy Chen.
Bugs: MESOS-2986
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37466/
---
(Updated Aug. 20, 2015, 11 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37466/
---
(Updated Aug. 20, 2015, 11:51 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37657/#review96020
---
docs/docker-containerizer.md (line 21)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37531/
---
(Updated 八月 21, 2015, 2:10 a.m.)
Review request for mesos.
Bugs: MESOS-3070
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37531/#review95670
---
src/master/master.cpp (line 3218)
On 八月 21, 2015, 1:26 a.m., Klaus Ma wrote:
docs/docker-containerizer.md, line 21
https://reviews.apache.org/r/37657/diff/1/?file=1045176#file1045176line21
I'm also not a native speaker, but i'd suggest to:
If *iptables* enabled on slave, make sure *iptables* accept all
On Aug. 21, 2015, 1:26 a.m., Klaus Ma wrote:
docs/docker-containerizer.md, line 21
https://reviews.apache.org/r/37657/diff/1/?file=1045176#file1045176line21
I'm also not a native speaker, but i'd suggest to:
If *iptables* enabled on slave, make sure *iptables* accept
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37462/
---
(Updated Aug. 20, 2015, 11:49 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37462/
---
(Updated Aug. 21, 2015, midnight)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37657/#review95994
---
Ship it!
Ship It!
- Timothy Chen
On Aug. 20, 2015, 5:30 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37657/
---
Review request for mesos and Timothy Chen.
Bugs: MESOS-3053
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37460/
---
(Updated Aug. 20, 2015, 5:52 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37657/#review95995
---
Patch looks great!
Reviews applied: [37657]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37442/
---
(Updated Aug. 20, 2015, 5:31 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37655/#review95981
---
Patch looks great!
Reviews applied: [37655]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 20, 2015, 3:50 p.m.)
Review request for mesos, Lily Chen, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37462/
---
(Updated Aug. 20, 2015, 7:17 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37532/#review95997
---
include/mesos/scheduler.hpp (line 273)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/#review96006
---
src/slave/containerizer/provisioners/docker/store.cpp (line 56)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37200/#review96007
---
src/slave/containerizer/provisioners/docker.hpp (line 54)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37245/#review96008
---
Can we squash this to ImageName commit?
- Timothy Chen
On Aug.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37199/#review96010
---
Bad patch!
Reviews applied: [37196, 37197, 37198, 37199]
Failed
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37336/#review95936
---
Patch looks great!
Reviews applied: [37336]
All tests passed.
-
On Aug. 19, 2015, 1:42 a.m., Ben Mahler wrote:
src/linux/perf.cpp, lines 474-478
https://reviews.apache.org/r/37416/diff/3/?file=1043975#file1043975line474
Why `_supported` here that takes a version? Why not just have supported
compute the version and then perform the necessary
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37416/
---
(Updated Aug. 20, 2015, 4:39 p.m.)
Review request for mesos and Ben Mahler.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/#review95969
---
Patch looks great!
Reviews applied: [37426, 37427]
All tests
On Aug. 19, 2015, 1:42 a.m., Ben Mahler wrote:
src/linux/perf.cpp, lines 484-490
https://reviews.apache.org/r/37416/diff/3/?file=1043975#file1043975line484
Couple of things:
(1) Let's add a comment as to why we're using await here, since it is
an anti-pattern.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37617/#review95960
---
Ship it!
Ship It!
- Jie Yu
On Aug. 19, 2015, 6:26 p.m., Jie Yu
38 matches
Mail list logo