Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

2015-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review96849 --- Patch looks great! Reviews applied: [37714] All tests passed. -

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-6.6-gcc-4.8.

2015-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/#review96848 --- Patch looks great! Reviews applied: [37787] All tests passed. -

Re: Review Request 37531: MESOS-3070

2015-08-28 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37531/ --- (Updated Aug. 28, 2015, 9:48 a.m.) Review request for mesos. Changes ---

Review Request 37892: Renamed cgroups::kill to cgroups::signal

2015-08-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37892/ --- Review request for mesos. Bugs: MESOS-3086

Re: Review Request 37891: Fetcher now does not erroneously report a non-archive when extracting from one.

2015-08-28 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37891/ --- (Updated Aug. 28, 2015, 8:51 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-28 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36321/#review96866 --- include/mesos/mesos.proto (line 876)

Re: Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

2015-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37914/#review96977 --- Patch looks great! Reviews applied: [37914] All tests passed. -

Re: Review Request 37908: Silence oversubscription logging

2015-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37908/#review96974 --- Patch looks great! Reviews applied: [37908] All tests passed. -

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Jie Yu
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... IMO, that naming is confusing, and should be 'signal' and 'install'. - Jie --- This is an

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-28 Thread Joseph Wu
On Aug. 27, 2015, 1:06 p.m., Benjamin Hindman wrote: include/mesos/mesos.proto, lines 926-927 https://reviews.apache.org/r/36321/diff/13/?file=1053309#file1053309line926 Why do we need the URL? Can we comment for folks so they know what they might need/use this for? Added some

Re: Review Request 37892: Renamed cgroups::kill to cgroups::signal

2015-08-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37892/ --- (Updated Aug. 28, 2015, 4:12 p.m.) Review request for mesos. Bugs:

Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/ --- Review request for mesos, Jie Yu, Till Toenshoff, and Timothy Chen. Bugs:

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-28 Thread Jojy Varghese
On Aug. 28, 2015, 12:18 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker/token_manager.hpp, line 223 https://reviews.apache.org/r/37427/diff/12/?file=1052806#file1052806line223 Is there a reason you need to include this in the header? Can we just put it in

Re: Review Request 36321: Maintenance primitives: Add Unavailability and InverseOffer protobufs.

2015-08-28 Thread Joseph Wu
On Aug. 28, 2015, 7:49 a.m., Joris Van Remoortere wrote: include/mesos/mesos.proto, line 877 https://reviews.apache.org/r/36321/diff/13-14/?file=1053309#file1053309line877 In your last diff, you changed a bunch of `window` to `interval`. Do you want to change this one as well? If

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

2015-08-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 28, 2015, 10:25 a.m.) Review request for mesos, Benjamin

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96883 --- Why? Everyone knows kill(2) sends a signal while signal(2) installs

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Joerg Schad
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... Jie Yu wrote: IMO, that naming is confusing, and should be 'signal' and 'install'. This is actually answering a discussion here

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37894/#review96897 --- Patch looks great! Reviews applied: [37894] All tests passed. -

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-28 Thread Jojy Varghese
On Aug. 28, 2015, 7:56 a.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker/token_manager.cpp, line 223 https://reviews.apache.org/r/37427/diff/14/?file=1057180#file1057180line223 If you put the cache here in TokenManager instead of TokenManagerProcess then

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-28 Thread Joerg Schad
On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: src/linux/cgroups.cpp, lines 1776-1791 https://reviews.apache.org/r/36620/diff/13/?file=1039336#file1039336line1776 Could you please introduce a new function under cgroups namespace and put this logic there: ``` //

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Cong Wang
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... Jie Yu wrote: IMO, that naming is confusing, and should be 'signal' and 'install'. Joerg Schad wrote: This is actually answering a

Re: Review Request 36571: Maintenance Primitives: Add maintenance-related, registry protobufs.

2015-08-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36571/ --- (Updated Aug. 28, 2015, 10:20 a.m.) Review request for mesos, Benjamin

Re: Review Request 37314: Maintenance Primitives: Populate master's maintenance-related local state upon recovery from registry.

2015-08-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37314/ --- (Updated Aug. 28, 2015, 10:38 a.m.) Review request for mesos, Benjamin

Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-08-28 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review96906 --- include/mesos/master/quota.proto (line 38)

Re: Review Request 36620: Added Non-Freezeer Task Killer.

2015-08-28 Thread Jie Yu
On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote: src/linux/cgroups.cpp, lines 1776-1791 https://reviews.apache.org/r/36620/diff/13/?file=1039336#file1039336line1776 Could you please introduce a new function under cgroups namespace and put this logic there: ``` //

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-08-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Aug. 28, 2015, 6:36 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37773: Docker: Adding registry client.

2015-08-28 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96905 --- src/slave/containerizer/provisioners/docker/registry_client.hpp

Re: Review Request 37894: Renamed cgroups::kill to cgroups::signal.

2015-08-28 Thread Jie Yu
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote: Why? Everyone knows kill(2) sends a signal while signal(2) installs a signal handler... Jie Yu wrote: IMO, that naming is confusing, and should be 'signal' and 'install'. Joerg Schad wrote: This is actually answering a

Re: Review Request 37773: Docker: Adding registry client.

2015-08-28 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Aug. 28, 2015, 6:38 p.m.) Review request for mesos, Lily Chen and

Re: Review Request 37773: Docker: Adding registry client.

2015-08-28 Thread Jojy Varghese
On Aug. 28, 2015, 5:21 p.m., Lily Chen wrote: src/slave/containerizer/provisioners/docker/registry_client.hpp, line 34 https://reviews.apache.org/r/37773/diff/5/?file=1057183#file1057183line34 No need for provisioners namespace, see appc example of mesos::internal::slave::appc

Re: Review Request 37773: Docker: Adding registry client.

2015-08-28 Thread Lily Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review96932 --- src/slave/containerizer/provisioners/docker/registry_client.cpp

Re: Review Request 37913: Improve allocator filtering by keeping per-slave filter sets.

2015-08-28 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37913/#review96952 --- Diff seems weird -- maybe needs a rebase. - Neil Conway On Aug.

Re: Review Request 37814: Added documentation for libprocess environment variables

2015-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37814/#review96958 --- Patch looks great! Reviews applied: [37814] All tests passed. -

Re: Review Request 37773: Docker: Adding registry client.

2015-08-28 Thread Jojy Varghese
On Aug. 28, 2015, 11:03 p.m., Lily Chen wrote: src/slave/containerizer/provisioners/docker/registry_client.cpp, line 415 https://reviews.apache.org/r/37773/diff/6/?file=1058283#file1058283line415 can we do a path::join here? It would be hard to get the /s correct just passing

Re: Review Request 37773: Docker: Adding registry client.

2015-08-28 Thread Jojy Varghese
On Aug. 28, 2015, 11:03 p.m., Lily Chen wrote: src/slave/containerizer/provisioners/docker/registry_client.cpp, line 409 https://reviews.apache.org/r/37773/diff/6/?file=1058283#file1058283line409 I think path may be misleading, can we name this repo?

Re: Review Request 37773: Docker: Adding registry client.

2015-08-28 Thread Jojy Varghese
On Aug. 28, 2015, 6:46 p.m., Timothy Chen wrote: src/slave/containerizer/provisioners/docker/registry_client.hpp, line 150 https://reviews.apache.org/r/37773/diff/6/?file=1058282#file1058282line150 Do we need to define static here if it's not being used anywhere else but the cpp

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-28 Thread Jie Yu
On Aug. 28, 2015, 7:59 p.m., Jie Yu wrote: src/slave/containerizer/provisioners/appc.cpp, lines 79-97 https://reviews.apache.org/r/37881/diff/1/?file=1057722#file1057722line79 Some high level comments. I think it will be beneficial if we can move the fetch and discovery

Review Request 37908: Silence oversubscription logging

2015-08-28 Thread Niklas Nielsen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37908/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-28 Thread Jie Yu
On Aug. 28, 2015, 7:59 p.m., Jie Yu wrote: src/slave/flags.cpp, lines 72-76 https://reviews.apache.org/r/37881/diff/1/?file=1057726#file1057726line72 Why do you still need this flag? Jiang Yan Xu wrote: We instantiate all supported backends but this flag specifies the user's

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-28 Thread Jiang Yan Xu
On Aug. 28, 2015, 12:59 p.m., Jie Yu wrote: src/slave/flags.cpp, lines 72-76 https://reviews.apache.org/r/37881/diff/1/?file=1057726#file1057726line72 Why do you still need this flag? Jiang Yan Xu wrote: We instantiate all supported backends but this flag specifies the

Re: Review Request 37903: stout: Fix bug in IPNetwork::create() with zero prefix.

2015-08-28 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37903/#review96934 --- Patch looks great! Reviews applied: [37903] All tests passed. -

Re: Review Request 37325: Maintenance Primitives: Adds an endpoint for scheduling agents for maintenance.

2015-08-28 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37325/ --- (Updated Aug. 28, 2015, 2:37 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37900: Maintenance Primitives: Add helper functions for the maintenance protobufs.

2015-08-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37900/#review96912 --- Ship it! src/master/maintenance.hpp (line 48)

Re: Review Request 37582: Maintenance Primitives: Add test for the hierarchical DRF allocator sending inverse offers.

2015-08-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37582/#review96914 --- Ship it! src/tests/hierarchical_allocator_tests.cpp (line 474)

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

2015-08-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/#review96915 --- Ship it! Ship It! - Benjamin Hindman On Aug. 26, 2015, 2:12

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

2015-08-28 Thread Benjamin Hindman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/#review96923 --- Ship it! Looks like this stuff is actually needed for

Re: Review Request 37669: Ignore overflow components in version parsing.

2015-08-28 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review96878 --- 3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line

Re: Review Request 37881: Implemented AppcProvisioner.

2015-08-28 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37881/#review96903 --- src/slave/containerizer/provisioner.cpp (line 27)

Review Request 37914: Updated the ReviewBot to flag reviews that do not contain reviewers.

2015-08-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37914/ --- Review request for mesos, Benjamin Hindman and Michael Park. Repository: mesos