---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37714/#review96849
---
Patch looks great!
Reviews applied: [37714]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37787/#review96848
---
Patch looks great!
Reviews applied: [37787]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37531/
---
(Updated Aug. 28, 2015, 9:48 a.m.)
Review request for mesos.
Changes
---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37892/
---
Review request for mesos.
Bugs: MESOS-3086
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37891/
---
(Updated Aug. 28, 2015, 8:51 a.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36321/#review96866
---
include/mesos/mesos.proto (line 876)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37914/#review96977
---
Patch looks great!
Reviews applied: [37914]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/#review96974
---
Patch looks great!
Reviews applied: [37908]
All tests passed.
-
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote:
Why? Everyone knows kill(2) sends a signal while signal(2) installs a
signal handler...
IMO, that naming is confusing, and should be 'signal' and 'install'.
- Jie
---
This is an
On Aug. 27, 2015, 1:06 p.m., Benjamin Hindman wrote:
include/mesos/mesos.proto, lines 926-927
https://reviews.apache.org/r/36321/diff/13/?file=1053309#file1053309line926
Why do we need the URL? Can we comment for folks so they know what they
might need/use this for?
Added some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37892/
---
(Updated Aug. 28, 2015, 4:12 p.m.)
Review request for mesos.
Bugs:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37894/
---
Review request for mesos, Jie Yu, Till Toenshoff, and Timothy Chen.
Bugs:
On Aug. 28, 2015, 12:18 a.m., Timothy Chen wrote:
src/slave/containerizer/provisioners/docker/token_manager.hpp, line 223
https://reviews.apache.org/r/37427/diff/12/?file=1052806#file1052806line223
Is there a reason you need to include this in the header? Can we just
put it in
On Aug. 28, 2015, 7:49 a.m., Joris Van Remoortere wrote:
include/mesos/mesos.proto, line 877
https://reviews.apache.org/r/36321/diff/13-14/?file=1053309#file1053309line877
In your last diff, you changed a bunch of `window` to `interval`. Do
you want to change this one as well? If
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/
---
(Updated Aug. 28, 2015, 10:25 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37894/#review96883
---
Why? Everyone knows kill(2) sends a signal while signal(2) installs
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote:
Why? Everyone knows kill(2) sends a signal while signal(2) installs a
signal handler...
Jie Yu wrote:
IMO, that naming is confusing, and should be 'signal' and 'install'.
This is actually answering a discussion here
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37894/#review96897
---
Patch looks great!
Reviews applied: [37894]
All tests passed.
-
On Aug. 28, 2015, 7:56 a.m., Timothy Chen wrote:
src/slave/containerizer/provisioners/docker/token_manager.cpp, line 223
https://reviews.apache.org/r/37427/diff/14/?file=1057180#file1057180line223
If you put the cache here in TokenManager instead of
TokenManagerProcess then
On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote:
src/linux/cgroups.cpp, lines 1776-1791
https://reviews.apache.org/r/36620/diff/13/?file=1039336#file1039336line1776
Could you please introduce a new function under cgroups namespace and
put this logic there:
```
//
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote:
Why? Everyone knows kill(2) sends a signal while signal(2) installs a
signal handler...
Jie Yu wrote:
IMO, that naming is confusing, and should be 'signal' and 'install'.
Joerg Schad wrote:
This is actually answering a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36571/
---
(Updated Aug. 28, 2015, 10:20 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37314/
---
(Updated Aug. 28, 2015, 10:38 a.m.)
Review request for mesos, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36908/#review96906
---
include/mesos/master/quota.proto (line 38)
On Aug. 27, 2015, 7:02 p.m., Jie Yu wrote:
src/linux/cgroups.cpp, lines 1776-1791
https://reviews.apache.org/r/36620/diff/13/?file=1039336#file1039336line1776
Could you please introduce a new function under cgroups namespace and
put this logic there:
```
//
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37427/
---
(Updated Aug. 28, 2015, 6:36 p.m.)
Review request for mesos, Lily Chen, Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/#review96905
---
src/slave/containerizer/provisioners/docker/registry_client.hpp
On Aug. 28, 2015, 4:45 p.m., Cong Wang wrote:
Why? Everyone knows kill(2) sends a signal while signal(2) installs a
signal handler...
Jie Yu wrote:
IMO, that naming is confusing, and should be 'signal' and 'install'.
Joerg Schad wrote:
This is actually answering a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/
---
(Updated Aug. 28, 2015, 6:38 p.m.)
Review request for mesos, Lily Chen and
On Aug. 28, 2015, 5:21 p.m., Lily Chen wrote:
src/slave/containerizer/provisioners/docker/registry_client.hpp, line 34
https://reviews.apache.org/r/37773/diff/5/?file=1057183#file1057183line34
No need for provisioners namespace, see appc example of
mesos::internal::slave::appc
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37773/#review96932
---
src/slave/containerizer/provisioners/docker/registry_client.cpp
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37913/#review96952
---
Diff seems weird -- maybe needs a rebase.
- Neil Conway
On Aug.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37814/#review96958
---
Patch looks great!
Reviews applied: [37814]
All tests passed.
-
On Aug. 28, 2015, 11:03 p.m., Lily Chen wrote:
src/slave/containerizer/provisioners/docker/registry_client.cpp, line 415
https://reviews.apache.org/r/37773/diff/6/?file=1058283#file1058283line415
can we do a path::join here? It would be hard to get the /s correct
just passing
On Aug. 28, 2015, 11:03 p.m., Lily Chen wrote:
src/slave/containerizer/provisioners/docker/registry_client.cpp, line 409
https://reviews.apache.org/r/37773/diff/6/?file=1058283#file1058283line409
I think path may be misleading, can we name this repo?
On Aug. 28, 2015, 6:46 p.m., Timothy Chen wrote:
src/slave/containerizer/provisioners/docker/registry_client.hpp, line 150
https://reviews.apache.org/r/37773/diff/6/?file=1058282#file1058282line150
Do we need to define static here if it's not being used anywhere else
but the cpp
On Aug. 28, 2015, 7:59 p.m., Jie Yu wrote:
src/slave/containerizer/provisioners/appc.cpp, lines 79-97
https://reviews.apache.org/r/37881/diff/1/?file=1057722#file1057722line79
Some high level comments.
I think it will be beneficial if we can move the fetch and discovery
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37908/
---
Review request for mesos and Jie Yu.
Repository: mesos
Description
---
On Aug. 28, 2015, 7:59 p.m., Jie Yu wrote:
src/slave/flags.cpp, lines 72-76
https://reviews.apache.org/r/37881/diff/1/?file=1057726#file1057726line72
Why do you still need this flag?
Jiang Yan Xu wrote:
We instantiate all supported backends but this flag specifies the user's
On Aug. 28, 2015, 12:59 p.m., Jie Yu wrote:
src/slave/flags.cpp, lines 72-76
https://reviews.apache.org/r/37881/diff/1/?file=1057726#file1057726line72
Why do you still need this flag?
Jiang Yan Xu wrote:
We instantiate all supported backends but this flag specifies the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37903/#review96934
---
Patch looks great!
Reviews applied: [37903]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37325/
---
(Updated Aug. 28, 2015, 2:37 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37900/#review96912
---
Ship it!
src/master/maintenance.hpp (line 48)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37582/#review96914
---
Ship it!
src/tests/hierarchical_allocator_tests.cpp (line 474)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37178/#review96915
---
Ship it!
Ship It!
- Benjamin Hindman
On Aug. 26, 2015, 2:12
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37282/#review96923
---
Ship it!
Looks like this stuff is actually needed for
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37669/#review96878
---
3rdparty/libprocess/3rdparty/stout/include/stout/version.hpp (line
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37881/#review96903
---
src/slave/containerizer/provisioner.cpp (line 27)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37914/
---
Review request for mesos, Benjamin Hindman and Michael Park.
Repository: mesos
49 matches
Mail list logo