Review Request 38046: Replace hard-coded reap interval with a constant

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1935

Re: Review Request 37989: Replace hard-coded reap interval with a constant

2015-09-02 Thread Guangya Liu
> On 九月 2, 2015, 12:47 a.m., Ben Mahler wrote: > > Hey Guangya, the point of MESOS-1935 was to use these constant functions > > throughout the code base: > > > > ``` > > ? mesos git:(master) ? grep -R 'Seconds(1)' src/tests > > src/tests/containerizer/cgroups_tests.cpp:if (elapsed >

Re: Review Request 38046: Replace hard-coded reap interval with a constant

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review97426 --- Patch looks great! Reviews applied: [38046] All tests passed. -

Re: Review Request 37168: MESOS-3063

2015-09-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review97423 --- As this is an example framework (which will be used by people to

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/#review97413 --- Ship it! Ship It! - Guangya Liu On 八月 26, 2015, 2:13 a.m.,

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-02 Thread haosdent huang
> On Sept. 2, 2015, 2:54 p.m., Bernd Mathiske wrote: > > src/docker/docker.cpp, line 201 > > > > > > The "[0]" access looks dicy, but after reading the implementation of > > strings::split(), I am fairly convinced

Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/ --- Review request for mesos and Joris Van Remoortere. Repository: mesos

Re: Review Request 37773: Docker: Adding registry client.

2015-09-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Sept. 2, 2015, 5:06 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Sept. 2, 2015, 5:07 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-02 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/#review97464 --- Using a ```RefusedFilter``` for this is not the right solution. The

Re: Review Request 37921: Add Copy backend for provisioners.

2015-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/ --- (Updated Sept. 2, 2015, 4:54 p.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Alexander Rukletsov
> On Sept. 2, 2015, 4:45 p.m., Guangya Liu wrote: > > src/master/master.hpp, line 34 > > > > > > Alex, can you please show more detail for why we need to move #include > > ? Does the correct order is sub grouping >

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-09-02 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/ --- (Updated Sept. 2, 2015, 4:16 p.m.) Review request for mesos, Alexander

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-02 Thread Guangya Liu
> On 九月 2, 2015, 4:07 p.m., James Peach wrote: > > Using a ```RefusedFilter``` for this is not the right solution. The point > > of the suppress call is to have a cheap way to disable offers at a > > framework granularity. Adding a ```RefusedFilter``` for the total is not > > cheap. Filters

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97493 --- Ship it! Ship It! - Joseph Wu On Sept. 2, 2015, 9:34 a.m.,

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-02 Thread haosdent huang
> On Sept. 2, 2015, 2:54 p.m., Bernd Mathiske wrote: > > src/docker/docker.cpp, line 201 > > > > > > The "[0]" access looks dicy, but after reading the implementation of > > strings::split(), I am fairly convinced

Re: Review Request 37826: Introduced conversion of JSON arrays to repeated protobufs.

2015-09-02 Thread Joseph Wu
> On Sept. 1, 2015, 9:46 a.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp, lines 553-555 > > > > > > Can you explain why this is a struct rather than a function? > >

Re: Review Request 38046: Replace hard-coded reap interval with a constant

2015-09-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review97465 --- I've started to review this patch and then I realized that it was

Re: Review Request 38046: Replace hard-coded reap interval with a constant

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/ --- (Updated 九月 2, 2015, 4:37 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97475 --- src/master/master.hpp

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-02 Thread James Peach
> On Sept. 2, 2015, 4:07 p.m., James Peach wrote: > > Using a ```RefusedFilter``` for this is not the right solution. The point > > of the suppress call is to have a cheap way to disable offers at a > > framework granularity. Adding a ```RefusedFilter``` for the total is not > > cheap.

Re: Review Request 38046: Replace hard-coded reap interval with a constant

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review97496 --- Patch looks great! Reviews applied: [38046] All tests passed. -

Re: Review Request 38056: Fix webui task informations not update bug.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38056/#review97470 --- Patch looks great! Reviews applied: [38056] All tests passed. -

Re: Review Request 34142: AppC provisioner.

2015-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34142/#review97499 --- This is no longer valid right? Can we discard all ian's patches? -

Re: Review Request 37773: Docker: Adding registry client.

2015-09-02 Thread Jojy Varghese
- Jojy --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review97331 --- On Sept. 1, 2015, 9:36 p.m., Jojy Varghese wrote: > >

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-02 Thread Paul Brett
> On Sept. 1, 2015, 11:43 p.m., Ben Mahler wrote: > > src/linux/perf.hpp, line 56 > > > > > > Whoops, doesn't this comment belong on the parse function? Actually, it applies to both of them. I'll make that clear.

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/ --- (Updated Sept. 2, 2015, 7:33 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37622: Maintenance Primitives: Shutdown & remove slave when maintenance is started.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37622/ --- (Updated Sept. 2, 2015, 7:33 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37621: Maintenance Primitives: Gracefully handle inverse offers in pre-V1 scheduler.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37621/ --- (Updated Sept. 2, 2015, 7:33 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/ --- (Updated Sept. 2, 2015, 7:33 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Sept. 2, 2015, 8:06 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Guangya Liu
> On 九月 2, 2015, 4:45 p.m., Guangya Liu wrote: > > src/master/master.hpp, line 34 > > > > > > Alex, can you please show more detail for why we need to move #include > > ? Does the correct order is sub grouping > >

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97565 --- Ship it! Ship It! - Guangya Liu On 九月 2, 2015, 4:34 p.m.,

Re: Review Request 37540: Add perf event API

2015-09-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/#review97548 --- src/linux/perf.hpp (line 71)

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
> On Sept. 2, 2015, 10:47 p.m., Ben Mahler wrote: > > src/tests/containerizer/perf_tests.cpp, line 67 > > > > > > Why is this called ParseTypes and the one below called ParseCgroups? > > They both seem to parse

Re: Review Request 35084: Provide consistent behavior for bundled packages.

2015-09-02 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35084/#review97566 --- Overall I believe this makes sense, I'll need some more time to

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Sept. 3, 2015, 12:43 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37921: Add Copy backend for provisioners.

2015-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/ --- (Updated Sept. 3, 2015, 1:24 a.m.) Review request for mesos, Jie Yu and Jiang

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97597 --- Patch looks great! Reviews applied: [37416, 37442, 37462, 37466]

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Sept. 2, 2015, 11:33 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37881: Implemented AppcProvisioner.

2015-09-02 Thread Jiang Yan Xu
> On Aug. 31, 2015, 3:50 p.m., Chi Zhang wrote: > > src/slave/containerizer/provisioners/appc.cpp, lines 381-391 > > > > > > Could it be possible that one backend return Failure while the other > > one returns

Re: Review Request 37881: Implemented AppcProvisioner.

2015-09-02 Thread Jiang Yan Xu
> On Aug. 31, 2015, 10:33 p.m., Jie Yu wrote: > > src/slave/containerizer/provisioner.cpp, line 47 > > > > > > Can you just use a string->create func hashmap so that you don't need > > Image::Type_Parse. > > >

Re: Review Request 37929: Changed provisioner Store API and implementation so it works as a read-through cache.

2015-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37929/#review97585 --- Ship it! Ship It!

Re: Review Request 38074: Calculate schedule latency with trace events

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review97587 --- Bad patch! Reviews applied: [37540] Failed command:

Re: Review Request 37958: Add an option to only perform batch allocations.

2015-09-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37958/#review97596 --- Hey James, I left some comments on

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/ --- (Updated Sept. 3, 2015, 3:12 a.m.) Review request for mesos, Ben Mahler,

Re: Review Request 37669: Ignore overflow docker components in version parsing.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37669/#review97604 --- Patch looks great! Reviews applied: [37669] All tests passed. -

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-02 Thread Guangya Liu
> On 九月 2, 2015, 6:14 p.m., Joseph Wu wrote: > > include/mesos/master/allocator.hpp, lines 92-93 > > > > > > These two @param's don't add much, so you could exclude them. > > > > I added comments like this

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 3, 2015, 4:05 a.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97610 --- Patch looks great! Reviews applied: [37993] All tests passed. -

Re: Review Request 37787: Reworked Jenkins build script. Added test images for ubuntu-14.04-gcc-4.8, ubuntu-14.04-clang-3.6, ubuntu-12.04-gcc-4.8, centos-7.1-gcc-4.8.

2015-09-02 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37787/#review97613 --- support/jenkins_build_docker.sh (line 45)

Re: Review Request 37178: Maintenance Primitives: Added InverseOffers to Scheduler Event Offers.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37178/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37282: Maintenance Primitives: Added InverseOffer to V1 API.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37282/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37773: Docker: Adding registry client.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/#review97518 --- Patch looks great! Reviews applied: [37871, 37427, 37773] All

Re: Review Request 37173: Maintenance Primitives: Added unavailability to Allocator's Slave struct.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37173/ --- (Updated Sept. 2, 2015, 7:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37180: Maintenance Primitives: Implemented Master::inverseOffer.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37180/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/ --- (Updated Sept. 2, 2015, 7:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/ --- (Updated Sept. 2, 2015, 7:32 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/ --- (Updated Sept. 2, 2015, 7:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97530 --- Bad patch! Reviews applied: [37416, 37442, 37462, 37466] Failed

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/ --- (Updated Sept. 2, 2015, 6:52 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-02 Thread Jojy Varghese
> On Sept. 2, 2015, 8:01 p.m., Anand Mazumdar wrote: > > Nothing major, Just some fly-by style comments. Looking at the > > implementation in greater detail now. > > > > I wonder if we should split this review into smaller chunks. It currently > > stands at ~900 lines. It's very hard to

Re: Review Request 37993: Add explanatory comments for Allocator interface

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review97478 --- First of all, thanks for adding comments!

Re: Review Request 37921: Add Copy backend for provisioners.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/#review97508 --- Patch looks great! Reviews applied: [37921] All tests passed. -

Re: Review Request 37176: Maintenance Primitives: Added a new allocation overload to sorter.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37176/ --- (Updated Sept. 2, 2015, 7:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

2015-09-02 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/ --- (Updated Sept. 2, 2015, 7:31 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-02 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/#review97505 --- Nothing major, Just some fly-by style comments. Looking at the

Re: Review Request 38061: Corrected include order in master.hpp

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38061/#review97525 --- Patch looks great! Reviews applied: [38061] All tests passed. -

Re: Review Request 37623: Maintenance Primitives: Prevent Slaves from registering if the machine is under maintenance.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37623/#review97528 --- Bad patch! Reviews applied: [37655, 36321, 36571, 37314, 37900,

Re: Review Request 37921: Add Copy backend for provisioners.

2015-09-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37921/#review97509 --- Ship it! src/slave/containerizer/provisioners/backends/copy.hpp

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-02 Thread Anand Mazumdar
> On Sept. 2, 2015, 8:01 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/token_manager.hpp, line 19 > > > > > > Can we change this to be __MESOS_DOCKER_TOKEN_MANAGER_HPP__ > > > >

Re: Review Request 37541: Add TraceEvent API

2015-09-02 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Sept. 2, 2015, 10:14 p.m.) Review request for mesos, Chi Zhang, Ian

Review Request 38069: Added a tuple overload for process::collect.

2015-09-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38069/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 37170: Maintenance Primitives: Added `Machine` to Slave struct in Master.

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37170/#review97520 --- Ship it! LGTM! src/master/master.cpp (lines 1367 - 1369)

Review Request 38074: Calculate schedule latency with trace events

2015-09-02 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 38073: Avoid parsing perf events twice

2015-09-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38073/#review97546 --- Ship it! Ship It! - Ben Mahler On Sept. 2, 2015, 10:18 p.m.,

Re: Review Request 38074: Calculate schedule latency with trace events

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/#review97550 --- Bad patch! Reviews applied: [37540] Failed command:

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37427/ --- (Updated Sept. 2, 2015, 10:50 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 38069: Added a tuple overload for process::collect.

2015-09-02 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38069/#review97534 --- Ship it! Ship It! - Vinod Kone On Sept. 2, 2015, 9:09 p.m., Ben

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/ --- (Updated Sept. 2, 2015, 9:13 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-02 Thread Anand Mazumdar
> On Sept. 2, 2015, 8:01 p.m., Anand Mazumdar wrote: > > src/slave/containerizer/provisioners/docker/token_manager.hpp, line 19 > > > > > > Can we change this to be __MESOS_DOCKER_TOKEN_MANAGER_HPP__ > > > >

Re: Review Request 37462: Add support for version detection and parsing.

2015-09-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37462/#review97516 --- Ship it! I've made adjustments based on the feedback below before

Re: Review Request 37177: Maintenance Primitives: Added inverse offers.

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37177/#review97529 --- Ship it! LGTM! src/master/allocator/mesos/hierarchical.hpp (line

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review97532 --- Ship it! include/mesos/master/allocator.hpp (lines 152 - 155)

Re: Review Request 37175: Maintenance Primitives: Added updateUnavailability to master.

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37175/#review97527 --- Ship it! include/mesos/master/allocator.hpp (lines 138 - 141)

Review Request 38073: Avoid parsing perf events twice

2015-09-02 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38073/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Vinod Kone. Bugs:

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97551 --- Thinking about this further, the test parameteratization here seems

Re: Review Request 37881: Implemented AppcProvisioner.

2015-09-02 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37881/ --- (Updated Sept. 2, 2015, 3:47 p.m.) Review request for mesos, Chi Zhang, Jie

Re: Review Request 37773: Docker: Adding registry client.

2015-09-02 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37773/ --- (Updated Sept. 2, 2015, 10:52 p.m.) Review request for mesos, Lily Chen, Joris

Re: Review Request 37540: Add perf event API

2015-09-02 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Sept. 2, 2015, 10:16 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37541: Add trace event API

2015-09-02 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37541/ --- (Updated Sept. 2, 2015, 10:17 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review97553 --- Ship it! src/master/master.cpp (line 3243)

Re: Review Request 37466: Update perf tests to including testing the supported perf output formats.

2015-09-02 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37466/#review97538 --- Patch looks great! Reviews applied: [37416, 37442, 37462, 37466]

Re: Review Request 37172: Maintenance Primitives: Set offer `unavailability` if slave is scheduled for maintenance.

2015-09-02 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37172/#review97524 --- Ship it! LGTM. (And I think BenH's issue is no longer present

Re: Review Request 37540: Add PerfEvent API

2015-09-02 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37540/ --- (Updated Sept. 2, 2015, 10:13 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 38074: Calculate schedule latency with trace events

2015-09-02 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38074/ --- (Updated Sept. 2, 2015, 11:18 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 37280: Maintenance Primitives: Added updateInverseOffer to Allocator.

2015-09-02 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37280/#review97428 --- include/mesos/master/allocator.hpp (line 147)

  1   2   >