Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 5, 2015, noon) Review request for mesos, Artem Harutyunyan,

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

2015-09-05 Thread haosdent huang
> On Aug. 31, 2015, 6:46 p.m., Joseph Wu wrote: > > 3rdparty/libprocess/3rdparty/CMakeLists.txt, lines 72-84 > > > > > > (This is just speculation, since I haven't tried this on a Windows > > box.) > > `TRUE`

Re: Review Request 37024: Exposes mesos version information in components.

2015-09-05 Thread haosdent huang
> On Aug. 31, 2015, 10:47 p.m., Ben Mahler wrote: > > Couple of comments: > > > > Let's not call the actor VersionInfo, since that sounds like a protobuf > > message. How about 'VersionProcess' and we avoid the wrapper type entirely > > since Version is taken in stout? > > > > Also, can we

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-05 Thread Yong Qiao Wang
> On 九月 4, 2015, 7:42 p.m., Vinod Kone wrote: > > src/master/master.cpp, line 4118 > > > > > > Instead of not calling updateTask() the logic should be inside > > updateTask() to do the right thing. Note that

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/#review97864 --- Patch looks great! Reviews applied: [37273, 37275] All tests

Re: Review Request 38125: Included hostname in SlaveID.

2015-09-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38125/#review97871 --- What is the benefit of this change? I'm a bit reluctant to conflate

Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/ --- Review request for mesos. Bugs: MESOS-3022

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-05 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/ --- (Updated 九月 5, 2015, 1:38 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/ --- (Updated 九月 5, 2015, 2:06 p.m.) Review request for mesos. Bugs: MESOS-3022

Re: Review Request 38051: Only update the task status when its old status is not terminal.

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38051/#review97866 --- Patch looks great! Reviews applied: [38051] All tests passed. -

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-05 Thread haosdent huang
> On Aug. 31, 2015, 6:50 p.m., Joseph Wu wrote: > > cmake/MesosConfigure.cmake, line 125 > > > > > > Why do you need this? (If you do need it, comment why.) > > > > It doesn't look like the inputs have any

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97860 --- Patch looks great! Reviews applied: [38145] All tests passed. -

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
> On 九月 5, 2015, 1:04 p.m., haosdent huang wrote: > > src/sched/sched.cpp, line 102 > > > > > > I think need change order to match dictionnary order here. Thanks a million! I will update the order in the updated

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97867 --- Ship it! Ship It! - haosdent huang On Sept. 5, 2015, 2:06 p.m.,

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread haosdent huang
> On Sept. 5, 2015, 3:27 p.m., haosdent huang wrote: > > Ship It! Looks good for me. But you need find a committer help you review and commit this patch. :-) - haosdent --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 5, 2015, 12:43 p.m.) Review request for mesos, Artem

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/ --- (Updated 九月 5, 2015, 12:41 p.m.) Review request for mesos. Bugs: MESOS-3022

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/ --- (Updated Sept. 5, 2015, 12:40 p.m.) Review request for mesos, Artem

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97857 --- src/sched/sched.cpp (line 102)

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38145/#review97869 --- Patch looks great! Reviews applied: [38145] All tests passed. -

Re: Review Request 37275: [2/2]Generate make batch file to build project in windows.

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37275/ --- (Updated Sept. 5, 2015, 12:45 p.m.) Review request for mesos, Artem

Re: Review Request 38117: Export per container SNMP statistics

2015-09-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review97870 --- src/slave/containerizer/isolators/network/port_mapping.cpp (line

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/ --- (Updated Sept. 5, 2015, 10:05 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 38145: export additional message metrics from scheduler driver

2015-09-05 Thread Yong Qiao Wang
> On 九月 5, 2015, 3:27 p.m., haosdent huang wrote: > > Ship It! > > haosdent huang wrote: > Looks good for me. But you need find a committer help you review and > commit this patch. :-) Thanks again. That's very nice of you. - Yong Qiao

Re: Review Request 35702: Added /reserve HTTP endpoint to the master.

2015-09-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35702/#review97881 --- Ship it! Ship It! - Guangya Liu On 九月 4, 2015, 11:19 p.m.,

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97872 --- include/mesos/v1/executor/executor.proto (line 47)

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Isabel Jimenez
> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote: > > include/mesos/v1/executor/executor.proto, line 47 > > > > > > I think that the framework id need to be set when call "SUBSCRIBE" but > > not after "SUBSCRIBED"?

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97880 --- Ship it! Thanks Isabel for the explanation! - Guangya Liu On 九月

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review97876 --- Patch looks great! Reviews applied: [38143] All tests passed. -

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-05 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37873/ --- (Updated 九月 6, 2015, 2:40 a.m.) Review request for mesos, Alexander Rukletsov,

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-05 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/#review97882 --- Patch looks great! Reviews applied: [37168] All tests passed. -

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-05 Thread Isabel Jimenez
> On Sept. 5, 2015, 3:28 a.m., Guangya Liu wrote: > > include/mesos/v1/executor/executor.proto, line 169 > > > > > > Do you mean that when type is Subscribe, there is no need to set any > > message? Why? I think

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-05 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ --- (Updated Sept. 6, 2015, 4:11 a.m.) Review request for mesos and Michael Park.