Re: Review Request 36908: Added QuotaInfo Protobuf.

2015-09-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36908/#review97972 --- Ship it! Ship It! - Qian Zhang On Sept. 2, 2015, 9:38 p.m.,

Review Request 38171: Stout: Refactored set to use initializer list for variadic constructor.

2015-09-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38171/ --- Review request for mesos and Michael Park. Bugs: MESOS-3217

Review Request 38172: Stout: Simplified hashset implementation.

2015-09-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38172/ --- Review request for mesos and Michael Park. Bugs: MESOS-3217

Review Request 38173: Stout: Simplified hashmap implementation.

2015-09-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38173/ --- Review request for mesos and Michael Park. Bugs: MESOS-3217

Re: Review Request 36913: Added /quota HTTP Endpoint for Quota handling.

2015-09-08 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/36913/#review97974 --- src/master/master.hpp (line 901)

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

2015-09-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review97984 --- Ship it! Ship It! - Bernd Mathiske On Aug. 28, 2015, 1:11 a.m.,

Re: Review Request 38046: Replace hard-coded reap interval with a constant

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/ --- (Updated 九月 8, 2015, 6:16 a.m.) Review request for mesos, Alexander Rukletsov

Re: Review Request 38046: Replace hard-coded reap interval with a constant

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38046/#review97973 --- Patch looks great! Reviews applied: [38046] All tests passed. -

Re: Review Request 37714: Updated Multimap and multihashmap so their signatures resemble that of hashmap and hashset.

2015-09-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37714/#review97978 --- 3rdparty/libprocess/3rdparty/stout/include/stout/multihashmap.hpp

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-08 Thread Jojy Varghese
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review98030 --- src/slave/containerizer/provisioner.hpp (line 54)

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/ --- (Updated Sept. 8, 2015, 7:52 p.m.) Review request for mesos, Jojy Varghese,

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 8, 2015, 7:25 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Wojciech Sielski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/ --- (Updated Sept. 8, 2015, 7:46 p.m.) Review request for mesos and Timothy Chen.

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review98055 --- Patch looks great! Reviews applied: [38158] All tests passed. -

Re: Review Request 38143: Adding executor HTTP API protobuf to V1

2015-09-08 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38143/#review98047 --- Ship it! LGTM ! @gyliu : This change just moves the existing

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 8, 2015, 7:22 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 37703: Add docker exec command.

2015-09-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/#review98054 --- src/docker/docker.cpp (line 1200)

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98050 --- src/docker/docker.cpp (line 414)

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
> On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, line 231 > > > > > > An idea to re-use code here. This function boils down to inserting an > > element into a sorted range and

Re: Review Request 38173: Stout: Simplified hashmap implementation.

2015-09-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38173/ --- (Updated Sept. 8, 2015, 9:52 p.m.) Review request for mesos and Michael Park.

Re: Review Request 38117: Export per container SNMP statistics

2015-09-08 Thread Cong Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/ --- (Updated Sept. 8, 2015, 9:12 p.m.) Review request for mesos, Jie Yu, Paul

Review Request 38191: Removing unused Executor protobuf

2015-09-08 Thread Isabel Jimenez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38191/ --- Review request for mesos, Anand Mazumdar, Ben Mahler, and Vinod Kone. Bugs:

Re: Review Request 38154: Switched to type traits for checking whether a type is a protobuf message.

2015-09-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38154/#review98067 --- Ship it! One minor nit.

Re: Review Request 38172: Stout: Simplified hashset implementation.

2015-09-08 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38172/ --- (Updated Sept. 8, 2015, 9:52 p.m.) Review request for mesos and Michael Park.

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38137/#review98078 --- Patch looks great! Reviews applied: [38137] All tests passed. -

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98063 --- Patch looks great! Reviews applied: [38165] All tests passed. -

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

2015-09-08 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/#review98026 --- Ship it! Just a bit more cleanup, and I think this would be good

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Timothy Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98091 --- Ship it! Ship It! - Timothy Chen On Sept. 8, 2015, 7:46 p.m.,

Re: Review Request 38161: Replaced a hard-coded number for registration backoff with a proper constant and extended comments.

2015-09-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38161/#review98004 --- src/tests/fault_tolerance_tests.cpp (line 675)

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
> On Sept. 7, 2015, 9:24 p.m., Alexander Rukletsov wrote: > > src/common/values.cpp, lines 277-278 > > > > > > Since you're editing here, mind explaining what an "urange" is? As the comment above states it is an

Re: Review Request 37336: Simplified the caller interface to process::Subprocess

2015-09-08 Thread Marco Massenzio
> On Sept. 7, 2015, 11:14 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/include/process/subprocess.hpp, lines 103-110 > > > > > > Does it make sense to aggregate these into a `Result`? The > > `Some`

Review Request 38193: Remove comment from updateAllocation

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38193/ --- Review request for mesos and Jie Yu. Repository: mesos Description ---

Re: Review Request 38191: Removing unused Executor protobuf

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38191/#review98103 --- Ship it! Ship It! - Guangya Liu On 九月 8, 2015, 10:30 p.m.,

Re: Review Request 38117: Export per container SNMP statistics

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38117/#review98104 --- Patch looks great! Reviews applied: [38117] All tests passed. -

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98093 --- Ship it! Ship It! - Guangya Liu On 九月 8, 2015, 7:46 p.m.,

Re: Review Request 38160: Documented how to expedite event firing.

2015-09-08 Thread Guangya Liu
> On 九月 8, 2015, 3:44 p.m., Guangya Liu wrote: > > docs/mesos-testing-patterns.md, line 10 > > > > > > What does "Naïve" means? > > haosdent huang wrote: > Naïve waiting means just waiting until timeout. Like: >

Re: Review Request 38141: Refactor shared paths in provisioners.

2015-09-08 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38141/#review98097 --- Ship it! LGTM! Could you run `sudo make check

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread Wojciech Sielski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38165/#review98008 --- Ship it! Ship It! - Wojciech Sielski On Sept. 7, 2015, 6:47

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/#review98009 --- Patch looks great! Reviews applied: [38158] All tests passed. -

Re: Review Request 38160: Documented how to expedite event firing.

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/#review98011 --- docs/mesos-testing-patterns.md (line 10)

Re: Review Request 38193: Remove comment from updateAllocation

2015-09-08 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38193/#review98122 --- Ship it! Ship It! - Jie Yu On Sept. 9, 2015, 12:02 a.m.,

Re: Review Request 37427: Docker registry: adding TokenManager.

2015-09-08 Thread Timothy Chen
> On Sept. 2, 2015, 8:01 p.m., Anand Mazumdar wrote: > > src/Makefile.am, line 761 > > > > > > Extra space ? > > Jojy Varghese wrote: > looks to be aligned with the rest > > Anand Mazumdar wrote: > The

Review Request 38197: Increment a metric when master drop a message

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38197/ --- Review request for mesos, Ben Mahler, Jie Yu, and Vinod Kone. Repository:

Review Request 38149: Add message_call_received metrics for master

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/ --- Review request for mesos and Vinod Kone. Repository: mesos Description

Re: Review Request 38160: Documented how to expedite event firing.

2015-09-08 Thread haosdent huang
> On Sept. 8, 2015, 3:44 p.m., Guangya Liu wrote: > > docs/mesos-testing-patterns.md, line 10 > > > > > > What does "Naïve" means? > > haosdent huang wrote: > Naïve waiting means just waiting until timeout.

Re: Review Request 37703: Add docker exec command.

2015-09-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37703/ --- (Updated Sept. 9, 2015, 2:27 a.m.) Review request for mesos and Timothy Chen.

Re: Review Request 37168: MESOS-3063 (Add an example framework using dynamic reservation)

2015-09-08 Thread Klaus Ma
Hi Michael, Do you have more comments about this example? On 2015年09月06日 21:28, Klaus Ma wrote: This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37168/ On September 6th, 2015, 8:49 a.m. UTC, *Joerg Schad* wrote: src/Makefile.am

Re: Review Request 37284: Maintenance Primitives: Added support for Accept / Decline of InverseOffers in master.

2015-09-08 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37284/#review98142 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:33 p.m.,

Re: Review Request 37283: Maintenance Primitives: Refactored Master maintenance test to use V1 API.

2015-09-08 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37283/#review98143 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m.,

Review Request 38201: [MESOS-1187] precision errors with allocation calculations

2015-09-08 Thread Klaus Ma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38201/ --- Review request for mesos. Bugs: MESOS-1187

Re: Review Request 38201: [MESOS-1187] precision errors with allocation calculations

2015-09-08 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38201/#review98145 --- I think that the V1 related should also be updated. - Guangya Liu

Re: Review Request 38191: Removing unused Executor protobuf

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38191/#review98148 --- Patch looks great! Reviews applied: [38191] All tests passed. -

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

2015-09-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37273/ --- (Updated Sept. 9, 2015, 2:38 a.m.) Review request for mesos, Artem

Re: Review Request 37273: [1/2]Add CMake macro VsBuildCommand in libprocess.

2015-09-08 Thread haosdent huang
> On Sept. 8, 2015, 9:44 p.m., Joseph Wu wrote: > > Just a bit more cleanup, and I think this would be good to go. > > > > If possible, you should coordinate with Alex Clemmer to make sure this > > change doesn't conflict/break what he's working on > > (https://reviews.apache.org/r/37019/).

Re: Review Request 38173: Stout: Simplified hashmap implementation.

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38173/#review98141 --- Patch looks great! Reviews applied: [38171, 38172, 38173] All

Re: Review Request 37234: Maintenance Primitives: Added URL field to InverseOffer proto.

2015-09-08 Thread Yong Qiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37234/#review98144 --- Ship it! Ship It! - Yong Qiao Wang On Sept. 2, 2015, 7:32 p.m.,

Re: Review Request 38160: Documented how to expedite event firing.

2015-09-08 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38160/#review98005 --- docs/mesos-testing-patterns.md (line 16)

Re: Review Request 38158: Refactored Value::Ranges coalesce().

2015-09-08 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38158/ --- (Updated Sept. 8, 2015, 2:33 p.m.) Review request for mesos, Bernd Mathiske

Re: Review Request 38165: MESOS-3377 - Adding CONTAINER_NAME as additional env variable

2015-09-08 Thread haosdent huang
> On Sept. 8, 2015, 2:57 p.m., Wojciech Sielski wrote: > > Ship It! Hi, @sielaq Could you add @tnachen in reviewers? Because he is the maintainer of docker container component, I think he could help decide this approach should be accepted or not. And then help you commit this if this is

Re: Review Request 38160: Documented how to expedite event firing.

2015-09-08 Thread haosdent huang
> On Sept. 8, 2015, 3:44 p.m., Guangya Liu wrote: > > docs/mesos-testing-patterns.md, line 10 > > > > > > What does "Naïve" means? Naïve waiting means just waiting until timeout. Like: ``` AWAIT_READY(Future) ```

Re: Review Request 38137: Added Docker provisioner and local store

2015-09-08 Thread Timothy Chen
> On Sept. 8, 2015, 6:35 p.m., Jojy Varghese wrote: > > src/slave/containerizer/provisioner.hpp, line 54 > > > > > > doxygen style? I'll fix this later with another patch, this isn't related to docker. > On Sept.

Re: Review Request 38149: Add message_call_received metrics for master

2015-09-08 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38149/#review98150 --- Patch looks great! Reviews applied: [38149] All tests passed. -