Re: Review Request 38516: Changed quiesceOffers to SuppressOffers

2015-09-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38516/ --- (Updated 九月 21, 2015, 12:11 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

2015-09-20 Thread Guangya Liu
> On 九月 20, 2015, 6:46 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 486 > > > > > > this method should be called suppress too. > > > > > > to avoid conflict with the suppress marco, can you

Re: Review Request 38516: Changed quiesceOffers to SuppressOffers

2015-09-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38516/#review99717 --- Ship it! Ship It! - Vinod Kone On Sept. 21, 2015, 12:11 a.m.,

Re: Review Request 38514: Update QUIESCE to SUPPRESS in Mesos Call

2015-09-20 Thread Vinod Kone
> On Sept. 20, 2015, 6:46 p.m., Vinod Kone wrote: > > src/master/http.cpp, line 486 > > > > > > this method should be called suppress too. > > > > > > to avoid conflict with the suppress marco, can you

Re: Review Request 38519: Change function quiesce() to suppressRes()

2015-09-20 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38519/#review99718 --- src/master/http.cpp (line 486)

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99698 --- Patch looks great! Reviews applied: [38535] All tests passed. -

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-20 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99704 --- Ship it! Thanks for the catch!! LGTM module the memory leak.

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/ --- (Updated Sept. 20, 2015, 4:08 p.m.) Review request for mesos, Jie Yu, Joris

Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/ --- Review request for mesos, Jie Yu, Joris Van Remoortere, and Michael Park.

Re: Review Request 38457: CMake: Fix MESOS-3250, a dynamic load error in Stout tests on OS X.

2015-09-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38457/ --- (Updated Sept. 21, 2015, 2:43 a.m.) Review request for mesos, Artem

Re: Review Request 38540: [VIA HAOSDENT] [2/2]Generate make batch file to build project in windows.

2015-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38540/#review99721 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530,

Re: Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common definitions file.

2015-09-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38538/#review99720 --- Ship it! Ship It! - haosdent huang On Sept. 21, 2015, 2:33

Review Request 38541: CMake: Add `Versions.cmake` as an analog to `versions.am`.

2015-09-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38541/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

2015-09-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38542/ --- Review request for mesos, Artem Harutyunyan, Joris Van Remoortere, and Joseph

Re: Review Request 38542: CMake: Use version info from `Versions.cmake` instead of magic strings.

2015-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38542/#review99722 --- Patch looks great! Reviews applied: [38456, 38457, 38529, 38530,

Re: Review Request 37993: WIP: Add explanatory comments for Allocator interface

2015-09-20 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/ --- (Updated 九月 21, 2015, 5:02 a.m.) Review request for mesos, Adam B, Alexander

Review Request 38540: [VIA HAOSDENT] [2/2]Generate make batch file to build project in windows.

2015-09-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38540/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van

Review Request 38539: [VIA HAOSDENT] [1/2]Add CMake macro VsBuildCommand in libprocess.

2015-09-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38539/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van

Review Request 38538: [VIA HAOSDENT] CMake: Add `CMAKE_NOOP` to common definitions file.

2015-09-20 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38538/ --- Review request for mesos, haosdent huang, Artem Harutyunyan, Joris Van

Re: Review Request 37993: WIP: Add explanatory comments for Allocator interface

2015-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37993/#review99723 --- Bad patch! Reviews applied: [37993] Failed command:

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99705 --- Patch looks great! Reviews applied: [38535] All tests passed. -

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/#review99708 --- Patch looks great! Reviews applied: [38535] All tests passed. -

Re: Review Request 37873: Add quiesce logic in allocator

2015-09-20 Thread Vinod Kone
> On Sept. 17, 2015, 9:42 p.m., Vinod Kone wrote: > > src/tests/mesos.hpp, line 1608 > > > > > > Needs a test for the scheduler driver. I've only see one for the http > > scheduler library. > > > > Also,

Re: Review Request 38535: Fix ExamplesTest errors when user is root.

2015-09-20 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38535/ --- (Updated Sept. 20, 2015, 5:04 p.m.) Review request for mesos, Jie Yu, Joris

Re: Review Request 37585: Maintenance primitives: Add a user doc.

2015-09-20 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37585/#review99711 --- Ship it! fixed inline. docs/maintenance.md (lines 139 - 140)